[jira] [Commented] (SOLR-9280) make nodeName a configurable parameter in solr.xml
[
https://issues.apache.org/jira/browse/SOLR-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583388#comment-15583388
]
ASF GitHub Bot commented on SOLR-9280:
--
Github user kelaban commented on the issue:
https://github.com/apache/lucene-solr/pull/50
Additionally work for SOLR-9281 is being done here
(https://github.com/kelaban/lucene-solr/tree/jira/master/SOLR-9281) but will
hold out on a PR as it relies on this branch
> make nodeName a configurable parameter in solr.xml
> --
>
> Key: SOLR-9280
> URL: https://issues.apache.org/jira/browse/SOLR-9280
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Keith Laban
>Assignee: Shalin Shekhar Mangar
>
> Originally node name is automatically generated based on
> {{:_}}. Instead it should be configurable in solr.xml
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9280) make nodeName a configurable parameter in solr.xml
[
https://issues.apache.org/jira/browse/SOLR-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583342#comment-15583342
]
ASF GitHub Bot commented on SOLR-9280:
--
Github user kelaban commented on the issue:
https://github.com/apache/lucene-solr/pull/50
Updated so the patch now applies cleanly. I've been having trouble getting
tests to pass on vanilla master branch, so I cannot tell if this is causing any
to fail. I've spot checked a few tests with this patch and they worked fine
> make nodeName a configurable parameter in solr.xml
> --
>
> Key: SOLR-9280
> URL: https://issues.apache.org/jira/browse/SOLR-9280
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Keith Laban
>Assignee: Shalin Shekhar Mangar
>
> Originally node name is automatically generated based on
> {{:_}}. Instead it should be configurable in solr.xml
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9280) make nodeName a configurable parameter in solr.xml
[
https://issues.apache.org/jira/browse/SOLR-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368343#comment-15368343
]
ASF GitHub Bot commented on SOLR-9280:
--
Github user kelaban commented on the issue:
https://github.com/apache/lucene-solr/pull/50
Randomly setting nodeName in tests which extend from
`AbstractFullDistribZkTestBase` hits about 60 solr cloud tests. But there are
also about 30 other cloud tests which use `MiniSolrCloudCluster` which will
not get this randomness applied. To increase coverage we can add randomness
into this class as well.
> make nodeName a configurable parameter in solr.xml
> --
>
> Key: SOLR-9280
> URL: https://issues.apache.org/jira/browse/SOLR-9280
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Keith Laban
>
> Originally node name is automatically generated based on
> {{:_}}. Instead it should be configurable in solr.xml
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9280) make nodeName a configurable parameter in solr.xml
[
https://issues.apache.org/jira/browse/SOLR-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368288#comment-15368288
]
ASF GitHub Bot commented on SOLR-9280:
--
GitHub user kelaban opened a pull request:
https://github.com/apache/lucene-solr/pull/50
SOLR-9280 - make nodeName a configurable parameter in solr.xml
This patch makes live nodeName configurable via solr.xml by setting
```xml
${solr.nodeName:}
```
To test, I randomly set nodeName in `AbstractFullDistribZkTestBase` for
complete coverage.
I've gotten all tests to pass both when ALWAYS using a random nodeName and
with it being set randomly. However during one particular run I got a test
failure for the following:
`ant test -Dtestcase=TestReqParamsAPI -Dtests.method=test
-Dtests.seed=391BC4715DE8C2FE -Dtests.slow=true -Dtests.locale=pl-PL
-Dtests.timezone=Asia/Chungking -Dtests.asserts=true
-Dtests.file.encoding=UTF-8` but am unable to reproduce the issue in eclipse
and at this time am not sure if its related
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kelaban/lucene-solr jira/master/SOLR-9280
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
commit b1de1f9ef97a5957747f7fcb9ac9e7ce4acfac84
Author: Keith Laban
Date: 2016-06-30T15:12:16Z
SOLR-9280 - make nodeName a configurable parameter in solr.xml
> make nodeName a configurable parameter in solr.xml
> --
>
> Key: SOLR-9280
> URL: https://issues.apache.org/jira/browse/SOLR-9280
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Keith Laban
>
> Originally node name is automatically generated based on
> {{:_}}. Instead it should be configurable in solr.xml
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9280) make nodeName a configurable parameter in solr.xml
[
https://issues.apache.org/jira/browse/SOLR-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363601#comment-15363601
]
Keith Laban commented on SOLR-9280:
---
I started working on this. The approach I am looking is this:
1) Add nodeName as a solr.xml property
2) in ZkController when starting if nodeName property is set use this one
otherwise fall back to the genericNodeName :_ convention
3) change live nodes to have data in each ephemeral node such that the path
name is nodeName and the data is genericNodeName. Essentially building a
nodeName -> genericNodeName mapping.
4) in ZkStateReader change liveNodes from a Set to a
Map. This can be done without having to change any public
interfaces or anything external to the class
5) the major problem here is the method {{getBaseUrlForNodeName}} which takes a
nodeName and returns a baseUrl. The method assumes that input nodeName is going
to be in the genericNodeName format and there are tests which validate this.
What i'm working on doing is creating a new method called
{{getBaseUrlForGenericNodeName}} which basically does what
{{getBaseUrlForNodeName}} did the updated version of {{getBaseUrlForNodeName}}
will do the lookup for genericNodeName in the liveNodes map and then do the
generic -> baseUrl conversion. Past that I'm just working on tracking down what
uses the original method to see if there will be any issues anywhere. So far it
doesn't look like it, but I haven't run the full test suite yet.
Doing some manual testing with the changes i'm able to start two nodes with
custom node names and use admin api for creating/modifying/deleting collections
and replicas.
Overall this approach is pretty self contained with not a whole lot of code
modification. Also, without addition code if you try to start a second node
with the same name it will block the instance from starting and timeout and die
eventually, which is the desired behavior.
I hope to have a patch up sometime this week
> make nodeName a configurable parameter in solr.xml
> --
>
> Key: SOLR-9280
> URL: https://issues.apache.org/jira/browse/SOLR-9280
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Keith Laban
>
> Originally node name is automatically generated based on
> {{:_}}. Instead it should be configurable in solr.xml
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
