Re: [DISCUSS] SIP-6 Solr should own the bootstrap process

2020-03-25 Thread Jan Høydahl
web.xml > > Uwe > > - > Uwe Schindler > Achterdiek 19, D-28357 Bremen > https://www.thetaphi.de <https://www.thetaphi.de/> > eMail: u...@thetaphi.de <mailto:u...@thetaphi.de> > > From: Uwe Schindler > Sent: Wednesday, March 25, 2020 6:44 PM > T

RE: [DISCUSS] SIP-6 Solr should own the bootstrap process

2020-03-25 Thread Uwe Schindler
:44 PM To: dev@lucene.apache.org Subject: RE: [DISCUSS] SIP-6 Solr should own the bootstrap process Hi, I agree, this should be a change in 9.0 only. In general we can start with web.xml still existing (the bootstrap code would use a Jetty “WebAppContext” initially). At a later stage

RE: [DISCUSS] SIP-6 Solr should own the bootstrap process

2020-03-25 Thread Uwe Schindler
From: Mike Drob Sent: Wednesday, March 25, 2020 6:07 PM To: dev@lucene.apache.org Subject: Re: [DISCUSS] SIP-6 Solr should own the bootstrap process I think we like to pretend that Jetty and web.xml are implementation details, but I'm not sure how good of a job we do. Whether we need

RE: [DISCUSS] SIP-6 Solr should own the bootstrap process

2020-03-25 Thread Uwe Schindler
] SIP-6 Solr should own the bootstrap process Would being able to manage CORS settings be part of this? Now that Solr is ramping up it’s default security posture, there are many applications that used to work that don’t. Today, changing Solr’s CORS settings is very cumbersome, requiring

Re: [DISCUSS] SIP-6 Solr should own the bootstrap process

2020-03-25 Thread Mike Drob
I think we like to pretend that Jetty and web.xml are implementation details, but I'm not sure how good of a job we do. Whether we need to provide backwards compatibility or not is the wrong question I think, because when we break compatibility we are telling a subset of our users that it will

Re: [DISCUSS] SIP-6 Solr should own the bootstrap process

2020-03-25 Thread Eric Pugh
Would being able to manage CORS settings be part of this? Now that Solr is ramping up it’s default security posture, there are many applications that used to work that don’t. Today, changing Solr’s CORS settings is very cumbersome, requiring changing an embedded web.xml. Making it easier to

Re: [DISCUSS] SIP-6 Solr should own the bootstrap process

2020-03-25 Thread Jan Høydahl
I agree. I changed the SIP page and now have four bullet points defined as in scope for the SIP: > The most important change in this SIP will be > Create a solr/bootstrap module with a solr.jar to replace start.jar as the > entrypoint (java -jar solr.jar ...) > Hide jetty even more, i.e.

Re: [DISCUSS] SIP-6 Solr should own the bootstrap process

2020-03-25 Thread Mike Drob
I'm in favor of this approach mainly because of the line mentioned in the Test Plan: > If we move servlet initialization into Java code and get rid of web.xml, we may be able to start Solr in the same way both in tests and in real life! I feel that this should be a top level goal, along with