[RESULT] [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 3
Hi, The vote has passed with the following result: +1 : Robert Scholte, Hervé Boutemy, Karl Heinz Marbaise PMC quorum: reached. I will promote the artifacts to the central repo. Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 3
Hi Hervé, On 20/09/17 08:07, Hervé BOUTEMY wrote: sorry, the failure was with an old jdk 1.9+134 with latest jdk 1.9+181, everything is ok then here is my +1 notice one WARNING: [INFO] Building: non-default-config-headerfiles/pom.xml [INFO] run post-build script verify.groovy WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy- all-2.4.8.jar) to method java.lang.Object.finalize() WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release [INFO] non-default-config-headerfiles/pom.xml ... SUCCESS (2.4 s) Created an issue for that: https://issues.apache.org/jira/browse/MJMOD-6 Thanks for testing... Kind regards Karl Heinz Marbaise Regards, Hervé Le mercredi 20 septembre 2017, 07:52:39 CEST Hervé BOUTEMY a écrit : tested "mvn verify" and got failure for every IT: Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-create of goal org.apache.maven.plugins:maven-jmod-plugin:3.0.0- alpha-1:create failed: 9 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPl uginManager.java: 148) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java: 208) ... 20 more Caused by: java.lang.ArrayIndexOutOfBoundsException: 9 at org.objectweb.asm.ClassReader.readUTF8(Unknown Source) at org.objectweb.asm.ClassReader.a(Unknown Source) at org.objectweb.asm.ClassReader.readModule(Unknown Source) at org.objectweb.asm.ClassReader.a(Unknown Source) at org.objectweb.asm.ClassReader.accept(Unknown Source) at org.objectweb.asm.ClassReader.accept(Unknown Source) at org.codehaus.plexus.languages.java.jpms.AsmModuleInfoParser.parse(AsmModuleI nfoParser.java: 90) at org.codehaus.plexus.languages.java.jpms.AsmModuleInfoParser.getModuleDescrip tor(AsmModuleInfoParser.java: 54) at org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePaths(Locatio nManager.java: 117) at org.apache.maven.plugins.jmod.JModCreateMojo.preparePaths(JModCreateMojo.jav a: 484) at org.apache.maven.plugins.jmod.JModCreateMojo.execute(JModCreateMojo.java:306 ) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPl uginManager.java: 137) ... 21 more Regards, Hervé Le dimanche 17 septembre 2017, 13:40:50 CEST Karl Heinz Marbaise a écrit : Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&; ve rsion=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1369/ https://repository.apache.org/content/repositories/maven-1369/org/apache/m av en/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha- 1-s ource-release.zip Source release checksum(s): maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: aa00b98c534f24e8141ee0beace2aff3be899688 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 3
sorry, the failure was with an old jdk 1.9+134 with latest jdk 1.9+181, everything is ok then here is my +1 notice one WARNING: [INFO] Building: non-default-config-headerfiles/pom.xml [INFO] run post-build script verify.groovy WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy- all-2.4.8.jar) to method java.lang.Object.finalize() WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release [INFO] non-default-config-headerfiles/pom.xml ... SUCCESS (2.4 s) Regards, Hervé Le mercredi 20 septembre 2017, 07:52:39 CEST Hervé BOUTEMY a écrit : > tested "mvn verify" and got failure for every IT: > > Caused by: org.apache.maven.plugin.PluginExecutionException: Execution > default-create of goal org.apache.maven.plugins:maven-jmod-plugin:3.0.0- > alpha-1:create failed: 9 > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPl > uginManager.java: 148) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java: > 208) > ... 20 more > Caused by: java.lang.ArrayIndexOutOfBoundsException: 9 > at org.objectweb.asm.ClassReader.readUTF8(Unknown Source) > at org.objectweb.asm.ClassReader.a(Unknown Source) > at org.objectweb.asm.ClassReader.readModule(Unknown Source) > at org.objectweb.asm.ClassReader.a(Unknown Source) > at org.objectweb.asm.ClassReader.accept(Unknown Source) > at org.objectweb.asm.ClassReader.accept(Unknown Source) > at > org.codehaus.plexus.languages.java.jpms.AsmModuleInfoParser.parse(AsmModuleI > nfoParser.java: 90) > at > org.codehaus.plexus.languages.java.jpms.AsmModuleInfoParser.getModuleDescrip > tor(AsmModuleInfoParser.java: 54) > at > org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePaths(Locatio > nManager.java: 117) > at > org.apache.maven.plugins.jmod.JModCreateMojo.preparePaths(JModCreateMojo.jav > a: 484) > at > org.apache.maven.plugins.jmod.JModCreateMojo.execute(JModCreateMojo.java:306 > ) at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPl > uginManager.java: 137) > ... 21 more > > Regards, > > Hervé > > Le dimanche 17 septembre 2017, 13:40:50 CEST Karl Heinz Marbaise a écrit : > > Hi, > > > > this is the VOTE for the first public release for Maven JMod Plugin... > > > > We solved 4 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&; > > ve rsion=12341363 > > > > There are currently no issues left in JIRA. > > > > If you have any issue to report please open an issue in JIRA > > https://issues.apache.org/jira/projects/MJMOD > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1369/ > > > > https://repository.apache.org/content/repositories/maven-1369/org/apache/m > > av > > en/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha- > > 1-s ource-release.zip > > > > Source release checksum(s): > > maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: > > aa00b98c534f24e8141ee0beace2aff3be899688 > > > > Staging site: > > https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > Kind regards > > Karl Heinz Marbaise > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 3
tested "mvn verify" and got failure for every IT: Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-create of goal org.apache.maven.plugins:maven-jmod-plugin:3.0.0- alpha-1:create failed: 9 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java: 148) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java: 208) ... 20 more Caused by: java.lang.ArrayIndexOutOfBoundsException: 9 at org.objectweb.asm.ClassReader.readUTF8(Unknown Source) at org.objectweb.asm.ClassReader.a(Unknown Source) at org.objectweb.asm.ClassReader.readModule(Unknown Source) at org.objectweb.asm.ClassReader.a(Unknown Source) at org.objectweb.asm.ClassReader.accept(Unknown Source) at org.objectweb.asm.ClassReader.accept(Unknown Source) at org.codehaus.plexus.languages.java.jpms.AsmModuleInfoParser.parse(AsmModuleInfoParser.java: 90) at org.codehaus.plexus.languages.java.jpms.AsmModuleInfoParser.getModuleDescriptor(AsmModuleInfoParser.java: 54) at org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePaths(LocationManager.java: 117) at org.apache.maven.plugins.jmod.JModCreateMojo.preparePaths(JModCreateMojo.java: 484) at org.apache.maven.plugins.jmod.JModCreateMojo.execute(JModCreateMojo.java:306) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java: 137) ... 21 more Regards, Hervé Le dimanche 17 septembre 2017, 13:40:50 CEST Karl Heinz Marbaise a écrit : > Hi, > > this is the VOTE for the first public release for Maven JMod Plugin... > > We solved 4 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&ve > rsion=12341363 > > There are currently no issues left in JIRA. > > If you have any issue to report please open an issue in JIRA > https://issues.apache.org/jira/projects/MJMOD > > Staging repo: > https://repository.apache.org/content/repositories/maven-1369/ > > https://repository.apache.org/content/repositories/maven-1369/org/apache/mav > en/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-s > ource-release.zip > > Source release checksum(s): > maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: > aa00b98c534f24e8141ee0beace2aff3be899688 > > Staging site: > https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Kind regards > Karl Heinz Marbaise > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 3
Hi, one more PMC vote is needed... Kind regards Karl Heinz Marbaise On 17/09/17 13:40, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1369/ https://repository.apache.org/content/repositories/maven-1369/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: aa00b98c534f24e8141ee0beace2aff3be899688 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 3
Hi, here my +1... Kind regards Karl Heinz Marbaise On 17/09/17 13:40, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1369/ https://repository.apache.org/content/repositories/maven-1369/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: aa00b98c534f24e8141ee0beace2aff3be899688 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 3
+1 On Sun, 17 Sep 2017 13:40:50 +0200, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1369/ https://repository.apache.org/content/repositories/maven-1369/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: aa00b98c534f24e8141ee0beace2aff3be899688 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 3
Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1369/ https://repository.apache.org/content/repositories/maven-1369/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: aa00b98c534f24e8141ee0beace2aff3be899688 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[CANCELED] [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 2
I cancel the VOTE based on the issues found. Kind regards Karl Heinz Marbaise On 16/09/17 21:12, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1368/ https://repository.apache.org/content/repositories/maven-1368/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: 3ba47cb30af765b6e67fbf16ccee50dbdac29142 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 2
On Sun, 17 Sep 2017 11:30:05 +0200, Karl Heinz Marbaise wrote: Hi Robert, On 17/09/17 10:54, Robert Scholte wrote: -1 https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/list-mojo.html https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/describe-mojo.html So here's where the moduleName is used: Better not to have a default value here, it is VERY unlikely that it is the artifactId, in fact, it shouldn't (it's like making the groupId the same as the artifactId). Only if there's a module descriptor you can use that name. Ah sure... So If I correctly get this..in case for jmod list/describe only the name of the jmod file is needed ? First would be to prevent confusions and to name the parameter "jmodFileName" ? I'm not sure how these goals are going to be used. Will it be used on "this" project or any jmod artifact? Or both? For the first I would use the project.build.finalName + ".jmod", for the latter the GAV? And take the default artifactId cause usually they will be named like this...and if the name is different you have to explicitly set it... Furthermore the question is: Should I assume having a jmod file are being located in "target/jmods/" directory as default ? I guess this depends on what's configured for the create-goal, but IIRC /target is not allowed because it is not an empty directory, so target/jmods makes sense to me. https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/create-mojo.html Still show the classpath, shouldn't be a parameter. The --class-path option should be set to the classpathElements which has been calclulated by preparePaths() method if I correctly understand ? So the parameter can be completeley removed ? That's what I would expect. You feed all the project dependency artifacts ( = jars ) to the LocationManager, which will decide where they belong to. Latest commits already improved the plugin a lot, we're almost there. thanks, Robert On Sat, 16 Sep 2017 21:12:16 +0200, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1368/ https://repository.apache.org/content/repositories/maven-1368/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: 3ba47cb30af765b6e67fbf16ccee50dbdac29142 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 2
Hi Robert, On 17/09/17 10:54, Robert Scholte wrote: -1 https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/list-mojo.html https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/describe-mojo.html So here's where the moduleName is used: Better not to have a default value here, it is VERY unlikely that it is the artifactId, in fact, it shouldn't (it's like making the groupId the same as the artifactId). Only if there's a module descriptor you can use that name. Ah sure... So If I correctly get this..in case for jmod list/describe only the name of the jmod file is needed ? First would be to prevent confusions and to name the parameter "jmodFileName" ? And take the default artifactId cause usually they will be named like this...and if the name is different you have to explicitly set it... Furthermore the question is: Should I assume having a jmod file are being located in "target/jmods/" directory as default ? https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/create-mojo.html Still show the classpath, shouldn't be a parameter. The --class-path option should be set to the classpathElements which has been calclulated by preparePaths() method if I correctly understand ? So the parameter can be completeley removed ? Latest commits already improved the plugin a lot, we're almost there. thanks, Robert On Sat, 16 Sep 2017 21:12:16 +0200, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1368/ https://repository.apache.org/content/repositories/maven-1368/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: 3ba47cb30af765b6e67fbf16ccee50dbdac29142 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 2
-1 https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/list-mojo.html https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/describe-mojo.html So here's where the moduleName is used: Better not to have a default value here, it is VERY unlikely that it is the artifactId, in fact, it shouldn't (it's like making the groupId the same as the artifactId). Only if there's a module descriptor you can use that name. https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/create-mojo.html Still show the classpath, shouldn't be a parameter. Latest commits already improved the plugin a lot, we're almost there. thanks, Robert On Sat, 16 Sep 2017 21:12:16 +0200, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1368/ https://repository.apache.org/content/repositories/maven-1368/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: 3ba47cb30af765b6e67fbf16ccee50dbdac29142 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release) Take 2
Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1368/ https://repository.apache.org/content/repositories/maven-1368/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): maven-jmod-plugin-3.0.0-alpha-1-source-release.zip sha1: 3ba47cb30af765b6e67fbf16ccee50dbdac29142 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[CANCEL] [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)
I will cancel the VOTE based on found issues.. Kind regards Karl Heinz Marbaise On 09/09/17 15:52, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1361/ https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): [NAME-OF]-source-release.zip sha1: 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)
Hi Robert, On 11/09/17 21:11, Robert Scholte wrote: Hi, isn't it weird that jmod:create has parameters for classpath and modulepath? why not start using the dependencies as specified in the pom? and the plugin shouldn't use artifactId as default for the modulename. Current best practice is to include the packagename as namespace. And if the module-info.class is there, it is also possible to extract this value with plexus-java I'm sorry, but I have to give this a -1. No need to applogize...Very good hints... I can help fix these things. Robert On Sat, 09 Sep 2017 15:52:24 +0200, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1361/ https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): [NAME-OF]-source-release.zip sha1: 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org Mit freundlichem Gruß Karl-Heinz Marbaise -- SoftwareEntwicklung Beratung SchulungTel.: +49 (0) 2405 / 415 893 Dipl.Ing.(FH) Karl-Heinz MarbaiseUSt.IdNr: DE191347579 Hauptstrasse 177 52146 Würselen http://www.soebes.de - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)
Hi, isn't it weird that jmod:create has parameters for classpath and modulepath? why not start using the dependencies as specified in the pom? and the plugin shouldn't use artifactId as default for the modulename. Current best practice is to include the packagename as namespace. And if the module-info.class is there, it is also possible to extract this value with plexus-java I'm sorry, but I have to give this a -1. I can help fix these things. Robert On Sat, 09 Sep 2017 15:52:24 +0200, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1361/ https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): [NAME-OF]-source-release.zip sha1: 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)
Hi, here is my +1, Kind Regards Karl Heinz Marbaise On 09/09/17 15:52, Karl Heinz Marbaise wrote: Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1361/ https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): [NAME-OF]-source-release.zip sha1: 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)
+1 On 9 September 2017 at 23:52, Karl Heinz Marbaise wrote: > Hi, > > this is the VOTE for the first public release for Maven JMod Plugin... > > We solved 1 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > ctId=12321433&version=12341363 > > There are currently no issues left in JIRA. > > If you have any issue to report please open an issue in JIRA > https://issues.apache.org/jira/projects/MJMOD > > Staging repo: > https://repository.apache.org/content/repositories/maven-1361/ > > https://repository.apache.org/content/repositories/maven-136 > 1/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/ > maven-jmod-plugin-3.0.0-alpha-1-source-release.zip > > Source release checksum(s): > [NAME-OF]-source-release.zip sha1: 8002767f6cffc7bbbcf76a8e7f0c17 > 99a42caf93 > > Staging site: > https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Kind regards > Karl Heinz Marbaise > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)
+1 Ship it. Karl Heinz Marbaise wrote on 2017-09-09 06:52: > Hi, > > this is the VOTE for the first public release for Maven JMod Plugin... > > We solved 1 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 > > There are currently no issues left in JIRA. > > If you have any issue to report please open an issue in JIRA > https://issues.apache.org/jira/projects/MJMOD > > Staging repo: > https://repository.apache.org/content/repositories/maven-1361/ > > https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip > > Source release checksum(s): > [NAME-OF]-source-release.zip sha1: 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93 > > Staging site: > https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Kind regards > Karl Heinz Marbaise > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)
Hi, this is the VOTE for the first public release for Maven JMod Plugin... We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 There are currently no issues left in JIRA. If you have any issue to report please open an issue in JIRA https://issues.apache.org/jira/projects/MJMOD Staging repo: https://repository.apache.org/content/repositories/maven-1361/ https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip Source release checksum(s): [NAME-OF]-source-release.zip sha1: 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93 Staging site: https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for at least 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
