Re: Boost version upgrade
Just a quick follow-up, the version was bumped to 1.65 in 469363d. On Tue, Jan 9, 2018 at 6:51 PM, Vinod Kone wrote: > If it’s backwards compatible then let’s go for it. > > @vinodkone > > > On Jan 9, 2018, at 9:21 AM, Benno Evers wrote: > > > > Hi folks, > > > > for those of you who were looking at our build infrastructure recently, > you > > may have noticed that the unfortunate combination of the default > `-Werror` > > flag and the bundled boost version that contains code which generates a > > warning regarding unused local typedefs has, over the last year, spawned > > several workarounds including a hardcoded `-Wno-unused-local-typedefs` > > flag, the abuse of the `-isystem` flag to disable warnings in third-party > > dependencies and finally the `--disable-werror` option to not set > `-Werror` > > by default. > > > > To finally get rid of the warning, we were considering upgrading the > > bundled boost version to Boost 1.65 in this review chain: > > https://reviews.apache.org/r/62161/ > > > > As far as I'm aware, this change should be fully backwards-compatible for > > people who are building against a non-bundled version of boost. > > > > Would there be any objections or concerns from the community about this? > > > > Best regards, > > -- > > Benno Evers > > Software Engineer, Mesosphere > -- Benno Evers Software Engineer, Mesosphere
Re: Boost version upgrade
If it’s backwards compatible then let’s go for it. @vinodkone > On Jan 9, 2018, at 9:21 AM, Benno Evers wrote: > > Hi folks, > > for those of you who were looking at our build infrastructure recently, you > may have noticed that the unfortunate combination of the default `-Werror` > flag and the bundled boost version that contains code which generates a > warning regarding unused local typedefs has, over the last year, spawned > several workarounds including a hardcoded `-Wno-unused-local-typedefs` > flag, the abuse of the `-isystem` flag to disable warnings in third-party > dependencies and finally the `--disable-werror` option to not set `-Werror` > by default. > > To finally get rid of the warning, we were considering upgrading the > bundled boost version to Boost 1.65 in this review chain: > https://reviews.apache.org/r/62161/ > > As far as I'm aware, this change should be fully backwards-compatible for > people who are building against a non-bundled version of boost. > > Would there be any objections or concerns from the community about this? > > Best regards, > -- > Benno Evers > Software Engineer, Mesosphere
Re: Boost version upgrade
I think this is a great idea. I've recently worked through fixing the existent warnings for Mesos on Windows, and got to the point that third-party dependencies are that's left generating warnings, so I'm a big +1 for updating the Boost bundle to fix warnings the correct way. I'd happily see the `-isystem` removed from the CMake build if this fully resolves warnings incurred by Boost. On 01/09/2018 9:21 am, Benno Evers wrote: Hi folks, for those of you who were looking at our build infrastructure recently, you may have noticed that the unfortunate combination of the default `-Werror` flag and the bundled boost version that contains code which generates a warning regarding unused local typedefs has, over the last year, spawned several workarounds including a hardcoded `-Wno-unused-local-typedefs` flag, the abuse of the `-isystem` flag to disable warnings in third-party dependencies and finally the `--disable-werror` option to not set `-Werror` by default. To finally get rid of the warning, we were considering upgrading the bundled boost version to Boost 1.65 in this review chain: https://reviews.apache.org/r/62161/ As far as I'm aware, this change should be fully backwards-compatible for people who are building against a non-bundled version of boost. Would there be any objections or concerns from the community about this? Best regards,
