Re: Convention for Backward Compatibility for New Operations in Mesos 1.6

2018-04-16 Thread James Peach
> On Apr 16, 2018, at 2:04 PM, Chun-Hung Hsiao wrote: > > Hi all, > > As some might have already known, we are currently working on patches to > implement the new GROW_VOLUME and SHRINK_VOLUME operations [1]. > > One problem surfaces is that, since the new operations are not supported in > Mes

Re: Convention for Backward Compatibility for New Operations in Mesos 1.6

2018-04-16 Thread Greg Mann
> Crashing the agent is definitely not a viable option IMO. > > Why can't we use agent capabilities instead of agent version and reject > such operations at master? This is one of the main reasons we introduced > the concept of framework, master, agent capabilities. > > One thing worth mentioning i

Re: Convention for Backward Compatibility for New Operations in Mesos 1.6

2018-04-16 Thread Chun-Hung Hsiao
If we do option 1, then there will be no agent crash since the master won't send any unknown operation to an old agent, so option 2 is not a necessity. On Mon, Apr 16, 2018 at 2:12 PM, Silas Snider wrote: > I think we should definitely do option 2 regardless of whether we do > option 1 as well,

Re: Convention for Backward Compatibility for New Operations in Mesos 1.6

2018-04-16 Thread Chun-Hung Hsiao
Are you suggesting that for every new operation we'll introduce a new capability? On Mon, Apr 16, 2018 at 2:14 PM, Vinod Kone wrote: > Crashing the agent is definitely not a viable option IMO. > > Why can't we use agent capabilities instead of agent version and reject > such operations at master

Re: Convention for Backward Compatibility for New Operations in Mesos 1.6

2018-04-16 Thread Vinod Kone
Crashing the agent is definitely not a viable option IMO. Why can't we use agent capabilities instead of agent version and reject such operations at master? This is one of the main reasons we introduced the concept of framework, master, agent capabilities. On Mon, Apr 16, 2018 at 2:04 PM, Chun-Hu

Re: Convention for Backward Compatibility for New Operations in Mesos 1.6

2018-04-16 Thread Silas Snider
I think we should definitely do option 2 regardless of whether we do option 1 as well, since although in this case it will still crash 1.5.0, at least in the future we won't have to have this worry again. On 4/16/18, 2:04 PM, "Chun-Hung Hsiao" wrote: Hi all, As some might have al