GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/901
METRON-1410 Check for existing HBASE tables before creating
After upgrade, indexing will not restart because it fails to create HBase
tables. This is because they already exist from the
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/888#discussion_r162669706
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
---
@@
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/901#discussion_r162677398
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/900
---
Github user lvets commented on the issue:
https://github.com/apache/metron/pull/890
+1 from me, both changes look good.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/901#discussion_r162677587
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/897
+1 Good catch @MohanDV . Thanks
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/900
+1 by inspection. good catch.
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/901#discussion_r162666350
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/897
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/902
METRON-1413 Add Metron Commit Tool
This PR contributes the `prepare-merge` tool that many (some?) contributors
use back to the project itself. Up until now, it has been managed in a
separate
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/902
@nickwallen , excellent to get this into the main repo, and totally agree
with the reorganization.
My only suggestion is that the main directory, currently named
"metron-dev-support",
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
Thanks @mattf-horton. Either of those suggestions works for me;
'dev-support' or 'dev-utilities'. I'll let others chime in with their
preference and then update it accordingly.
---
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/902#discussion_r162688528
--- Diff: metron-dev-support/committer-utils/README.md ---
@@ -0,0 +1,96 @@
+# Committer Tools
+
+This project contains tools to assist Apache
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/902
I have a mild preference for dev-utilities, since "support" has many
meanings.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/902
I think checkout-pr is equally as valuable and should be included
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/902
Maybe we can have reviewer tools and put checkout-pr in it? For those
without an apache id?
---
Folks,
May I suggest Metron follows the NiFi mailing list strategy (we got
inspired by another project but I don't recall the name) and remove the
github comments from the dev list?
Within NiFi we have both the dev and the issues lists. dev is for humans,
issues is for JIRA and github
I could get behind that.
On Fri, Jan 19, 2018 at 3:31 PM, Andre wrote:
> Folks,
>
> May I suggest Metron follows the NiFi mailing list strategy (we got
> inspired by another project but I don't recall the name) and remove the
> github comments from the dev list?
>
> Within
I would give that +1 as well.
Jon
On Fri, Jan 19, 2018 at 3:32 PM Casey Stella wrote:
> I could get behind that.
>
> On Fri, Jan 19, 2018 at 3:31 PM, Andre wrote:
>
> > Folks,
> >
> > May I suggest Metron follows the NiFi mailing list strategy (we
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
I don't see the value in `checkout-pr` any longer. You can just use
`prepare-commit` which gives you the exact view of what the code would
look-like when its merged.
---
Github user MohanDV closed the pull request at:
https://github.com/apache/metron/pull/891
---
Github user MohanDV commented on the issue:
https://github.com/apache/metron/pull/891
Created another pull request which will address this issue
---
23 matches
Mail list logo