Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/6
I'm +1 on this. @nickwallen anything outstanding on your end?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/6
+1 Looks great. Thanks @dcode
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174181759
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/SendToKafka.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licens
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/958
@justinleet thanks for the review. I reacted to your comments either by
fixing them or suggesting why I prefer what is there. I will add a new set of
tests in the next commit.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186316
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/LoadGenerator.java
---
@@ -0,0 +1,165 @@
+/**
+ * Lice
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186275
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/LoadGenerator.java
---
@@ -0,0 +1,165 @@
+/**
+ * Lice
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186490
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/MessageGenerator.java
---
@@ -0,0 +1,48 @@
+/**
+ * Li
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186422
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/LoadOptions.java
---
@@ -0,0 +1,504 @@
+/**
+ * Licens
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186403
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/LoadGenerator.java
---
@@ -0,0 +1,165 @@
+/**
+ * Lice
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186458
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/LoadOptions.java
---
@@ -0,0 +1,504 @@
+/**
+ * Licens
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186359
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/LoadGenerator.java
---
@@ -0,0 +1,165 @@
+/**
+ * Lice
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186529
--- Diff:
metron-contrib/metron-performance/src/test/java/org/apache/metron/performance/load/SendToKafkaTest.java
---
@@ -0,0 +1,49 @@
+/**
+ * Lic
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186597
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/monitor/writers/ConsoleWriter.java
---
@@ -0,0 +1,67 @@
+/
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186641
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/monitor/writers/Writer.java
---
@@ -0,0 +1,91 @@
+/**
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186800
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/sampler/UnbiasedSampler.java
---
@@ -0,0 +1,28 @@
+/**
+ *
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186700
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/monitor/writers/Writer.java
---
@@ -0,0 +1,91 @@
+/**
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186826
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/sampler/BiasedSampler.java
---
@@ -0,0 +1,95 @@
+/**
+ * Li
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/958#discussion_r174186723
--- Diff:
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/sampler/BiasedSampler.java
---
@@ -0,0 +1,95 @@
+/**
+ * Li
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/942
So, I would suggest rather than accepting a list of stats objects, `MAX`
and `MIN` accept one of the following:
* A StatisticsProvider object
* A list of comparables
Essentially, the
19 matches
Mail list logo
