[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174653589 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174652376 --- Diff: metron-platform/Performance-tuning-guide.md --- @@ -422,10 +422,12 @@ modifying the options outlined above, increasing the poll timeout, or

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174653285 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174654407 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174653386 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174653490 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174652892 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a

[GitHub] metron pull request #958: METRON-1483: Create a tool to monitor performance ...

2018-03-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/958#discussion_r174478516 --- Diff: metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/SendToKafka.java --- @@ -0,0 +1,107 @@ +/** + *

[GitHub] metron pull request #958: METRON-1483: Create a tool to monitor performance ...

2018-03-14 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/958#discussion_r174488230 --- Diff: metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/SendToKafka.java --- @@ -0,0 +1,107 @@ +/** + *

[GitHub] metron pull request #958: METRON-1483: Create a tool to monitor performance ...

2018-03-14 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/958#discussion_r174468438 --- Diff: metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/SendToKafka.java --- @@ -0,0 +1,107 @@ +/** + *

[GitHub] metron issue #961: METRON-1487 Define Performance Benchmarks for Enrichment ...

2018-03-14 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/961 I'm +1 by inspection, assuming @cestella is good with the requested changes. ---

[GitHub] metron pull request #963: METRON-1490: Better error message when user specif...

2018-03-14 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/963 METRON-1490: Better error message when user specifies an enrichment type that doesn't exist ## Contributor Comments If a user specifies an enrichment adapter name that doesn't exist (e.g.

[GitHub] metron issue #958: METRON-1483: Create a tool to monitor performance of the ...

2018-03-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/958 Moving this conversation to the top. I believe I have refactored the KafkaProducers appropriately. Let me know if I missed something, @justinleet ---