Re: [DISCUSS] Charset PR merge effects

2019-02-25 Thread Michael Miklavcic
Justin, I like your proposal. I just had a couple thoughts that I think are worth pointing out. I'm not 100% clear about this point, but I don't believe we currently handle the possibility of various external data sources with heterogeneous encoding schemes in our Kafka topics. As it stands, I

[DISCUSS] Charset PR merge effects

2019-02-20 Thread Justin Leet
Hey all, I wanted to bring a bit of attention to a change and its effects before I push to master. PR#1341 Removes all uses of the default charset (which is platform dependent) and moves everything to UTF-8. This PR currently has a +1, but obviously