[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user nickwallen commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 @dcode 1. The JIRA created for this is https://issues.apache.org/jira/browse/METRON-1469. 1. Please change the PR title to "METRON-1469: Kafka Plugin for Bro -

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user dcode commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 That'd be great if you wouldn't mind to create a ticket for this. ---

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 It's a part of the `apache/metron` project (of which this is considered a component) and uses the open apache JIRA that I linked above. In order to accept PRs we need to have a

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user dcode commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 I haven't created a JIRA ticket. Not sure if that's something internal. ---

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 This is really coming together. Is there a

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 Okay great, thanks. I will add to my todo list this week to get this and #5 tested and in. Then we can look at merging #2 and maybe the bool option to send all logs. ---

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user dcode commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 Yes I can fix that On Feb 24, 2018 13:51, "JonZeolla" wrote: > Would you mind removing the send all logs by default portion of this? I >

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user dcode commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 Oh I wasn't trying to throw accusations. I actually contributed that code to the bro plugins repo and a couple other forks. I can remove the default on behavior. I this patch in

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 Would you mind removing the send all logs by default portion of this? I would love to get this reviewed and in but I feel like that approach could be problematic and is better

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 Thanks @dcode I'll need to review this more specifically but I don't recall using any of your contributions for my other work. I modeled it after other plugins in the old

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

Github user dcode commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 I know #2 has some of my original code of two separate sets (I previously PR'd this against @JonZeolla's branch), one to include and one to exclude. I think that's fine too, but I've