Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/690
Perfect, ty.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/690
Done, let me know if the changes are sufficient @JonZeolla
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/690
@JonZeolla this should be set
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/690
This looks reasonable to me @ottobackwards. I'm +1 pending any further work
per @JonZeolla's comments. Thanks for the contribution!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/690
Hopefully it is all set @JonZeolla
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/690
Sorry , it has been a while, I'll try to get it set
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/690
Can you deconflict? I'd like to retest and review your questions again,
but at a quick glance I think my prior suggestions stand, and for your NOTICE
question, I'm not sure.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/690
I have refactored this to be stellar centric.
We will create a second archive for the stand alone shell from
stellar-common.
I also documented it in the stellar README.md.
The
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/690
Right, I think the disconnect is that I would envision a stellar shell with
metron stellar functions added as libs, as you suggested. That's why I was
thinking we would doc in stellar-common, I
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/690
I'm going to close this and refactor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/690
@JonZeolla I don't want to document it in the stellar-common module.
Stellar is being broken out of metron. The packaging of stellar as a
shell, with the likely inclusion of metron-*
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/690
bump - any comments on this? Any ideas for deployment? can we leave for
later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/690
I just want to make sure that we didn't break backwards compatibility and
have the shell not deployed as part of the mpack, I guess ;)
---
If your project is set up for it, you can reply to this
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/690
Casey, this adds a new packaging subfolder -> archive, and generates a new
artifact ( the tar.gz ).
It does not effect the current deployment of the stellar shell as a part of
metron.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/690
@JonZeolla Thanks for the review!
There are several questions in the description that I think need to fall
out of the review, one of them is where or how to document this.
Any
15 matches
Mail list logo
