Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/902
+1
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
I merged with master, so I expect Travis to be happy now. Just need +1s
and I'll get this in to allow for any follow-ons.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/902
I have another script I want to add for tracking master in feature branches
after this as well
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/902
I can almost always be bought off with a jira number
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
> @ottobackwards: I think of there being two users for these scripts...
That makes perfect sense to me. Can we tackle that in a follow-on?
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/902
I'm definitely fine with leaving HTML encoding to a follow-on.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/902
I think of there being two users for these scripts.
1. Committers, that will benefit by having scripted commit actions
2. Reviewers who would benefit by having scripted PR downloads
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/902
I'm game to merge the `prepare-commit` and `checkout-pr` logic into one
script; I'm even fine with pushing that to be a follow-on.
Regarding the HTML-encoded JIRA description issue, I'm
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/902
Re: the single quoting issue.
Avoiding the XML blob and using the main rest endpoint seems to kick back
actual quotation marks. Now you have to read JSON instead of XML, but it might
be
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
> @JonZeolla: ... the curl command HTML encodes the JIRA description but I
don't know of a clean bash-native way to decode it.
Yes, I have noticed, especially with apostrophes. When that
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
Also, I've never liked the name `prepare-commit`. If you guys can think of
something better, please let me know.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
Travis had a hickup... Doing the "close/reopen" dance to trigger the CI
build.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
The Apache ID isn't really necessary to use `prepare-commit`. What if I
just changed the docs to note that it is not required? I could document how
you could use the script to review a PR.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/902
Maybe we can have reviewer tools and put checkout-pr in it? For those
without an apache id?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
I don't see the value in `checkout-pr` any longer. You can just use
`prepare-commit` which gives you the exact view of what the code would
look-like when its merged.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/902
I think checkout-pr is equally as valuable and should be included
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/902
I have a mild preference for dev-utilities, since "support" has many
meanings.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/902
Thanks @mattf-horton. Either of those suggestions works for me;
'dev-support' or 'dev-utilities'. I'll let others chime in with their
preference and then update it accordingly.
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/902
@nickwallen , excellent to get this into the main repo, and totally agree
with the reorganization.
My only suggestion is that the main directory, currently named
"metron-dev-support",
19 matches
Mail list logo
