Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/909
@cestella You're right about that - the general goodness. We (I) had made
the mistake of doing some test refactoring in the ES upgrade branch that would
have been better done in a separate PR,
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/909
+1 pending travis
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/909
Sounds good, +1 Good work here, that test was confusing.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/909
I think this is useful outside of any Solr work and I intended for it to go
into master.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/909
@cestella This is going into master per the merge notes, right?
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/909
Should this be against master or should this be committed against the Solr
branch? It *seems* like this is general purpose goodness and maybe fits in
master, but I wanted to double check.
---
