[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/851 ---

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-06 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r155347462 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -572,15 +590,22 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154824244 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,42 @@

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154824031 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,42 @@

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-04 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154821946 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,42 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154804149 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -572,15 +590,22 @@

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154803527 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -572,15 +590,22 @@

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-04 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154799152 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -572,15 +590,22 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-04 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154798328 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,42 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154761355 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,42 @@

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154763112 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -572,15 +590,22 @@

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-04 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154663544 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-02 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154508609 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-02 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154508202 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-01 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154461563 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-12-01 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154461007 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154231709 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154215790 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154209165 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154208493 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154208318 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -156,7 +156,7 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154207865 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -156,7 +156,7 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154207614 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -156,7 +156,7 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154207266 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -156,7 +156,7 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154206090 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154204458 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-30 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/851#discussion_r154202685 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java --- @@ -343,25 +343,57 @@ public

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-28 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/851 METRON-1336 Patching Can Result in Bad Configuration The following problems are addressed in this PR. * A patch can be constructed that when applied creates an invalid configuration.