[GitHub] metron pull request #907: METRON-1427: Add support for storm 1.1 and hdp 2.6

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/907


---

[GitHub] metron pull request #907: METRON-1427: Add support for storm 1.1 and hdp 2.6

[cestella]

GitHub user cestella reopened a pull request:

https://github.com/apache/metron/pull/907

METRON-1427: Add support for storm 1.1 and hdp 2.6

## Contributor Comments
Right now our ambari mpack won't run cleanly on HDP 2.6 and Storm 1.1 
because of some classpath issues and not supporting the stack.  We should 
migrate fulldev to run 2.6 (while still working with 2.5) and validate that we 
work with storm 1.1.   The only code changes in here is relocating and shading 
jackson (kerberized storm 1.1 requires a conflicting version of jackson from ES 
and us, so we shade and relocate it in parsers, but didn't in profiler and 
elasticsearch uber jars.  This PR corrects that).  


You can validate this by:
* Running up full-dev and ensuring data flows through
* Kerberizing full-dev and ensure things still work

I have done the above, but you can feel free to do the same.  
## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cestella/incubator-metron 2.6_investigation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/907.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #907


commit 4486b7ff58bfb98a5bc1ed8e05490fb7202bab9f
Author: cstella 
Date:   2018-01-22T22:11:18Z

Updating the stack definitions and such on the mpack to 2.6

commit 972fe01e19e28f3be94393d83b49a269dbc09e9c
Author: cstella 
Date:   2018-01-23T17:10:38Z

random service check bug

commit 5d56bc1fba811630554192e2fc8614b2050d520d
Author: cstella 
Date:   2018-01-24T00:36:37Z

Updating poms to relocate jackson.

commit b89fa88ddd769aece0e211c4b87a4b0bb15aa309
Author: cstella 
Date:   2018-01-24T16:32:05Z

Added comments.

commit 8e03c293d01ce33026c87302a821fa9a5b91c8dc
Author: cstella 
Date:   2018-01-24T19:54:02Z

Merge branch 'master' into 2.6_investigation

commit c13956ed594bcdaf26923fa49f15690949850fb5
Author: cstella 
Date:   2018-01-25T14:17:12Z

Merge branch 'master' into 2.6_investigation

commit 3969a67a24cf07825fe2cd0a2418c9654b7e78c8
Author: cstella 
Date:   2018-01-25T14:28:43Z

Normalizing security protocols to the one that kafka supports.




---

[GitHub] metron pull request #907: METRON-1427: Add support for storm 1.1 and hdp 2.6

[cestella]

Github user cestella closed the pull request at:

https://github.com/apache/metron/pull/907


---

[GitHub] metron pull request #907: METRON-1427: Add support for storm 1.1 and hdp 2.6

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/907#discussion_r163606292
  
--- Diff: metron-deployment/roles/ambari_config/vars/single_node_vm.yml ---
@@ -87,6 +87,11 @@ configurations:
   supervisor.slots.ports: "[6700, 6701, 6702, 6703, 6704, 6705]"
   storm.local.dir: '{{ storm_local_dir }}'
   topology.classpath: '{{ topology_classpath }}'
+  storm.cluster.metrics.consumer.register: '[{"class": 
"org.apache.storm.metric.LoggingMetricsConsumer"}]'
--- End diff --

Sounds good, did that


---

[GitHub] metron pull request #907: METRON-1427: Add support for storm 1.1 and hdp 2.6

[cestella]

Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/907#discussion_r163602345
  
--- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/5.6.2/package/scripts/service_check.py
 ---
@@ -32,7 +32,7 @@ def service_check(self, env):
 doc = '{"name": "Ambari Smoke test"}'
 index = "ambari_smoke_test"
 
-Logger.info("Running Elastic search service check", 
file=sys.stdout)
+Logger.info("Running Elastic search service check")
--- End diff --

It would be normally, but I couldn't test it in kerberos without it (status 
check fails when kerberizing because of this).  As soon as master is fixed and 
#904 is in (has my +1 already), I'll merge.


---

[GitHub] metron pull request #907: METRON-1427: Add support for storm 1.1 and hdp 2.6

[anandsubbu]

Github user anandsubbu commented on a diff in the pull request:

https://github.com/apache/metron/pull/907#discussion_r163600738
  
--- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/5.6.2/package/scripts/service_check.py
 ---
@@ -32,7 +32,7 @@ def service_check(self, env):
 doc = '{"name": "Ambari Smoke test"}'
 index = "ambari_smoke_test"
 
-Logger.info("Running Elastic search service check", 
file=sys.stdout)
+Logger.info("Running Elastic search service check")
--- End diff --

Hi @cestella , would it be a good idea to leave this unchanged since 
@mmiklavc has PR #904 which addresses this issue?


---

[GitHub] metron pull request #907: METRON-1427: Add support for storm 1.1 and hdp 2.6

[justinleet]

Github user justinleet commented on a diff in the pull request:

https://github.com/apache/metron/pull/907#discussion_r163600063
  
--- Diff: metron-deployment/roles/ambari_config/vars/single_node_vm.yml ---
@@ -87,6 +87,11 @@ configurations:
   supervisor.slots.ports: "[6700, 6701, 6702, 6703, 6704, 6705]"
   storm.local.dir: '{{ storm_local_dir }}'
   topology.classpath: '{{ topology_classpath }}'
+  storm.cluster.metrics.consumer.register: '[{"class": 
"org.apache.storm.metric.LoggingMetricsConsumer"}]'
--- End diff --

Could you add a comment or explanation about why the changes to the Storm 
config?  The other changes are pretty straightforward, but it's not obvious why 
we need config changes (unless you already know its to deal with Storm issues 
around metrics and killing JMX from the childopts).



---

[GitHub] metron pull request #907: METRON-1427: Add support for storm 1.1 and hdp 2.6

[cestella]

GitHub user cestella opened a pull request:

https://github.com/apache/metron/pull/907

METRON-1427: Add support for storm 1.1 and hdp 2.6

## Contributor Comments
Right now our ambari mpack won't run cleanly on HDP 2.6 and Storm 1.1 
because of some classpath issues and not supporting the stack.  We should 
migrate fulldev to run 2.6 (while still working with 2.5) and validate that we 
work with storm 1.1.   The only code changes in here is relocating and shading 
jackson (kerberized storm 1.1 requires a conflicting version of jackson from ES 
and us, so we shade and relocate it in parsers, but didn't in profiler and 
elasticsearch uber jars.  This PR corrects that).  


You can validate this by:
* Running up full-dev and ensuring data flows through
* Kerberizing full-dev and ensure things still work

I have done the above, but you can feel free to do the same.  
## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cestella/incubator-metron 2.6_investigation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/907.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #907


commit 4486b7ff58bfb98a5bc1ed8e05490fb7202bab9f
Author: cstella 
Date:   2018-01-22T22:11:18Z

Updating the stack definitions and such on the mpack to 2.6

commit 972fe01e19e28f3be94393d83b49a269dbc09e9c
Author: cstella 
Date:   2018-01-23T17:10:38Z

random service check bug

commit 5d56bc1fba811630554192e2fc8614b2050d520d
Author: cstella 
Date:   2018-01-24T00:36:37Z

Updating poms to relocate jackson.




---