RE: [DISCUSS] Make MKLDNN as a default on Maven nightly build
Hi Lanking, I'm not familiar with Maven nightly build. But does it look like what we have for python - different packages with different building flags, or just has one package with MKL-DNN enabled? Currently as showed in https://github.com/apache/incubator-mxnet/issues/8671, for python we have 'mxnet' package without MKL-DNN backend and 'mxnet-mkl' with MKL-DNN backend. -tao -Original Message- From: Lv, Tao A [mailto:tao.a...@intel.com] Sent: Tuesday, January 15, 2019 8:14 AM To: dev@mxnet.incubator.apache.org Subject: Re: [DISCUSS] Make MKLDNN as a default on Maven nightly build MKLML has already been released with mxnet-mkl for 4 versions: 1.2.0, 1.2.1, 1.3.0, 1.3.1. > On Jan 15, 2019, at 3:43 AM, Zach Kimberg wrote: > > There should not be a problem including MKLML since the above (BSD > 3-clause) is Category A under apache ( > https://www.apache.org/legal/resolved.html#what-can-we-include-in-an-a > sf-project-category-a > ). > > However, what I noticed from some other apache projects is they > created additional LICENSE files (LICENSE.binary, etc.) to include > with the release packages. This should include everything in our > source LICENSE file along with all licensing information for > everything that was part of the released package such as the MKLML > license above. This license should then be bundled as part of our > distribution package. > >> On Mon, Jan 14, 2019 at 11:19 AM Sheng Zha wrote: >> >> +1 if the licensing aspect is ok. Since MKLDNN (open source apache 2 >> license) depends on MKLML (binary only) which carries its own license >> (see below for the full text), we need to check if it's ok to include >> this license in our binary distribution. Full text of the MKLML license: >> >> Copyright (c) 2016-2018, Intel Corporation All rights reserved. >> >> Redistribution and use in source and binary forms, with or without >> modification, are permitted provided that the following conditions are met: >> >>* Redistributions of source code must retain the above copyright >> notice, >> this list of conditions and the following disclaimer. >>* Redistributions in binary form must reproduce the above copyright >> notice, this list of conditions and the following disclaimer in the >> documentation and/or other materials provided with the distribution. >>* Neither the name of Intel Corporation nor the names of its >> contributors >> may be used to endorse or promote products derived from this software >> without specific prior written permission. >> >> THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" >> AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, >> THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A >> PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT >> OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, >> SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT >> LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, >> DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY >> THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT >> (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE >> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> >>> On Mon, Jan 14, 2019 at 10:56 AM Qing Lan wrote: >>> >>> Hi all, >>> >>> I would like to raise a discussion on whether to make MKLDNN as a >>> default in nightly build (1.5.0-SNAPSHOT) for MXNet Scala/Java >>> binding. Currently Scala build with MKLDNN is supported since >>> https://github.com/apache/incubator-mxnet/pull/13819 with CI. I do >>> see the performance increase when dealing with the inference and it >>> is also necessary to get it in nightly for beta-testing in order to >>> make it official in 1.5.0. >>> >>> Thanks, >>> Qing >>> >>
Re: [DISCUSS] Make MKLDNN as a default on Maven nightly build
MKLML has already been released with mxnet-mkl for 4 versions: 1.2.0, 1.2.1, 1.3.0, 1.3.1. > On Jan 15, 2019, at 3:43 AM, Zach Kimberg wrote: > > There should not be a problem including MKLML since the above (BSD > 3-clause) is Category A under apache ( > https://www.apache.org/legal/resolved.html#what-can-we-include-in-an-asf-project-category-a > ). > > However, what I noticed from some other apache projects is they created > additional LICENSE files (LICENSE.binary, etc.) to include with the release > packages. This should include everything in our source LICENSE file along > with all licensing information for everything that was part of the released > package such as the MKLML license above. This license should then be > bundled as part of our distribution package. > >> On Mon, Jan 14, 2019 at 11:19 AM Sheng Zha wrote: >> >> +1 if the licensing aspect is ok. Since MKLDNN (open source apache 2 >> license) depends on MKLML (binary only) which carries its own license (see >> below for the full text), we need to check if it's ok to include this >> license in our binary distribution. Full text of the MKLML license: >> >> Copyright (c) 2016-2018, Intel Corporation >> All rights reserved. >> >> Redistribution and use in source and binary forms, with or without >> modification, are permitted provided that the following conditions are met: >> >>* Redistributions of source code must retain the above copyright >> notice, >> this list of conditions and the following disclaimer. >>* Redistributions in binary form must reproduce the above copyright >> notice, this list of conditions and the following disclaimer in the >> documentation and/or other materials provided with the distribution. >>* Neither the name of Intel Corporation nor the names of its >> contributors >> may be used to endorse or promote products derived from this software >> without specific prior written permission. >> >> THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" >> AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE >> IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE >> ARE >> DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE >> FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL >> DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR >> SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER >> CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT >> LIABILITY, >> OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE >> USE >> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> >>> On Mon, Jan 14, 2019 at 10:56 AM Qing Lan wrote: >>> >>> Hi all, >>> >>> I would like to raise a discussion on whether to make MKLDNN as a default >>> in nightly build (1.5.0-SNAPSHOT) for MXNet Scala/Java binding. Currently >>> Scala build with MKLDNN is supported since >>> https://github.com/apache/incubator-mxnet/pull/13819 with CI. I do see >>> the performance increase when dealing with the inference and it is also >>> necessary to get it in nightly for beta-testing in order to make it >>> official in 1.5.0. >>> >>> Thanks, >>> Qing >>> >>
Re: [DISCUSS] Make MKLDNN as a default on Maven nightly build
There should not be a problem including MKLML since the above (BSD 3-clause) is Category A under apache ( https://www.apache.org/legal/resolved.html#what-can-we-include-in-an-asf-project-category-a ). However, what I noticed from some other apache projects is they created additional LICENSE files (LICENSE.binary, etc.) to include with the release packages. This should include everything in our source LICENSE file along with all licensing information for everything that was part of the released package such as the MKLML license above. This license should then be bundled as part of our distribution package. On Mon, Jan 14, 2019 at 11:19 AM Sheng Zha wrote: > +1 if the licensing aspect is ok. Since MKLDNN (open source apache 2 > license) depends on MKLML (binary only) which carries its own license (see > below for the full text), we need to check if it's ok to include this > license in our binary distribution. Full text of the MKLML license: > > Copyright (c) 2016-2018, Intel Corporation > All rights reserved. > > Redistribution and use in source and binary forms, with or without > modification, are permitted provided that the following conditions are met: > > * Redistributions of source code must retain the above copyright > notice, > this list of conditions and the following disclaimer. > * Redistributions in binary form must reproduce the above copyright > notice, this list of conditions and the following disclaimer in the > documentation and/or other materials provided with the distribution. > * Neither the name of Intel Corporation nor the names of its > contributors > may be used to endorse or promote products derived from this software > without specific prior written permission. > > THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" > AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > ARE > DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE > FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL > DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR > SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER > CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT > LIABILITY, > OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE > USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > On Mon, Jan 14, 2019 at 10:56 AM Qing Lan wrote: > > > Hi all, > > > > I would like to raise a discussion on whether to make MKLDNN as a default > > in nightly build (1.5.0-SNAPSHOT) for MXNet Scala/Java binding. Currently > > Scala build with MKLDNN is supported since > > https://github.com/apache/incubator-mxnet/pull/13819 with CI. I do see > > the performance increase when dealing with the inference and it is also > > necessary to get it in nightly for beta-testing in order to make it > > official in 1.5.0. > > > > Thanks, > > Qing > > >
Re: [DISCUSS] Make MKLDNN as a default on Maven nightly build
+1 if the licensing aspect is ok. Since MKLDNN (open source apache 2 license) depends on MKLML (binary only) which carries its own license (see below for the full text), we need to check if it's ok to include this license in our binary distribution. Full text of the MKLML license: Copyright (c) 2016-2018, Intel Corporation All rights reserved. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. * Neither the name of Intel Corporation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. On Mon, Jan 14, 2019 at 10:56 AM Qing Lan wrote: > Hi all, > > I would like to raise a discussion on whether to make MKLDNN as a default > in nightly build (1.5.0-SNAPSHOT) for MXNet Scala/Java binding. Currently > Scala build with MKLDNN is supported since > https://github.com/apache/incubator-mxnet/pull/13819 with CI. I do see > the performance increase when dealing with the inference and it is also > necessary to get it in nightly for beta-testing in order to make it > official in 1.5.0. > > Thanks, > Qing >
Re: [DISCUSS] Make MKLDNN as a default on Maven nightly build
Thanks for bringing this up. I think it would be less confusing for users if we keep it same across language bindings? What needs to be done to python, Java, Clojure, etc., ? If they are not getting this default, any reason? On Mon, Jan 14, 2019 at 10:56 AM Qing Lan wrote: > Hi all, > > I would like to raise a discussion on whether to make MKLDNN as a default > in nightly build (1.5.0-SNAPSHOT) for MXNet Scala/Java binding. Currently > Scala build with MKLDNN is supported since > https://github.com/apache/incubator-mxnet/pull/13819 with CI. I do see > the performance increase when dealing with the inference and it is also > necessary to get it in nightly for beta-testing in order to make it > official in 1.5.0. > > Thanks, > Qing >
