Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-19 Thread Srivastava, Rohit Kumar
+1 On 7/19/19, 12:59 PM, "Zhu Zhaoqi" wrote: +1 Lin Yuan 于2019年7月19日周五 上午12:06写道: > +1 > > On Fri, Jul 19, 2019 at 12:03 AM Chaitanya Bapat > wrote: > > > +1 definitely. > > > > Going forward, > > MXNet repo as it stands has ~95,000+

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-19 Thread Zhu Zhaoqi
+1 Lin Yuan 于2019年7月19日周五 上午12:06写道: > +1 > > On Fri, Jul 19, 2019 at 12:03 AM Chaitanya Bapat > wrote: > > > +1 definitely. > > > > Going forward, > > MXNet repo as it stands has ~95,000+ lines of Python code [1] > > OpenEdx has a million (10x) LOC and this mammoth effort of porting from > >

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-19 Thread Lin Yuan
+1 On Fri, Jul 19, 2019 at 12:03 AM Chaitanya Bapat wrote: > +1 definitely. > > Going forward, > MXNet repo as it stands has ~95,000+ lines of Python code [1] > OpenEdx has a million (10x) LOC and this mammoth effort of porting from > Python 2 to 3 is treated as a separate project named

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-19 Thread Chaitanya Bapat
+1 definitely. Going forward, MXNet repo as it stands has ~95,000+ lines of Python code [1] OpenEdx has a million (10x) LOC and this mammoth effort of porting from Python 2 to 3 is treated as a separate project named Incremental Improvement. [2] We can take inspiration from them and have a

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Kshitij Kalambarkar
+1 On Fri, Jul 19, 2019, 04:28 Pedro Larroy wrote: > Seems 3.6 is a reasonable choice. > > On Thu, Jul 18, 2019 at 2:15 PM Marco de Abreu > wrote: > > > > Looking at EOL is certainly a good idea! I think once we get closer to > > deprecation, we can check adoption statistics to make a

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Pedro Larroy
Seems 3.6 is a reasonable choice. On Thu, Jul 18, 2019 at 2:15 PM Marco de Abreu wrote: > > Looking at EOL is certainly a good idea! I think once we get closer to > deprecation, we can check adoption statistics to make a well-informed > decision that gives us the most advantages without dropping

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Marco de Abreu
Looking at EOL is certainly a good idea! I think once we get closer to deprecation, we can check adoption statistics to make a well-informed decision that gives us the most advantages without dropping the ball on a majority of users (or supporting a branch that is going EOL soon). A survey from

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Yuan Tang
I would suggest supporting Python 3.5+ since the earlier versions have reached end-of-life status: https://devguide.python.org/devcycle/#end-of-life-branches On Thu, Jul 18, 2019 at 3:36 PM Pedro Larroy wrote: > +1 > > This would simplify CI, reduce costs and more. I think a followup > question

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Pedro Larroy
+1 This would simplify CI, reduce costs and more. I think a followup question is what would be the mininum Python3 version supported? Depending on that we might be able to use type annotations for example or other features. Pedro. On Thu, Jul 18, 2019 at 12:07 PM Yuan Tang wrote: > > +1 > > On

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Yuan Tang
+1 On Thu, Jul 18, 2019 at 2:51 PM Yuxi Hu wrote: > +1 > > On Thu, Jul 18, 2019 at 11:31 AM Tong He wrote: > > > +1 > > > > Best regards, > > > > Tong He > > > > > > Jake Lee 于2019年7月18日周四 上午11:29写道: > > > > > +1 > > > > > > On Thu, Jul 18, 2019 at 11:27 AM Junru Shao > > > wrote: > > > > >

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Yuxi Hu
+1 On Thu, Jul 18, 2019 at 11:31 AM Tong He wrote: > +1 > > Best regards, > > Tong He > > > Jake Lee 于2019年7月18日周四 上午11:29写道: > > > +1 > > > > On Thu, Jul 18, 2019 at 11:27 AM Junru Shao > > wrote: > > > > > +1 > > > > > > On Thu, Jul 18, 2019 at 11:12 AM Anirudh Acharya < >

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Tong He
+1 Best regards, Tong He Jake Lee 于2019年7月18日周四 上午11:29写道: > +1 > > On Thu, Jul 18, 2019 at 11:27 AM Junru Shao > wrote: > > > +1 > > > > On Thu, Jul 18, 2019 at 11:12 AM Anirudh Acharya > > wrote: > > > > > +1 > > > > > > On Thu, Jul 18, 2019 at 11:03 AM Marco de Abreu < >

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Jake Lee
+1 On Thu, Jul 18, 2019 at 11:27 AM Junru Shao wrote: > +1 > > On Thu, Jul 18, 2019 at 11:12 AM Anirudh Acharya > wrote: > > > +1 > > > > On Thu, Jul 18, 2019 at 11:03 AM Marco de Abreu > > > wrote: > > > > > +1 > > > > > > -Marco > > > > > > Sheng Zha schrieb am Do., 18. Juli 2019, 19:59: >

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Junru Shao
+1 On Thu, Jul 18, 2019 at 11:12 AM Anirudh Acharya wrote: > +1 > > On Thu, Jul 18, 2019 at 11:03 AM Marco de Abreu > wrote: > > > +1 > > > > -Marco > > > > Sheng Zha schrieb am Do., 18. Juli 2019, 19:59: > > > > > Dear MXNet community, > > > > > > I'd like to reopen the discussion on

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Anirudh Acharya
+1 On Thu, Jul 18, 2019 at 11:03 AM Marco de Abreu wrote: > +1 > > -Marco > > Sheng Zha schrieb am Do., 18. Juli 2019, 19:59: > > > Dear MXNet community, > > > > I'd like to reopen the discussion on deprecating python2 support. This > > would help modernize the design and engineering practice

Re: [Discuss] MXNet Python 2 Support Deprecation

2019-07-18 Thread Marco de Abreu
+1 -Marco Sheng Zha schrieb am Do., 18. Juli 2019, 19:59: > Dear MXNet community, > > I'd like to reopen the discussion on deprecating python2 support. This > would help modernize the design and engineering practice in MXNet to help > improve speed and quality. > > For this purpose, I reopened