Re: Python2 End of Life

2019-05-15 Thread Damien Stanton
+1 Standardizing on Python 3 will make things easier for both MXNet devs as
well as users.

On Wed, May 15, 2019 at 2:49 PM sandeep krishnamurthy <
sandeep.krishn...@gmail.com> wrote:

> +1 Thanks for bringing this up Zach.
> Can we include this intent to deprecate support for Python 2, in the
> upcoming MXNet 1.5 release? This will help MXNet community to have enough
> advance notification of proposed plan.
>
> Best,
> Sandeep
>
> On Wed, May 15, 2019 at 11:29 AM Zach Kimberg 
> wrote:
>
> > The website I listed earlier (https://python3statement.org/) is backed
> by
> > a
> > git repository (
> > https://github.com/python3statement/python3statement.github.io) so that
> > projects can open a PR to add themselves to the list. Beyond that, they
> > also have a very nice timeline that projects can add themselves to which
> > details when their support ends. This might be a good first place to
> check
> > for knowing which dependencies might affect us. Here are some of the
> > notable projects and their support that are in the timeline:
> >
> > Projects currently Python3 only: pandas, scikit-learn
> > Projects dropping support betweeen now and Jan 1: IPython, XGBoost, rpy2,
> > dateutil
> > Projects dropping support on Jan 1: CPython, Numpy, Pillow, Scipy,
> > matplotlib, Spyder
> >
> > My hope is that following this discussion, we decide on a timeline and
> add
> > ourselves to this site as well. Does anyone disagree with the choice of
> Jan
> > 1?
> >
> > On Wed, May 15, 2019 at 2:40 AM Marco de Abreu 
> > wrote:
> >
> > > +1
> > >
> > > I'd like to point out that one of our dependencies, scikit, already
> > dropped
> > > support for python 2. If more dependencies drop support before 1.1.20,
> we
> > > might start running into further issues like we already did. As part of
> > > that decision, I'd propose to see what the detailed timelines of our
> > > dependencies are and then adjust our timeline accordingly.
> > >
> > > -Marco
> > >
> > > Pedro Larroy  schrieb am Mi., 15. Mai
> > 2019,
> > > 00:15:
> > >
> > > > +1  Let python2 rest, let's simplify our infrastructure and need to
> > > > support old Python versions.
> > > >
> > > > On Mon, May 13, 2019 at 1:58 PM Jake Lee  wrote:
> > > > >
> > > > > +1 Recently I upgraded the Numpy version and found out that Pylint
> > had
> > > > > false alarm on it. The Pylint fix is only available on Python3. So
> I
> > > > > changed the default python version of 'make pylint' command to
> > python3
> > > > (PR
> > > > > haven't been merged). It's time to drop support for Python2.
> > > > >
> > > > > On Mon, May 13, 2019 at 1:37 PM Junru Shao <
> junrushao1...@gmail.com>
> > > > wrote:
> > > > >
> > > > > > +1
> > > > > >
> > > > > > On Mon, May 13, 2019 at 1:34 PM Aaron Markham <
> > > > aaron.s.mark...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > +1 for the pledge and to start moving things to Python 3.
> > > > > > > I think our installation instructions and tutorials can be
> > updated
> > > to
> > > > > > > default to Python3 and we should update Python2-only
> tutorials. I
> > > > know
> > > > > > > we have a handful of those, and when I spot them, I'll create
> an
> > > > > > > issue.
> > > > > > > I can also look at migrating the docs build to Python 3.
> > > > > > > Should we add a new label for issues relating to migrating to
> > > > Python3?
> > > > > > > Cheers,
> > > > > > > Aaron
> > > > > > >
> > > > > > > On Mon, May 13, 2019 at 12:04 PM Zach Kimberg <
> > > > zachary.kimb...@gmail.com
> > > > > > >
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > Right now, the official date for ending support for Python
> 2.7
> > > > (and all
> > > > > > > of
> > > > > > > > python2) is set to January 1 [1]. As part of it, a number of
> > > > projects
> > > > > > > have
> > > > > > > > pledged to drop support for Python2 in or before 2020
> including
> > > > > > > Tensorflow,
> > > > > > > > requests, pandas, ipython, numpy, pillow, and Cython [2]. I
> > > > believe we
> > > > > > > > should also join in this pledge on python3statement.org [2]
> > > > because it
> > > > > > > > would help clean up our project and it would be difficult to
> > > > continue
> > > > > > > > supporting Python2 anyway when some of our dependencies are
> > > > dropping
> > > > > > > > support.
> > > > > > > >
> > > > > > > > As a concrete step, we should decide on a date to remove all
> > > > usages of
> > > > > > > > Python2 from our CI and consider that officially dropping
> > > support.
> > > > > > > > Following that, we can expect PRs will end up breaking
> support
> > > for
> > > > > > > Python2.
> > > > > > > > I suggest just using the same date that Python is dropping
> > > support
> > > > of
> > > > > > > > January 1. We may also need to update some examples or
> scripts
> > > that
> > > > > > were
> > > > > > > > written only for python2 that are around the project. Any
> > > thoughts?
> > > > > > > >
> > > > > > > > Zach
> > > > > > > >
> > > > > > > >
> > > > > > > > 

Re: Python2 End of Life

2019-05-15 Thread Zach Kimberg
The website I listed earlier (https://python3statement.org/) is backed by a
git repository (
https://github.com/python3statement/python3statement.github.io) so that
projects can open a PR to add themselves to the list. Beyond that, they
also have a very nice timeline that projects can add themselves to which
details when their support ends. This might be a good first place to check
for knowing which dependencies might affect us. Here are some of the
notable projects and their support that are in the timeline:

Projects currently Python3 only: pandas, scikit-learn
Projects dropping support betweeen now and Jan 1: IPython, XGBoost, rpy2,
dateutil
Projects dropping support on Jan 1: CPython, Numpy, Pillow, Scipy,
matplotlib, Spyder

My hope is that following this discussion, we decide on a timeline and add
ourselves to this site as well. Does anyone disagree with the choice of Jan
1?

On Wed, May 15, 2019 at 2:40 AM Marco de Abreu 
wrote:

> +1
>
> I'd like to point out that one of our dependencies, scikit, already dropped
> support for python 2. If more dependencies drop support before 1.1.20, we
> might start running into further issues like we already did. As part of
> that decision, I'd propose to see what the detailed timelines of our
> dependencies are and then adjust our timeline accordingly.
>
> -Marco
>
> Pedro Larroy  schrieb am Mi., 15. Mai 2019,
> 00:15:
>
> > +1  Let python2 rest, let's simplify our infrastructure and need to
> > support old Python versions.
> >
> > On Mon, May 13, 2019 at 1:58 PM Jake Lee  wrote:
> > >
> > > +1 Recently I upgraded the Numpy version and found out that Pylint had
> > > false alarm on it. The Pylint fix is only available on Python3. So I
> > > changed the default python version of 'make pylint' command to python3
> > (PR
> > > haven't been merged). It's time to drop support for Python2.
> > >
> > > On Mon, May 13, 2019 at 1:37 PM Junru Shao 
> > wrote:
> > >
> > > > +1
> > > >
> > > > On Mon, May 13, 2019 at 1:34 PM Aaron Markham <
> > aaron.s.mark...@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 for the pledge and to start moving things to Python 3.
> > > > > I think our installation instructions and tutorials can be updated
> to
> > > > > default to Python3 and we should update Python2-only tutorials. I
> > know
> > > > > we have a handful of those, and when I spot them, I'll create an
> > > > > issue.
> > > > > I can also look at migrating the docs build to Python 3.
> > > > > Should we add a new label for issues relating to migrating to
> > Python3?
> > > > > Cheers,
> > > > > Aaron
> > > > >
> > > > > On Mon, May 13, 2019 at 12:04 PM Zach Kimberg <
> > zachary.kimb...@gmail.com
> > > > >
> > > > > wrote:
> > > > > >
> > > > > > Right now, the official date for ending support for Python 2.7
> > (and all
> > > > > of
> > > > > > python2) is set to January 1 [1]. As part of it, a number of
> > projects
> > > > > have
> > > > > > pledged to drop support for Python2 in or before 2020 including
> > > > > Tensorflow,
> > > > > > requests, pandas, ipython, numpy, pillow, and Cython [2]. I
> > believe we
> > > > > > should also join in this pledge on python3statement.org [2]
> > because it
> > > > > > would help clean up our project and it would be difficult to
> > continue
> > > > > > supporting Python2 anyway when some of our dependencies are
> > dropping
> > > > > > support.
> > > > > >
> > > > > > As a concrete step, we should decide on a date to remove all
> > usages of
> > > > > > Python2 from our CI and consider that officially dropping
> support.
> > > > > > Following that, we can expect PRs will end up breaking support
> for
> > > > > Python2.
> > > > > > I suggest just using the same date that Python is dropping
> support
> > of
> > > > > > January 1. We may also need to update some examples or scripts
> that
> > > > were
> > > > > > written only for python2 that are around the project. Any
> thoughts?
> > > > > >
> > > > > > Zach
> > > > > >
> > > > > >
> > > > > > [1] - https://www.python.org/dev/peps/pep-0373/
> > > > > > [2] - https://python3statement.org/
> > > > >
> > > >
> >
>


Re: Python2 End of Life

2019-05-15 Thread Marco de Abreu
+1

I'd like to point out that one of our dependencies, scikit, already dropped
support for python 2. If more dependencies drop support before 1.1.20, we
might start running into further issues like we already did. As part of
that decision, I'd propose to see what the detailed timelines of our
dependencies are and then adjust our timeline accordingly.

-Marco

Pedro Larroy  schrieb am Mi., 15. Mai 2019,
00:15:

> +1  Let python2 rest, let's simplify our infrastructure and need to
> support old Python versions.
>
> On Mon, May 13, 2019 at 1:58 PM Jake Lee  wrote:
> >
> > +1 Recently I upgraded the Numpy version and found out that Pylint had
> > false alarm on it. The Pylint fix is only available on Python3. So I
> > changed the default python version of 'make pylint' command to python3
> (PR
> > haven't been merged). It's time to drop support for Python2.
> >
> > On Mon, May 13, 2019 at 1:37 PM Junru Shao 
> wrote:
> >
> > > +1
> > >
> > > On Mon, May 13, 2019 at 1:34 PM Aaron Markham <
> aaron.s.mark...@gmail.com>
> > > wrote:
> > >
> > > > +1 for the pledge and to start moving things to Python 3.
> > > > I think our installation instructions and tutorials can be updated to
> > > > default to Python3 and we should update Python2-only tutorials. I
> know
> > > > we have a handful of those, and when I spot them, I'll create an
> > > > issue.
> > > > I can also look at migrating the docs build to Python 3.
> > > > Should we add a new label for issues relating to migrating to
> Python3?
> > > > Cheers,
> > > > Aaron
> > > >
> > > > On Mon, May 13, 2019 at 12:04 PM Zach Kimberg <
> zachary.kimb...@gmail.com
> > > >
> > > > wrote:
> > > > >
> > > > > Right now, the official date for ending support for Python 2.7
> (and all
> > > > of
> > > > > python2) is set to January 1 [1]. As part of it, a number of
> projects
> > > > have
> > > > > pledged to drop support for Python2 in or before 2020 including
> > > > Tensorflow,
> > > > > requests, pandas, ipython, numpy, pillow, and Cython [2]. I
> believe we
> > > > > should also join in this pledge on python3statement.org [2]
> because it
> > > > > would help clean up our project and it would be difficult to
> continue
> > > > > supporting Python2 anyway when some of our dependencies are
> dropping
> > > > > support.
> > > > >
> > > > > As a concrete step, we should decide on a date to remove all
> usages of
> > > > > Python2 from our CI and consider that officially dropping support.
> > > > > Following that, we can expect PRs will end up breaking support for
> > > > Python2.
> > > > > I suggest just using the same date that Python is dropping support
> of
> > > > > January 1. We may also need to update some examples or scripts that
> > > were
> > > > > written only for python2 that are around the project. Any thoughts?
> > > > >
> > > > > Zach
> > > > >
> > > > >
> > > > > [1] - https://www.python.org/dev/peps/pep-0373/
> > > > > [2] - https://python3statement.org/
> > > >
> > >
>


Re: Python2 End of Life

2019-05-14 Thread Pedro Larroy
+1  Let python2 rest, let's simplify our infrastructure and need to
support old Python versions.

On Mon, May 13, 2019 at 1:58 PM Jake Lee  wrote:
>
> +1 Recently I upgraded the Numpy version and found out that Pylint had
> false alarm on it. The Pylint fix is only available on Python3. So I
> changed the default python version of 'make pylint' command to python3 (PR
> haven't been merged). It's time to drop support for Python2.
>
> On Mon, May 13, 2019 at 1:37 PM Junru Shao  wrote:
>
> > +1
> >
> > On Mon, May 13, 2019 at 1:34 PM Aaron Markham 
> > wrote:
> >
> > > +1 for the pledge and to start moving things to Python 3.
> > > I think our installation instructions and tutorials can be updated to
> > > default to Python3 and we should update Python2-only tutorials. I know
> > > we have a handful of those, and when I spot them, I'll create an
> > > issue.
> > > I can also look at migrating the docs build to Python 3.
> > > Should we add a new label for issues relating to migrating to Python3?
> > > Cheers,
> > > Aaron
> > >
> > > On Mon, May 13, 2019 at 12:04 PM Zach Kimberg  > >
> > > wrote:
> > > >
> > > > Right now, the official date for ending support for Python 2.7 (and all
> > > of
> > > > python2) is set to January 1 [1]. As part of it, a number of projects
> > > have
> > > > pledged to drop support for Python2 in or before 2020 including
> > > Tensorflow,
> > > > requests, pandas, ipython, numpy, pillow, and Cython [2]. I believe we
> > > > should also join in this pledge on python3statement.org [2] because it
> > > > would help clean up our project and it would be difficult to continue
> > > > supporting Python2 anyway when some of our dependencies are dropping
> > > > support.
> > > >
> > > > As a concrete step, we should decide on a date to remove all usages of
> > > > Python2 from our CI and consider that officially dropping support.
> > > > Following that, we can expect PRs will end up breaking support for
> > > Python2.
> > > > I suggest just using the same date that Python is dropping support of
> > > > January 1. We may also need to update some examples or scripts that
> > were
> > > > written only for python2 that are around the project. Any thoughts?
> > > >
> > > > Zach
> > > >
> > > >
> > > > [1] - https://www.python.org/dev/peps/pep-0373/
> > > > [2] - https://python3statement.org/
> > >
> >


Re: Python2 End of Life

2019-05-13 Thread Jake Lee
+1 Recently I upgraded the Numpy version and found out that Pylint had
false alarm on it. The Pylint fix is only available on Python3. So I
changed the default python version of 'make pylint' command to python3 (PR
haven't been merged). It's time to drop support for Python2.

On Mon, May 13, 2019 at 1:37 PM Junru Shao  wrote:

> +1
>
> On Mon, May 13, 2019 at 1:34 PM Aaron Markham 
> wrote:
>
> > +1 for the pledge and to start moving things to Python 3.
> > I think our installation instructions and tutorials can be updated to
> > default to Python3 and we should update Python2-only tutorials. I know
> > we have a handful of those, and when I spot them, I'll create an
> > issue.
> > I can also look at migrating the docs build to Python 3.
> > Should we add a new label for issues relating to migrating to Python3?
> > Cheers,
> > Aaron
> >
> > On Mon, May 13, 2019 at 12:04 PM Zach Kimberg  >
> > wrote:
> > >
> > > Right now, the official date for ending support for Python 2.7 (and all
> > of
> > > python2) is set to January 1 [1]. As part of it, a number of projects
> > have
> > > pledged to drop support for Python2 in or before 2020 including
> > Tensorflow,
> > > requests, pandas, ipython, numpy, pillow, and Cython [2]. I believe we
> > > should also join in this pledge on python3statement.org [2] because it
> > > would help clean up our project and it would be difficult to continue
> > > supporting Python2 anyway when some of our dependencies are dropping
> > > support.
> > >
> > > As a concrete step, we should decide on a date to remove all usages of
> > > Python2 from our CI and consider that officially dropping support.
> > > Following that, we can expect PRs will end up breaking support for
> > Python2.
> > > I suggest just using the same date that Python is dropping support of
> > > January 1. We may also need to update some examples or scripts that
> were
> > > written only for python2 that are around the project. Any thoughts?
> > >
> > > Zach
> > >
> > >
> > > [1] - https://www.python.org/dev/peps/pep-0373/
> > > [2] - https://python3statement.org/
> >
>


Re: Python2 End of Life

2019-05-13 Thread Yuan Tang
+1

On Mon, May 13, 2019 at 4:37 PM Junru Shao  wrote:

> +1
>
> On Mon, May 13, 2019 at 1:34 PM Aaron Markham 
> wrote:
>
> > +1 for the pledge and to start moving things to Python 3.
> > I think our installation instructions and tutorials can be updated to
> > default to Python3 and we should update Python2-only tutorials. I know
> > we have a handful of those, and when I spot them, I'll create an
> > issue.
> > I can also look at migrating the docs build to Python 3.
> > Should we add a new label for issues relating to migrating to Python3?
> > Cheers,
> > Aaron
> >
> > On Mon, May 13, 2019 at 12:04 PM Zach Kimberg  >
> > wrote:
> > >
> > > Right now, the official date for ending support for Python 2.7 (and all
> > of
> > > python2) is set to January 1 [1]. As part of it, a number of projects
> > have
> > > pledged to drop support for Python2 in or before 2020 including
> > Tensorflow,
> > > requests, pandas, ipython, numpy, pillow, and Cython [2]. I believe we
> > > should also join in this pledge on python3statement.org [2] because it
> > > would help clean up our project and it would be difficult to continue
> > > supporting Python2 anyway when some of our dependencies are dropping
> > > support.
> > >
> > > As a concrete step, we should decide on a date to remove all usages of
> > > Python2 from our CI and consider that officially dropping support.
> > > Following that, we can expect PRs will end up breaking support for
> > Python2.
> > > I suggest just using the same date that Python is dropping support of
> > > January 1. We may also need to update some examples or scripts that
> were
> > > written only for python2 that are around the project. Any thoughts?
> > >
> > > Zach
> > >
> > >
> > > [1] - https://www.python.org/dev/peps/pep-0373/
> > > [2] - https://python3statement.org/
> >
>


Re: Python2 End of Life

2019-05-13 Thread Junru Shao
+1

On Mon, May 13, 2019 at 1:34 PM Aaron Markham 
wrote:

> +1 for the pledge and to start moving things to Python 3.
> I think our installation instructions and tutorials can be updated to
> default to Python3 and we should update Python2-only tutorials. I know
> we have a handful of those, and when I spot them, I'll create an
> issue.
> I can also look at migrating the docs build to Python 3.
> Should we add a new label for issues relating to migrating to Python3?
> Cheers,
> Aaron
>
> On Mon, May 13, 2019 at 12:04 PM Zach Kimberg 
> wrote:
> >
> > Right now, the official date for ending support for Python 2.7 (and all
> of
> > python2) is set to January 1 [1]. As part of it, a number of projects
> have
> > pledged to drop support for Python2 in or before 2020 including
> Tensorflow,
> > requests, pandas, ipython, numpy, pillow, and Cython [2]. I believe we
> > should also join in this pledge on python3statement.org [2] because it
> > would help clean up our project and it would be difficult to continue
> > supporting Python2 anyway when some of our dependencies are dropping
> > support.
> >
> > As a concrete step, we should decide on a date to remove all usages of
> > Python2 from our CI and consider that officially dropping support.
> > Following that, we can expect PRs will end up breaking support for
> Python2.
> > I suggest just using the same date that Python is dropping support of
> > January 1. We may also need to update some examples or scripts that were
> > written only for python2 that are around the project. Any thoughts?
> >
> > Zach
> >
> >
> > [1] - https://www.python.org/dev/peps/pep-0373/
> > [2] - https://python3statement.org/
>


Re: Python2 End of Life

2019-05-13 Thread Aaron Markham
+1 for the pledge and to start moving things to Python 3.
I think our installation instructions and tutorials can be updated to
default to Python3 and we should update Python2-only tutorials. I know
we have a handful of those, and when I spot them, I'll create an
issue.
I can also look at migrating the docs build to Python 3.
Should we add a new label for issues relating to migrating to Python3?
Cheers,
Aaron

On Mon, May 13, 2019 at 12:04 PM Zach Kimberg  wrote:
>
> Right now, the official date for ending support for Python 2.7 (and all of
> python2) is set to January 1 [1]. As part of it, a number of projects have
> pledged to drop support for Python2 in or before 2020 including Tensorflow,
> requests, pandas, ipython, numpy, pillow, and Cython [2]. I believe we
> should also join in this pledge on python3statement.org [2] because it
> would help clean up our project and it would be difficult to continue
> supporting Python2 anyway when some of our dependencies are dropping
> support.
>
> As a concrete step, we should decide on a date to remove all usages of
> Python2 from our CI and consider that officially dropping support.
> Following that, we can expect PRs will end up breaking support for Python2.
> I suggest just using the same date that Python is dropping support of
> January 1. We may also need to update some examples or scripts that were
> written only for python2 that are around the project. Any thoughts?
>
> Zach
>
>
> [1] - https://www.python.org/dev/peps/pep-0373/
> [2] - https://python3statement.org/