The SharedStringBuilder is only shared in the current request, so thats not
a poblem.
Take for example the #writeAttribute or #encodeAndWriteAttribute. I added a
counter in #writeAttribute and even for a very small few, it's called about
2000 times.
If you would also count the other instances, i'm
[
https://issues.apache.org/jira/browse/MYFACES-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541614#comment-16541614
]
Matthias Huber edited comment on MYFACES-4245 at 7/12/18 1:17 PM:
---
[
https://issues.apache.org/jira/browse/MYFACES-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541614#comment-16541614
]
Matthias Huber commented on MYFACES-4245:
-
Hi, i think i've found the problem,
[
https://issues.apache.org/jira/browse/MYFACES-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541614#comment-16541614
]
Matthias Huber edited comment on MYFACES-4245 at 7/12/18 1:18 PM:
---
[
https://issues.apache.org/jira/browse/MYFACES-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541614#comment-16541614
]
Matthias Huber edited comment on MYFACES-4245 at 7/12/18 1:18 PM:
---
I'll work to get that additional information.
Also will look into using SharedStringBuilder.
Thanks for the feedback.
Regards,
Paul
From: Thomas Andraschko
To: MyFaces Development
Date: 07/12/2018 03:35 AM
Subject:Re: MYFACES-4244 Discussion
The SharedStringBuilder is o
Hi
The consideration behind SharedStringBuilder is to keep a low memory
footprint, avoiding unnecessary object creation in situations where there
are lines of code that are called many times. It is not something to use
everywhere, only in very specific locations. The best garbage collector is
the
Paul Nicolucci created MYFACES-4247:
---
Summary: [perf] minor performance improvements in FastWriter and a
couple Renderers
Key: MYFACES-4247
URL: https://issues.apache.org/jira/browse/MYFACES-4247
Pr
pnicolucci opened a new pull request #11: MYFACES-4247: reduce number of char[]
objects and CommonPropertyUtils…
URL: https://github.com/apache/myfaces/pull/11
… calls
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541773#comment-16541773
]
ASF GitHub Bot commented on MYFACES-4247:
-
pnicolucci opened a new pull request
pnicolucci commented on issue #11: MYFACES-4247: reduce number of char[]
objects and CommonPropertyUtils…
URL: https://github.com/apache/myfaces/pull/11#issuecomment-404571508
@tandraschko can you review these changes and let me know if you have any
concerns? If not I'll merge this PR.
-
[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541902#comment-16541902
]
ASF GitHub Bot commented on MYFACES-4247:
-
pnicolucci commented on issue #11: M
12 matches
Mail list logo
