Re: MYFACES-4244 Discussion

2018-07-12 Thread Leonardo Uribe
aschko > To: MyFaces Development > Date: 07/12/2018 03:35 AM > Subject: Re: MYFACES-4244 Discussion > -- > > > > The SharedStringBuilder is only shared in the current request, so thats > not a poblem. > Take for example the #writeAttribute

Re: MYFACES-4244 Discussion

2018-07-12 Thread Paul Nicolucci
I'll work to get that additional information. Also will look into using SharedStringBuilder. Thanks for the feedback. Regards, Paul From: Thomas Andraschko To: MyFaces Development Date: 07/12/2018 03:35 AM Subject: Re: MYFACES-4244 Discussion The SharedStringBuild

Re: MYFACES-4244 Discussion

2018-07-12 Thread Thomas Andraschko
The SharedStringBuilder is only shared in the current request, so thats not a poblem. Take for example the #writeAttribute or #encodeAndWriteAttribute. I added a counter in #writeAttribute and even for a very small few, it's called about 2000 times. If you would also count the other instances, i'm

MYFACES-4244 Discussion

2018-07-11 Thread Paul Nicolucci
Hello all, I've made some performance improvements to MyFaces here: https://issues.apache.org/jira/browse/MYFACES-4244 I've put together a Pull Request here with the changes: https://github.com/apache/myfaces/pull/10 I know that Thomas had some concerns with using a StringBuilder here and I thi