Re: minifi-cpp config.yml case-sensitivity

2017-07-13 Thread Andy Christianson
On initial investigation, it doesn’t seem trivial to enable support for this in yaml-cpp. It might be feasible to walk the entire parsed yaml tree and map keys to a to_lower or to_upper key. It would come with some computational and possibly memory cost, but only at config load time, which

Re: minifi-cpp config.yml case-sensitivity

2017-07-13 Thread Marc
Hey Andy, The concern I had was not with performance -- as you said, only at load and reload time -- but more with maintainability. If we make the change to the third party directory we'll have the concern that we lose this capability when someone copies a new version of yaml-cpp into

Re: MINIFI-350 minifi-cpp end-to-end integration testing framework

2017-07-13 Thread Andy Christianson
Yes, I envision having a directory of declarative test cases. Each would include a flow yaml, one or more input files, and expected outputs. I’d like to document the convention before writing the implementation because if the conventions are solid, we can change out the actual test driver

Re: MINIFI-350 minifi-cpp end-to-end integration testing framework

2017-07-13 Thread Andy Christianson
Thanks for the feedback. I will put together a proof of concept which we can further evaluate/refine/merge upstream. -Andy On 7/13/17, 11:30 AM, "Kevin Doran" wrote: Great idea, Andy! Additional types of automated tests would help the minifi-cpp project

minifi-cpp config.yml case-sensitivity

2017-07-13 Thread Andy Christianson
All, It appears that the properties in the config.yml are case-sensitive, and to add to it, they’re inconsistent. E.g. in the example from the README.md file, we have: … Processors: - name: GetFile id: 471deef6-2a6e-4a7d-912a-81cc17e3a206 class:

Re: minifi-cpp config.yml case-sensitivity

2017-07-13 Thread Marc
Hi Andy, I believe this makes sense if Yaml-CPP supports the option, but I would be cautious if we have to change dependencies. If Yaml-CPP does not support this are you proposing to make the change to our third party directory? On Thu, Jul 13, 2017 at 11:09 AM, Andy Christianson <

Re: MINIFI-350 minifi-cpp end-to-end integration testing framework

2017-07-13 Thread Kevin Doran
Great idea, Andy! Additional types of automated tests would help the minifi-cpp project significantly, and I think your proposal is an appropriate way to add integration tests for the minifi agent. This sounds like a great way to verify expected behavior of processors and the system of

Re: minifi-cpp config.yml case-sensitivity

2017-07-13 Thread Kevin Doran
Good catch, Andy. I agree the preferable course of action here would be to make MiNiFi CPP's yaml config parser case-insensitive. Kevin On 7/13/17, 11:09, "Andy Christianson" wrote: All, It appears that the properties in the config.yml are

Re: MINIFI-350 minifi-cpp end-to-end integration testing framework

2017-07-13 Thread Marc
Hi Andy, I think this is a great idea to test integrating MiNiFi among multiple system components. Do you have a feel for how you will allow others to create test cases? Will you attempt to minimize the footprint of contributed tests by creating a bats based framework? I ask because it would be

Re: minifi-cpp config.yml case-sensitivity

2017-07-13 Thread Andy Christianson
My idea of renaming the keys shouldn’t require any changes to yaml-cpp. The pseudocode would be (assuming a simplification that the whole tree is a map of maps, plus leaf values): normalize(yamlTree): if is_leaf(yamlTree): ret yamlTree newTree = {} for key in yamlTree: newKey

Re: MINIFI-350 minifi-cpp end-to-end integration testing framework

2017-07-13 Thread Haimo Liu
great idea Andy! I can see this being extremely valuable even outside of the MINIFI cpp context. Specifically, to migrate my dataflow from one environment to another (DEV to QA to PROD), an integration testing framework could be very helpful for flow validation purposes. in addition to testing

Re: Trigger timer-driven processor to run from outside NIFI

2017-07-13 Thread Koji Kawamura
Hi Ben, Just an idea, using ListenHTTP or HandleHTTPRequest (or whatever listener type processor you can use) in front of your processor might be helpful. You also need to change your processor to support incoming FlowFile as well if it doesn't currently. This way, the outside application can

Re: Adding custom logging Appender to NiFi

2017-07-13 Thread Toivo Adams
Solved. You need to put your custom jar files also to /lib/bootstrap directrory. Regards, Toivo -- View this message in context: http://apache-nifi-developer-list.39713.n7.nabble.com/Adding-custom-logging-Appender-to-NiFi-tp16408p16424.html Sent from the Apache NiFi Developer List mailing