NIFI-4198 - *ElasticsearchHttp processors do not expose Proxy settings

2017-08-12 Thread Arun Manivannan
Hi, Very Good morning. I would like to make an attempt at resolving NIFI-4198 . Looking at the code, I would think by introducing the proxy url and authentication properties and delegating them to the OkHttpClient would be a good way to do it. ht

Re: NIFI-4198 - *ElasticsearchHttp processors do not expose Proxy settings

2017-08-12 Thread Joe Witt
Arun Very cool that you are planning to jump in on this. Your approach sounds like a good start. As far as system testing you're hitting on one of the more challenging parts of the equation here. Your unit tests of course won't integrate with a real ES instance but manual testing can be done ag

Re: NIFI-4198 - *ElasticsearchHttp processors do not expose Proxy settings

2017-08-12 Thread Arun Manivannan
Great. Thanks a lot, Joe. Appreciate your help. Will get it up and running before I assign the issue to myself. Regards, Arun On Sun, Aug 13, 2017 at 3:24 AM Joe Witt wrote: > Arun > > Very cool that you are planning to jump in on this. Your approach > sounds like a good start. As far as s

Re: NIFI-4198 - *ElasticsearchHttp processors do not expose Proxy settings

2017-08-12 Thread Joe Witt
Thanks Arun. If you can document the steps you went through the setup a representative testing environment that would *greatly* help whomever reviews to do the same/similar. The review pipeline for contributions like this can be tough and it is almost always due to helping the reviewer setup the

Re: NIFI-4198 - *ElasticsearchHttp processors do not expose Proxy settings

2017-08-12 Thread Arun Manivannan
Absolutely, I will. Is uploading the steps as a word document to the JIRA an appropriate way? I understand that these steps are specific to a set of JIRAs and the nifi dev guide may or may not be a good home for this. (I can look up how to do that if this is the case). Thanks again, Joe. Cheers A