Re: Namespaces in MiNiFI-cpp

2017-02-16 Thread Aldrin Piri
+1

On Thu, Feb 16, 2017 at 9:32 AM, Jeremy Dyer  wrote:

> Marc - I responded in https://issues.apache.org/jira/browse/MINIFI-217
> directly but I think this is a good idea. The sooner we do this the less
> painful it will be. I also like the additional namespaces like *io and
> *processors that you lay out in the JIRA.
>
> On Thu, Feb 16, 2017 at 7:24 AM, Marc  wrote:
>
> > Good timezone appropriate salutation,
> >
> >I'd like to move the MiNiFi-CPP agent to a more controlled namespace,
> > namely org::apache::nifi::minifi . In an upcoming PR I'll introduce a
> > directory for I/O activities and using namespaces will help better
> isolate
> > and encapsulate the duties of the code; however, I wanted to make sure
> > everyone is okay with these namespace changes.
> >
> > First and foremost, the question would be: will this impact anyone?
> >
> >  https://issues.apache.org/jira/browse/MINIFI-217
> >
> > I wouldn't immediately make the change, to avoid impacting devs who are
> > expecting the global namespace. I put an arbitrary estimate in the ticket
> > to reflect notice being given before applying the change to the mainline.
> >
> >  Feel free to comment on the ticket with objections and/or timeline
> > requests. This is pretty low priority, but I wanted to provide sufficient
> > notice.
> >
> >  Best Regards,
> >  Marc Parisi
> >
>


Re: Namespaces in MiNiFI-cpp

2017-02-16 Thread Jeremy Dyer
Marc - I responded in https://issues.apache.org/jira/browse/MINIFI-217
directly but I think this is a good idea. The sooner we do this the less
painful it will be. I also like the additional namespaces like *io and
*processors that you lay out in the JIRA.

On Thu, Feb 16, 2017 at 7:24 AM, Marc  wrote:

> Good timezone appropriate salutation,
>
>I'd like to move the MiNiFi-CPP agent to a more controlled namespace,
> namely org::apache::nifi::minifi . In an upcoming PR I'll introduce a
> directory for I/O activities and using namespaces will help better isolate
> and encapsulate the duties of the code; however, I wanted to make sure
> everyone is okay with these namespace changes.
>
> First and foremost, the question would be: will this impact anyone?
>
>  https://issues.apache.org/jira/browse/MINIFI-217
>
> I wouldn't immediately make the change, to avoid impacting devs who are
> expecting the global namespace. I put an arbitrary estimate in the ticket
> to reflect notice being given before applying the change to the mainline.
>
>  Feel free to comment on the ticket with objections and/or timeline
> requests. This is pretty low priority, but I wanted to provide sufficient
> notice.
>
>  Best Regards,
>  Marc Parisi
>