Re: Should loadSalesInvoiceFact be run on return instead of commit?

2011-10-12 Thread Paul Foxworthy
Thanks Scott. I see Leon has discovered a similar issue for a different SECA in Jira 4469, but his patch uses global-commit rather than return. I'm happy to submit a patch, but would Leon's approach be better? Cheers Paul Foxworthy Scott Gray-2 wrote: +1 Regards Scott On

Re: Should loadSalesInvoiceFact be run on return instead of commit?

2011-10-12 Thread Martin Kreidenweis
Hi, I see Leon has discovered a similar issue for a different SECA in Jira 4469, but his patch uses global-commit rather than return. I'm happy to submit a patch, but would Leon's approach be better? I think global-commit is usually the way to go for async services (usually

Tomcat and Annotations: dynamically configures application components

2011-10-12 Thread Jacques Le Roux
Hi, FYI, an interesting article about Tomcat 7 (not currently embedded in OFBiz, we use 6.0.33) http://www.tomcatexpert.com/blog/2011/10/12/how-use-fragments-and-annotations-configure-your-web-application Jacques

[jira] [Closed] (OFBIZ-4465) Stock Move: Error when attempting to select a From Stock location

2011-10-12 Thread Jacques Le Roux (Closed) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4465. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04

Re: why storeLogin check StoreCustomerRole ?

2011-10-12 Thread Jacques Le Roux
Hi Elan, Yes you are right with it (I did not check code though). Could you open a Jira and possibly attach a patch? TIA Jacques From: elanzhou elanz...@126.com hi, all: I'm confused by LoginEvents:storeLogin's checkStoreCustomerRole. In org.ofbiz.securityext.login.LoginEvents's

configproductdetail.ftl useless block

2011-10-12 Thread Jacques Le Roux
In both configproductdetail.ftl files, we have this whole useless block if (data._ERROR_MESSAGE_LIST_ != undefined) { //console.log(data._ERROR_MESSAGE_LIST_); //alert(data._ERROR_MESSAGE_LIST_); }else if (data._ERROR_MESSAGE_ != undefined) { //console.log(data._ERROR_MESSAGE_);

[jira] [Updated] (OFBIZ-4469) Load product dimension when and only when the product is created successfully

2011-10-12 Thread Leon (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4469: Attachment: (was: OFBIZ-4469.patch) Load product dimension when and only when the product is created

[jira] [Updated] (OFBIZ-4469) Load product dimension when and only when the product is created successfully

2011-10-12 Thread Leon (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4469: Attachment: OFBIZ-4469.patch use event global-commit-post-run instead. thanks Martin's comments in

[jira] [Created] (OFBIZ-4471) Minor API Extension for WebSiteWorker.java

2011-10-12 Thread Dimitri Unruh (Created) (JIRA)
Minor API Extension for WebSiteWorker.java -- Key: OFBIZ-4471 URL: https://issues.apache.org/jira/browse/OFBIZ-4471 Project: OFBiz Issue Type: Improvement Components: framework

[jira] [Updated] (OFBIZ-4471) Minor API Extension for WebSiteWorker.java

2011-10-12 Thread Dimitri Unruh (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Unruh updated OFBIZ-4471: - Attachment: OFBIZ-4471.patch Minor API Extension for WebSiteWorker.java

discussion: loyalty points

2011-10-12 Thread Hans Bakker
We would like to implement loyalty points. There is a box on the party profile, but no database field, service etc. Because loyalty points are a liability to the customer, accounting should be aware of it and should be registered for example in the billing account, however with a reference to the

Re: discussion: loyalty points

2011-10-12 Thread Adrian Crum
From my perspective, loyalty points are no different than any other discount - so we could use the existing discount-related accounting. -Adrian On 10/12/2011 1:16 PM, Hans Bakker wrote: We would like to implement loyalty points. There is a box on the party profile, but no database field,

Re: discussion: loyalty points

2011-10-12 Thread Hans Bakker
Can you explain more? remember we want to know how many loyalty points are outstanding and we want to know the value which should be transactions in the ledger Regards, Hans On Wed, 2011-10-12 at 13:39 +0100, Adrian Crum wrote: From my perspective, loyalty points are no different than any

Re: discussion: loyalty points

2011-10-12 Thread Adrian Crum
Discounts do not become accounting transactions until they are applied to an invoice - then you can use the existing discount-related accounting. The method of converting loyalty points to a discount is business specific, so I am not sure how that could be implemented in the project. Maybe

[jira] [Created] (OFBIZ-4472) New element auto-parameters-entity for link/hyperlink

2011-10-12 Thread Nicolas Malin (Created) (JIRA)
New element auto-parameters-entity for link/hyperlink - Key: OFBIZ-4472 URL: https://issues.apache.org/jira/browse/OFBIZ-4472 Project: OFBiz Issue Type: New Feature Components:

[jira] [Updated] (OFBIZ-4472) New element auto-parameters-entity for link/hyperlink

2011-10-12 Thread Nicolas Malin (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4472: - Attachment: OFBIZ-4472.patch New element auto-parameters-entity for link/hyperlink

RE: discussion: loyalty points

2011-10-12 Thread Gareth O'Brien
I would think it depends on how the points can be used. If the Loyalty Points have a value and can be used for payment then they are more like an available balance on the Customer's account; like if they had over paid an invoice. You would need to track their loyalty point balance and in the

Re: ServiceName vs CustomMethod

2011-10-12 Thread Nicolas Malin
No opinion ? Le 07/10/2011 18:18, Nicolas Malin a écrit : Hi, I continue my analysis to use EmailTemplateSetting with Content. My idea is to use a service to retrieve information needed to merge with template content before sending the email. The system already use Content entity, great !

[jira] [Commented] (OFBIZ-904) Error when Inventory Facility Id is left blank in product store settings

2011-10-12 Thread Kiran Gawde (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126125#comment-13126125 ] Kiran Gawde commented on OFBIZ-904: --- inventoryFacility can be left blank if there are

[jira] [Created] (OFBIZ-4473) ListProductStoreFacility in StoreScreen.xml is missing decorator-screen element

2011-10-12 Thread Kiran Gawde (Created) (JIRA)
ListProductStoreFacility in StoreScreen.xml is missing decorator-screen element --- Key: OFBIZ-4473 URL: https://issues.apache.org/jira/browse/OFBIZ-4473 Project: OFBiz

[jira] [Updated] (OFBIZ-4473) ListProductStoreFacility in StoreScreen.xml is missing decorator-screen element

2011-10-12 Thread Kiran Gawde (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kiran Gawde updated OFBIZ-4473: --- Attachment: OFBIZ-4473-StoreScreensXml.patch Added decorator-section

[jira] [Created] (OFBIZ-4474) PortalPage Admin screen : change portlet sequence is broken

2011-10-12 Thread Nicolas Malin (Created) (JIRA)
PortalPage Admin screen : change portlet sequence is broken --- Key: OFBIZ-4474 URL: https://issues.apache.org/jira/browse/OFBIZ-4474 Project: OFBiz Issue Type: Bug

[jira] [Updated] (OFBIZ-4474) PortalPage Admin screen : change portlet sequence is broken

2011-10-12 Thread Nicolas Malin (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4474: - Attachment: OFBIZ-4474.patch OFBIZ-4474.png PortalPage Admin screen :

[jira] [Created] (OFBIZ-4475) updateProductStore throws error

2011-10-12 Thread Kiran Gawde (Created) (JIRA)
updateProductStore throws error --- Key: OFBIZ-4475 URL: https://issues.apache.org/jira/browse/OFBIZ-4475 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release Branch 11.04

[jira] [Updated] (OFBIZ-4475) updateProductStore throws error

2011-10-12 Thread Kiran Gawde (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kiran Gawde updated OFBIZ-4475: --- Priority: Minor (was: Major) Description: Edit a store. Hit Update. You will see following

[jira] [Created] (OFBIZ-4476) isStoreInventoryAvailableOrNotRequired doesn't take into account multiple facilities

2011-10-12 Thread Kiran Gawde (Created) (JIRA)
isStoreInventoryAvailableOrNotRequired doesn't take into account multiple facilities Key: OFBIZ-4476 URL: https://issues.apache.org/jira/browse/OFBIZ-4476 Project:

[jira] [Created] (OFBIZ-4477) JavaScript location is empty causes a double requests problem

2011-10-12 Thread Chatree Srichart (Created) (JIRA)
JavaScript location is empty causes a double requests problem - Key: OFBIZ-4477 URL: https://issues.apache.org/jira/browse/OFBIZ-4477 Project: OFBiz Issue Type: Bug

[jira] [Updated] (OFBIZ-4477) JavaScript location is empty causes a double requests problem

2011-10-12 Thread Chatree Srichart (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chatree Srichart updated OFBIZ-4477: Attachment: check_empty_javascript_and_stylesheet.patch This is a patch file to solve the

Issue with multi-select in selectBox widget

2011-10-12 Thread Thomas J. Murphy
I'm trying to update an application from a very old version of the framework and I'm believe I am down to one issue. I have a field in a search form where allow-multiple is set to true as follows: field name=option_ophidden value=in //field field name=option title=Option

[jira] [Created] (OFBIZ-4478) ShoppingCart createDropShipGroups doesn't take into account Marketing packages

2011-10-12 Thread Kiran Gawde (Created) (JIRA)
ShoppingCart createDropShipGroups doesn't take into account Marketing packages -- Key: OFBIZ-4478 URL: https://issues.apache.org/jira/browse/OFBIZ-4478 Project: OFBiz