Re: Welcome Akash Jain as a New Committer!

2017-08-11 Thread Michael Brohl
Welcome to the team, Akash! Regards, Michael Am 09.08.17 um 10:58 schrieb Sharan Foga: The OFBiz PMC has invited Akash Jain to become a new committer and are happy to announce that he has accepted. Some of the key factors considered for inviting him were as follows: - He has been involved w

Re: Welcome Rishi Solanki as a New Committer!

2017-08-11 Thread Michael Brohl
Welcome to the team, Rishi! Regards, Michael Am 09.08.17 um 10:56 schrieb Sharan Foga: The OFBiz PMC has invited Rishi Solanki to become a new committer and are happy to announce that he has accepted. Some of the key factors considered for inviting him were as follows: - He has been involve

Re: [Proposal] - Leverage the CMS capability for Product Store's Email

2017-08-11 Thread Michael Brohl
Hi Swapnil, you can achieve this by just putting something like: <@renderSubContentCache subContentId="${yourContentId!}"/> in your template file for the corresponding screen and edit the content like you proposed. This solution does not support the fallback mechanism you proposed but does

Re: [Proposal] - Leverage the CMS capability for Product Store's Email

2017-08-11 Thread Vaibhav Jain
+1 Swapnil Thanks & Regards Vaibhav Jain Hotwax Systems, vaibhav.j...@hotwaxsystems.com On Fri, Aug 11, 2017 at 11:31 AM, Swapnil Mane < swapnil.m...@hotwaxsystems.com> wrote: > Hello Devs, > > While looking into the support of email templates for Product Store, we > found it is managed by scree

Re: Keep deleteProductionRunRoutingTask?

2017-08-11 Thread Nicolas Malin
Hello Jacques, It's a good example why I explained that delete is interesting in some cases. We implemented a process with template workeffort where an operator create a production run from the templating and delete some task that is not needed before start. In this context, I have no reason

Re: [Proposal] - Leverage the CMS capability for Product Store's Email

2017-08-11 Thread Nicolas Malin
Hello Swapnil, In past I tried to refactoring email interface with the idea to : * deprecate current ProductStoreEmailSetting to link it to TemplateEmailSetting. The purpose is to centralize all email configuration in this entity * link TemplateEmailSetting with Content through TemplateEmailSe

Re: Rule to deprecated a service

2017-08-11 Thread Nicolas Malin
Hello, I imagine the following process : * deprecated on trunk an element and indicate since="$NextReleaseBranch" (or somethink like that) * When before create the new release branch like 17.11 : ** run a replaceAll $NextReleaseBranch by 17.11 ** update the trunk * Create the new stable branch

Re: Missing Method Implementations in OrderChangeHelper

2017-08-11 Thread Kyra Pritzel-Hentley
Hello Jacques, thank you for your reply. I have created a new JIRA-ticket dedicated to removing deprecated code since the one you referred me to seemed to be specifically for code that is commented out. The ticket can be found here: https://issues.apache.org/jira/browse/OFBIZ-9569

Re: Rule to deprecated a service

2017-08-11 Thread Jacques Le Roux
Hi Nicolas, I'm unsure about your point "remove all element contains with a since not on the last stable branch on trunk" I guess you mean "to remove on trunk all elements which contains a 'since=releaseBranchNumber' with releaseBranchNumber being different from the last stable branch just c

Re: Keep deleteProductionRunRoutingTask?

2017-08-11 Thread Jacques Le Roux
Hi Nicolas, All, Nicolas: are you speaking about deleteProductionRunRoutingTask (OFBIZ-9568), deleteWorkEffort (OFBIZ-9185) or both ? I think you answered only about deleteWorkEffort and then I agree. I was also reluctant to remove it. But then we need to define what would be it's minimal imp

Re: Keep deleteProductionRunRoutingTask?

2017-08-11 Thread Jacques Le Roux
Also for beginners we have this advice in FAQ... https://cwiki.apache.org/confluence/display/OFBIZ/FAQ+-+Tips+-+Tricks+-+Cookbook+-+HowTo#FAQ-Tips-Tricks-Cookbook-HowTo-obsolete Jacques Le 11/08/2017 à 17:21, Jacques Le Roux a écrit : Hi Nicolas, All, Nicolas: are you speaking about deletePr

buildbot success in on ofbiz-trunk-framework

2017-08-11 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework/builds/356 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBr

buildbot success in on ofbiz-trunk-framework-plugins

2017-08-11 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/326 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reas

Re: Integration Issues(REST/SOAP) for the latest version 16.11 release in SVN

2017-08-11 Thread Nicolas Malin
Hi Allan, I look your issue on Stackoverflow and I not understand what you tried to do with the legacy-db. How you connect on this db, where is define the data model relative to this db. Do you define some crud service relative to entities that you want to expose ? Nicolas Le 10/08/2017 à

Re: Rule to deprecated a service

2017-08-11 Thread Nicolas Malin
Imagine we are the 30 december 2019 and we decide to create a new release. We have on trunk : * addCatalogMember deprecated since="next release" * deleteRateAmount deprecated since="17.11" * deleteWorkEffortAssignment depraceted since="18.12" We prepare the release, we have on trunk : * addCa

buildbot exception in on ofbiz-trunk-framework

2017-08-11 Thread buildbot
The Buildbot has detected a build exception on builder ofbiz-trunk-framework while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework/builds/357 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reason: The AnyBran

buildbot exception in on ofbiz-trunk-framework-plugins

2017-08-11 Thread buildbot
The Buildbot has detected a build exception on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/327 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build

Re: Rule to deprecated a service

2017-08-11 Thread Jacques Le Roux
This is interesting too https://issues.apache.org/jira/browse/OFBIZ-6273 (thanks Deepak at OFBIZ-9569) Jacques Le 11/08/2017 à 17:05, Jacques Le Roux a écrit : Hi Nicolas, I'm unsure about your point "remove all element contains with a since not on the last stable branch on trunk" I guess

buildbot success in on ofbiz-trunk-framework

2017-08-11 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework/builds/359 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: orcus_ubuntu Build Reason: The AnyBranc

buildbot success in on ofbiz-trunk-framework-plugins

2017-08-11 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/329 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reas