Re: Call to action: fixing defects reported by code analysis tools

2017-07-08 Thread Deepak Dixit
+1 nice initiative Michael!! Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Fri, Jul 7, 2017 at 7:05 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 07/07/2017 à 15:12, Michael Brohl a écrit : > >> Avoiding duplicate errors should be managed through

Re: Call to action: fixing defects reported by code analysis tools

2017-07-07 Thread Jacques Le Roux
Le 07/07/2017 à 15:12, Michael Brohl a écrit : Avoiding duplicate errors should be managed through Jira. If someone wants to work on a class or package, he should file a Jira first so that everyone can see that this is being worked on. Agreed, having one wiki page as reference could also help

Re: Call to action: fixing defects reported by code analysis tools

2017-07-07 Thread Michael Brohl
Avoiding duplicate errors should be managed through Jira. If someone wants to work on a class or package, he should file a Jira first so that everyone can see that this is being worked on. The Jenkins FindBugs plugin/publisher has a very good output with different filters and bug

Re: Call to action: fixing defects reported by code analysis tools

2017-07-07 Thread Jacques Le Roux
I agree with Michael at OFBIZ-9450 that having "the results available to the public so that the community can always access the latest bug statistics." should reduce duplicated efforts. If we can produce the report in HTML format, then we can create a page in wiki and include the report in

Re: Call to action: fixing defects reported by code analysis tools

2017-07-07 Thread Taher Alkhateeb
Fantastic initiative Michael, +1 I think a simple attachment in jira or a wiki page will suffice. A one-time scan would provide more than enough information for everyone who needs to work on stuff. We can run it again in the future when enough bugs have been tackled. On Fri, Jul 7, 2017 at 1:43

Re: Call to action: fixing defects reported by code analysis tools

2017-07-07 Thread Michael Brohl
Hi everyone, we started the first activities in Jira [1]. We have set up an OFBiz build on our Jenkins server who automatically does a FindBugs code analysis after each commit I'm thinking about publishing the results on a web server. This should help to engage contributors to work on the

Re: Call to action: fixing defects reported by code analysis tools

2017-06-29 Thread Michael Brohl
Hi all, just wanted to bring this back in mind in case there are people interested in helping out with this. Every support is well appreciated, thank you! Regards, Michael Brohl ecomify GmbH www.ecomify.de Am 13.12.16 um 18:35 schrieb Jacopo Cappellato: Hi all, thanks to Gradle we have

Re: Call to action: fixing defects reported by code analysis tools

2016-12-19 Thread Jacques Le Roux
Le 14/12/2016 à 07:32, Jacopo Cappellato a écrit : On Tue, Dec 13, 2016 at 7:57 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Just as a note I find very useful to run these tools in Eclipse (the FindBug plugin for instance is conveniently integrated). But I rarely find the time to

Re: Call to action: fixing defects reported by code analysis tools

2016-12-14 Thread Nicolas Malin
Nice, I will try this, thanks for the sharing Nicolas Le 13/12/2016 à 20:42, Taher Alkhateeb a écrit : Thank you Jacopo, this is an excellent idea and would substantially improve our code base. I strongly urge anyone willing to help to speak up or start issuing JIRAs. If anyone needs help in

Re: Call to action: fixing defects reported by code analysis tools

2016-12-13 Thread Jacopo Cappellato
On Tue, Dec 13, 2016 at 7:57 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > > Just as a note I find very useful to run these tools in Eclipse (the > FindBug plugin for instance is conveniently integrated). But I rarely find > the time to work on the reported issues :/ > > Jacques >

Re: Call to action: fixing defects reported by code analysis tools

2016-12-13 Thread Taher Alkhateeb
Thank you Jacopo, this is an excellent idea and would substantially improve our code base. I strongly urge anyone willing to help to speak up or start issuing JIRAs. If anyone needs help in setting up the plugins or has any questions please feel free to discuss them on this ML or HipChat. On Tue,

Re: Call to action: fixing defects reported by code analysis tools

2016-12-13 Thread Jacques Le Roux
Le 13/12/2016 à 18:35, Jacopo Cappellato a écrit : Hi all, thanks to Gradle we have now an easy way to run source code analysis tools on our codebase. Tools like PMD and FindBugs generate useful reports containing pointers to code that may need to be improved or fixed. In fact I have executed