Re: svn commit: r1823562 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/ExternalLoginKeysManager.java

2018-02-09 Thread Scott Gray
Every code change is at a minimum an improvement. Our other tags are just more specific improvements e.g. a fix is an improvement to something that was previously broken. Regards Scott On 9/02/2018 06:19, "Jacques Le Roux" wrote: > I use completed for these cases

Re: svn commit: r1823562 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/ExternalLoginKeysManager.java

2018-02-08 Thread Jacques Le Roux
Missed a ? :) that's OK? (we agreed when we created the template) Le 08/02/2018 à 18:19, Jacques Le Roux a écrit : I use completed for these cases because it's not really an improvement, just syntax sugar, that's OK (we agreed when we created the template) Jacques Le 08/02/2018 à 18:12,

Re: svn commit: r1823562 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/ExternalLoginKeysManager.java

2018-02-08 Thread Jacques Le Roux
I use completed for these cases because it's not really an improvement, just syntax sugar, that's OK (we agreed when we created the template) Jacques Le 08/02/2018 à 18:12, Jacques Le Roux a écrit : Yes sure Jacques Le 08/02/2018 à 16:16, Michael Brohl a écrit : Hi Jacques, can you

Re: svn commit: r1823562 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/ExternalLoginKeysManager.java

2018-02-08 Thread Jacques Le Roux
Yes sure Jacques Le 08/02/2018 à 16:16, Michael Brohl a écrit : Hi Jacques, can you please use "Improved:..." for these commit messages? The "No functional change" message permanently requires extra work to sort out when we prepare the blog details. Thank you, Michael Am 08.02.18 um