Re: Review Request 62459: OOZIE-2296: Add an Oozie diagnostic bundle tool

2017-10-13 Thread Attila Sasvari via Review Board
> On Oct. 6, 2017, 12:26 a.m., Robert Kanter wrote: > > tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java > > Lines 173-174 (patched) > > > > > > LogAggregationUtils is marked @Privat

Re: Review Request 62459: OOZIE-2296: Add an Oozie diagnostic bundle tool

2017-10-15 Thread Attila Sasvari via Review Board
> On Sept. 30, 2017, 4:41 a.m., Robert Kanter wrote: > > tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java > > Lines 151 (patched) > > > > > > Should we skip control types? That's probably fine f

Re: Review Request 62459: OOZIE-2296: Add an Oozie diagnostic bundle tool

2017-10-16 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62459/ --- (Updated Oct. 16, 2017, 7:11 a.m.) Review request for oozie. Repository: oozi

Re: Review Request 62459: OOZIE-2296: Add an Oozie diagnostic bundle tool

2017-10-16 Thread Attila Sasvari via Review Board
> On Sept. 30, 2017, 4:41 a.m., Robert Kanter wrote: > > tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java > > Lines 151 (patched) > > > > > > Should we skip control types? That's probably fine f

Re: Review Request 62459: OOZIE-2296: Add an Oozie diagnostic bundle tool

2017-10-16 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62459/ --- (Updated Oct. 16, 2017, 12:32 p.m.) Review request for oozie. Repository: ooz

Re: Review Request 63837: SparkConfigrationService overwrites properties provided via --properties-file option in SparkAction

2017-11-16 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63837/#review191175 --- docs/src/site/twiki/DG_SparkActionExtension.twiki Lines 119 (patc

Review Request 63875: OOZIE-2900 Retrieve tokens for oozie.launcher.mapreduce.job.hdfs-servers before submission

2017-11-16 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63875/ --- Review request for oozie, Peter Bacsko and Robert Kanter. Repository: oozie-git

Re: Review Request 63875: OOZIE-2900 Retrieve tokens for oozie.launcher.mapreduce.job.hdfs-servers before submission

2017-11-20 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63875/ --- (Updated Nov. 20, 2017, 11:21 p.m.) Review request for oozie, Peter Bacsko and

Re: Review Request 63875: OOZIE-2900 Retrieve tokens for oozie.launcher.mapreduce.job.hdfs-servers before submission

2017-11-21 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63875/ --- (Updated Nov. 21, 2017, 3:49 p.m.) Review request for oozie, Peter Bacsko and R

Re: Review Request 63875: OOZIE-2900 Retrieve tokens for oozie.launcher.mapreduce.job.hdfs-servers before submission

2017-11-22 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63875/ --- (Updated Nov. 22, 2017, 3:11 p.m.) Review request for oozie, Peter Bacsko and R

Re: Review Request 63875: OOZIE-2900 Retrieve tokens for oozie.launcher.mapreduce.job.hdfs-servers before submission

2017-11-24 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63875/ --- (Updated Nov. 24, 2017, 10:17 a.m.) Review request for oozie, Peter Bacsko and

Re: Review Request 63875: OOZIE-2900 Retrieve tokens for oozie.launcher.mapreduce.job.hdfs-servers before submission

2017-11-24 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63875/ --- (Updated Nov. 24, 2017, 10:29 a.m.) Review request for oozie, Peter Bacsko and

Re: Review Request 64808: OOZIE-3085 - Improve logging in ActionExecutors

2017-12-22 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64808/#review194448 --- core/src/main/java/org/apache/oozie/action/control/ControlNodeAct

Re: Review Request 64808: OOZIE-3085 - Improve logging in ActionExecutors

2017-12-28 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64808/#review194570 --- core/src/main/java/org/apache/oozie/action/control/ControlNodeAct

Review Request 65286: OOZIE-2775: Oozie server does not stop if there is an exception during service initalization at startup

2018-01-23 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65286/ --- Review request for oozie and András Piros. Repository: oozie-git Description

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-23 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/#review196008 --- server/src/main/java/org/apache/oozie/server/EmbeddedOozieServer.

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-23 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/#review196011 --- Please update documentation and mention truststore related things:

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-24 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/#review196112 --- server/src/main/java/org/apache/oozie/server/EmbeddedOozieServer.

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-26 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/#review196327 --- docs/src/site/twiki/DG_QuickStart.twiki Lines 149 (patched)

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-26 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/#review196328 --- docs/src/site/twiki/DG_QuickStart.twiki Line 149 (original), 149

Re: Review Request 65287: OOZIE-3157 - Setup truststore so that it also works in HTTP only mode

2018-01-26 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65287/#review196331 --- Ship it! Ship It! - Attila Sasvari On Jan. 26, 2018, 1:16 p.

Review Request 65385: OOZIE-1717 add indices to speed up db queries

2018-01-29 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65385/ --- Review request for oozie. Repository: oozie-git Description --- Add indi

Re: Review Request 65385: OOZIE-1717 add indices to speed up db queries

2018-02-05 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65385/ --- (Updated Feb. 5, 2018, 9:52 a.m.) Review request for oozie. Repository: oozie

Re: Review Request 65385: OOZIE-1717 add indices to speed up db queries

2018-02-05 Thread Attila Sasvari via Review Board
> On Jan. 29, 2018, 3:20 p.m., András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java > > Lines 1156 (patched) > > > > > > Any ideas how to check automatically which indices have been cre

Re: Review Request 65385: OOZIE-1717 add indices to speed up db queries

2018-02-05 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65385/ --- (Updated Feb. 6, 2018, 1 a.m.) Review request for oozie. Changes --- ver

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

2018-02-07 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review196991 --- client/src/main/java/org/apache/oozie/cli/WorkflowFactoryCompiler

Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-12 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/ --- Review request for oozie. Repository: oozie-git Description --- OOZIE-26

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-12 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/ --- (Updated Feb. 12, 2018, 4:19 p.m.) Review request for oozie. Repository: oozi

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-13 Thread Attila Sasvari via Review Board
> On Feb. 12, 2018, 8:05 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 266-271 (patched) > > > > > > What happens if both `resource-manager` and `jo

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-14 Thread Attila Sasvari via Review Board
> On Feb. 14, 2018, 10:50 a.m., Peter Bacsko wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > > Lines 2349 (patched) > > > > > > Can't we accidentally skip the PREP phase? I

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-14 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/ --- (Updated Feb. 14, 2018, 11:13 a.m.) Review request for oozie. Changes ---

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66084/#review199384 --- core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrappe