[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[ https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415342#comment-16415342 ] Andras Piros commented on OOZIE-3176: - Thanks for the contribution [~alishap]! +1 > Oozie-core fails with checkstyle errors. > > > Key: OOZIE-3176 > URL: https://issues.apache.org/jira/browse/OOZIE-3176 > Project: Oozie > Issue Type: Bug > Components: core >Affects Versions: 5.0.0b1 > Environment: # uname -a > Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug > 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Alisha Prabhu >Assignee: Alisha Prabhu >Priority: Blocker > Fix For: 5.0.0 > > Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch, > OOZIE-3176-002.patch > > > There are multiple checkstyle violations in the Oozie-core module. > Maven command used is mvn clean install -DskipTests > I have attached the Checkstyle-errors.txt file, that has the errors occurred > while building. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414062#comment-16414062
]
Hadoop QA commented on OOZIE-3176:
--
Testing JIRA OOZIE-3176
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 56 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2098
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)
.Tests failing with errors:
.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestJMSAccessorService#testConnectionRetry
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/472/
> Oozie-core fails with checkstyle errors.
>
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
> Issue Type: Bug
> Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Assignee: Alisha Prabhu
>Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch,
> OOZIE-3176-002.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred
> while building.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[ https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413937#comment-16413937 ] Hadoop QA commented on OOZIE-3176: -- PreCommit-OOZIE-Build started > Oozie-core fails with checkstyle errors. > > > Key: OOZIE-3176 > URL: https://issues.apache.org/jira/browse/OOZIE-3176 > Project: Oozie > Issue Type: Bug > Components: core >Affects Versions: 5.0.0b1 > Environment: # uname -a > Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug > 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Alisha Prabhu >Assignee: Alisha Prabhu >Priority: Blocker > Fix For: 5.0.0 > > Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch, > OOZIE-3176-002.patch > > > There are multiple checkstyle violations in the Oozie-core module. > Maven command used is mvn clean install -DskipTests > I have attached the Checkstyle-errors.txt file, that has the errors occurred > while building. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[ https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413927#comment-16413927 ] Peter Cseh commented on OOZIE-3176: --- I'm attaching patch#3 from Reviewboard to kick off the pre-commit hook. https://reviews.apache.org/r/66084/diff/3#index_header > Oozie-core fails with checkstyle errors. > > > Key: OOZIE-3176 > URL: https://issues.apache.org/jira/browse/OOZIE-3176 > Project: Oozie > Issue Type: Bug > Components: core >Affects Versions: 5.0.0b1 > Environment: # uname -a > Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug > 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Alisha Prabhu >Assignee: Alisha Prabhu >Priority: Blocker > Fix For: 5.0.0 > > Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch, > OOZIE-3176-002.patch > > > There are multiple checkstyle violations in the Oozie-core module. > Maven command used is mvn clean install -DskipTests > I have attached the Checkstyle-errors.txt file, that has the errors occurred > while building. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395596#comment-16395596
]
Attila Sasvari commented on OOZIE-3176:
---
[~alishap] thanks for looking into this. Unfortunately, applying the patch
results in
[failure|https://builds.apache.org/job/PreCommit-OOZIE-Build/416/artifact/test-patch/reports/DISTRO.out]
when running {{bin/mkdistro.sh -DskipTests -Puber -DtargetJavaVersion=1.8
-DjavaVersion=1.8}} It should be definitely fixed.
Note: There is only one error in the {{core}} module that breaks checkstyle. It
would be enough to fix header in
{{core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
}}so that {{mvn clean install -DskipTests}} does not fail with error:
{code:java}
/root/ooziepipe/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java:10:
Line does not match expected header line of ' *
http://www.apache.org/licenses/LICENSE-2.0'.
{code}
I would probably only fix this. At the same time, I agree having 0 checkstyle
warning is a good thing.
Anyway, If a changeset is large (like the patch uploaded, which is over 300
KB), it is recommended to file a [ReviewBoard|https://reviews.apache.org/]
request (adding {{oozie}} to the review groups) and link it to this JIRA .
Other remarks:
- I know that [How to
contribute|https://cwiki.apache.org/confluence/display/OOZIE/How+To+Contribute]
does not describe a coding style. However, I generally prefer to break a line
before a non-assignment operator. It is also recommended by [Google's Java
style
guide|https://google.github.io/styleguide/javaguide.html#s4.5-line-wrapping]
and [Oracle's code
conventions|http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html#248]
.
So instead of
{code:java}
LiteWorkflowApp app = new LiteWorkflowApp("name", definition, new
StartNodeDef(LiteWorkflowStoreService.
LiteControlNodeHandler.class, "foo"));
{code}
use
{code:java}
LiteWorkflowApp app = new LiteWorkflowApp("name", definition, new
StartNodeDef(LiteWorkflowStoreService
.LiteControlNodeHandler.class, "foo"));
{code}
or
{code:java}
LiteWorkflowApp app = new LiteWorkflowApp("name", definition, new StartNodeDef(
LiteWorkflowStoreService.LiteControlNodeHandler.class, "foo"));
{code}
- When breaking long comments into multiple lines, I would prefer using {{/**/}}
> Oozie-core fails with checkstyle errors.
>
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
> Issue Type: Bug
> Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Assignee: Alisha Prabhu
>Priority: Minor
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred
> while building.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[ https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389240#comment-16389240 ] Alisha Prabhu commented on OOZIE-3176: -- Hi [~asasvari] , can you please review the above patch. Thank you. > Oozie-core fails with checkstyle errors. > > > Key: OOZIE-3176 > URL: https://issues.apache.org/jira/browse/OOZIE-3176 > Project: Oozie > Issue Type: Bug > Components: core >Affects Versions: 5.0.0b1 > Environment: # uname -a > Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug > 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Alisha Prabhu >Assignee: Alisha Prabhu >Priority: Minor > Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch > > > There are multiple checkstyle violations in the Oozie-core module. > Maven command used is mvn clean install -DskipTests > I have attached the Checkstyle-errors.txt file, that has the errors occurred > while building. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386027#comment-16386027
]
Hadoop QA commented on OOZIE-3176:
--
Testing JIRA OOZIE-3176
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 56 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2092
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)
.Tests failing with errors:
.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:red}-1 DISTRO{color}
.{color:red}-1{color} distro tarball fails with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/416/
> Oozie-core fails with checkstyle errors.
>
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
> Issue Type: Bug
> Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Assignee: Alisha Prabhu
>Priority: Minor
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred
> while building.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[ https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385949#comment-16385949 ] Hadoop QA commented on OOZIE-3176: -- PreCommit-OOZIE-Build started > Oozie-core fails with checkstyle errors. > > > Key: OOZIE-3176 > URL: https://issues.apache.org/jira/browse/OOZIE-3176 > Project: Oozie > Issue Type: Bug > Components: core >Affects Versions: 5.0.0b1 > Environment: # uname -a > Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug > 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Alisha Prabhu >Assignee: Alisha Prabhu >Priority: Minor > Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch > > > There are multiple checkstyle violations in the Oozie-core module. > Maven command used is mvn clean install -DskipTests > I have attached the Checkstyle-errors.txt file, that has the errors occurred > while building. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385948#comment-16385948
]
Hadoop QA commented on OOZIE-3176:
--
Testing JIRA OOZIE-3176
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 56 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2092
.Tests failed: 17
.Tests errors: 12
.The patch failed the following testcases:
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testCoordinatorActionSelectors(org.apache.oozie.jms.TestJMSJobEventListener)
testCoordinatorActionSelectorsNegative(org.apache.oozie.jms.TestJMSJobEventListener)
testWorkflowJobSelectors(org.apache.oozie.jms.TestJMSJobEventListener)
testOnCoordinatorJobSuccessEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testOnWorkflowJobSuspendEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testWorkflowJobSelectorsAnd(org.apache.oozie.jms.TestJMSJobEventListener)
testOnCoordinatorJobFailureEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testConnectionDrop(org.apache.oozie.jms.TestJMSJobEventListener)
testWorkflowJobSelectorsNegative(org.apache.oozie.jms.TestJMSJobEventListener)
testWorkflowJobSelectorsOr(org.apache.oozie.jms.TestJMSJobEventListener)
testOnWorkflowJobSuccessEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testOnCoordinatorActionWaitingEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testOnWorkflowJobFailureEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testOnCoordinatorActionStartEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testOnWorkflowJobStartedEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
.Tests failing with errors:
testOnSLADurationMetEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testOnSLAStartMetEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testSLAJobSelectorsNegative(org.apache.oozie.jms.TestJMSSLAEventListener)
testOnSLAEndMetEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testOnSLAStartMissEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testSLAJobSelectors(org.apache.oozie.jms.TestJMSSLAEventListener)
testOnSLAEndMissEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testOnSLADurationMissEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testDropEventTypeMessage(org.apache.oozie.jms.TestHCatMessageHandler)
testCacheUpdateByMessage(org.apache.oozie.jms.TestHCatMessageHandler)
testThreadLocalSession(org.apache.oozie.jms.TestDefaultConnectio
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[ https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385859#comment-16385859 ] Hadoop QA commented on OOZIE-3176: -- PreCommit-OOZIE-Build started > Oozie-core fails with checkstyle errors. > > > Key: OOZIE-3176 > URL: https://issues.apache.org/jira/browse/OOZIE-3176 > Project: Oozie > Issue Type: Bug > Components: core >Affects Versions: 5.0.0b1 > Environment: # uname -a > Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug > 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Alisha Prabhu >Assignee: Alisha Prabhu >Priority: Minor > Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch > > > There are multiple checkstyle violations in the Oozie-core module. > Maven command used is mvn clean install -DskipTests > I have attached the Checkstyle-errors.txt file, that has the errors occurred > while building. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360450#comment-16360450
]
Hadoop QA commented on OOZIE-3176:
--
Testing JIRA OOZIE-3176
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 56 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2092
.Tests failed: 3
.Tests errors: 1
.The patch failed the following testcases:
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)
.Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)
.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:red}-1 DISTRO{color}
.{color:red}-1{color} distro tarball fails with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/385/
> Oozie-core fails with checkstyle errors.
>
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
> Issue Type: Bug
> Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Assignee: Alisha Prabhu
>Priority: Minor
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred
> while building.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[ https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360376#comment-16360376 ] Hadoop QA commented on OOZIE-3176: -- PreCommit-OOZIE-Build started > Oozie-core fails with checkstyle errors. > > > Key: OOZIE-3176 > URL: https://issues.apache.org/jira/browse/OOZIE-3176 > Project: Oozie > Issue Type: Bug > Components: core >Affects Versions: 5.0.0b1 > Environment: # uname -a > Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug > 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Alisha Prabhu >Assignee: Alisha Prabhu >Priority: Minor > Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch > > > There are multiple checkstyle violations in the Oozie-core module. > Maven command used is mvn clean install -DskipTests > I have attached the Checkstyle-errors.txt file, that has the errors occurred > while building. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3176) Oozie-core fails with checkstyle errors.
[
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355416#comment-16355416
]
Attila Sasvari commented on OOZIE-3176:
---
[~alishap] many thanks for filing this JIRA, I added you to contributors and
assigned the ticket too you.
I can confirm {{mvn clean install -DskipTests
-Dmaven.javadoc.opts="-Xdoclint:none"}} fails on master because of a checkstyle
error, {{core/target/checkstyle-result.xml}} shows:
{code}
http://www.apache.org/licenses/LICENSE-2.0'.";
source="com.puppycrawl.tool
s.checkstyle.checks.header.HeaderCheck"/>
{code}
WorkflowJobsBasicInfoFromParentId was introduced by OOZIE-1401.amend.003.patch.
On that day, the Oozie PreCommit build failed to add comment (JIRA was
updated).
> Oozie-core fails with checkstyle errors.
>
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
> Issue Type: Bug
> Components: core
>Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Alisha Prabhu
>Priority: Minor
> Attachments: Checkstyle-erros.txt
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred
> while building.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
