Re: [openoffice] branch AOO41X updated: Add support for Azul JDK's
Hi Arrigo, Am 13.02.22 um 18:43 schrieb Arrigo Marchiori: > Hello Matthias, > > On Sun, Feb 13, 2022 at 05:43:25PM +0100, Matthias Seidel wrote: > >> Hi Arrigo, >> >> Am 13.02.22 um 17:22 schrieb Arrigo Marchiori: >>> Hello Matthias, All, >>> >>> On Fri, Feb 11, 2022 at 08:15:32PM +0100, Matthias Seidel wrote: >>> Hi Arrigo, Same here: Would this also be wanted in trunk and AOO42X? >>> I think so. This commit had to be adjusted because AOO42X and trunk do >>> not seem to support Java 1.7, whereas AOO41X did. >>> >>> I merged the other one about the `tmp' folder. >>> >>> Thank you for pointing this out! My bad; I should not work on trunk >>> directly... >> No problem, I just want to have the branches in sync as much as possible. > Sure! > > [...] > >> The fix for "Azul" is just for building? >> >> I ask, because on Windows the Azul JDK is already detected. But it is >> listed as "OpenJDK" like the one from Adoptium. Maybe we can make that >> list a bit more clear? > The commit changes the logic that selects whether "mac.java.path" > shall be set to "mac.oracle.java.path" or "mac.apple.java.path". > > Apparently, there are two ``families'' of JDK's under macOS, and each > family keeps its base classes in a different path. > > This edit only affects building under macOS. > > Do you suggest that an explanation like the above shall be integrated > into the file as a comment? No, I just noticed that JDKs based on OpenJDK are all listed as "OpenJDK" in the AOO settings. Hard to distinguish. But that is a minor issue... Regards, Matthias > > Best regards, smime.p7s Description: S/MIME Cryptographic Signature
Re: [openoffice] branch AOO41X updated: Add support for Azul JDK's
Hello Matthias, On Sun, Feb 13, 2022 at 05:43:25PM +0100, Matthias Seidel wrote: > Hi Arrigo, > > Am 13.02.22 um 17:22 schrieb Arrigo Marchiori: > > Hello Matthias, All, > > > > On Fri, Feb 11, 2022 at 08:15:32PM +0100, Matthias Seidel wrote: > > > >> Hi Arrigo, > >> > >> Same here: Would this also be wanted in trunk and AOO42X? > > I think so. This commit had to be adjusted because AOO42X and trunk do > > not seem to support Java 1.7, whereas AOO41X did. > > > > I merged the other one about the `tmp' folder. > > > > Thank you for pointing this out! My bad; I should not work on trunk > > directly... > > No problem, I just want to have the branches in sync as much as possible. Sure! [...] > The fix for "Azul" is just for building? > > I ask, because on Windows the Azul JDK is already detected. But it is > listed as "OpenJDK" like the one from Adoptium. Maybe we can make that > list a bit more clear? The commit changes the logic that selects whether "mac.java.path" shall be set to "mac.oracle.java.path" or "mac.apple.java.path". Apparently, there are two ``families'' of JDK's under macOS, and each family keeps its base classes in a different path. This edit only affects building under macOS. Do you suggest that an explanation like the above shall be integrated into the file as a comment? Best regards, -- Arrigo - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [openoffice] branch AOO41X updated: Add support for Azul JDK's
Hi Arrigo, Am 13.02.22 um 17:22 schrieb Arrigo Marchiori: > Hello Matthias, All, > > On Fri, Feb 11, 2022 at 08:15:32PM +0100, Matthias Seidel wrote: > >> Hi Arrigo, >> >> Same here: Would this also be wanted in trunk and AOO42X? > I think so. This commit had to be adjusted because AOO42X and trunk do > not seem to support Java 1.7, whereas AOO41X did. > > I merged the other one about the `tmp' folder. > > Thank you for pointing this out! My bad; I should not work on trunk > directly... No problem, I just want to have the branches in sync as much as possible. We once had a Bugzilla issue for AOO42X that was fixed long ago on trunk but was not backported. Took me some time to realize that. The fix for "Azul" is just for building? I ask, because on Windows the Azul JDK is already detected. But it is listed as "OpenJDK" like the one from Adoptium. Maybe we can make that list a bit more clear? Regards, Matthias > > Best regards, smime.p7s Description: S/MIME Cryptographic Signature
Re: [openoffice] branch AOO41X updated: Add support for Azul JDK's
Hello Matthias, All, On Fri, Feb 11, 2022 at 08:15:32PM +0100, Matthias Seidel wrote: > Hi Arrigo, > > Same here: Would this also be wanted in trunk and AOO42X? I think so. This commit had to be adjusted because AOO42X and trunk do not seem to support Java 1.7, whereas AOO41X did. I merged the other one about the `tmp' folder. Thank you for pointing this out! My bad; I should not work on trunk directly... Best regards, -- Arrigo - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [openoffice] branch AOO41X updated: Add support for Azul JDK's
Hi Arrigo, Same here: Would this also be wanted in trunk and AOO42X? Regards, Matthias Am 11.02.22 um 09:47 schrieb ard...@apache.org: > This is an automated email from the ASF dual-hosted git repository. > > ardovm pushed a commit to branch AOO41X > in repository https://gitbox.apache.org/repos/asf/openoffice.git > > > The following commit(s) were added to refs/heads/AOO41X by this push: > new 5a5de59 Add support for Azul JDK's > 5a5de59 is described below > > commit 5a5de594da9b5e283ddf91696613752c382591ca > Author: Arrigo Marchiori > AuthorDate: Fri Feb 11 09:45:16 2022 +0100 > > Add support for Azul JDK's > --- > main/scripting/java/build.xml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/main/scripting/java/build.xml b/main/scripting/java/build.xml > index 176db83..017913d 100644 > --- a/main/scripting/java/build.xml > +++ b/main/scripting/java/build.xml > @@ -97,6 +97,7 @@ > > casesensitive="false" /> > casesensitive="false" /> > + casesensitive="false" /> > > > smime.p7s Description: S/MIME Cryptographic Signature
