[ovs-dev] [PATCH] vtep/ovs-vtep: support multiple ovs-vtep processes which using the isolated logical switch

signed-off-by: nickcooper-zhangtong...@opencloud.tech The computer can run multiple ovs-vtep processes, but ovs-vtep processes share the “vtep_lsX” bridge when binding the physical-switch and logical-switch. The bridge created by logical-switch sh

[ovs-dev] [PATCH] vtep/ovs-vtep: support multiple ovs-vtep processes which using the isolated logical-switch

Hi all, The computer can run multiple ovs-vtep processes, but ovs-vtep processes share the “vtep_lsX” bridge when binding the physical-switch and logical-switch. The bridge created by logical-switch should be named according to logical-switch. signed-off-by: nickcooper-zhangtonghao

Re: [ovs-dev] [PATCH] vtep/ovs-vtep: support multiple ovs-vtep processes which using the isolated logical-switch

Hi , I have changed the commit message in my github repository. Thank Darrell Ball for your OVN gateway testing. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] vtep/ovs-vtep: support multiple ovs-vtep processes

. Darrell Ball did an initial test using the OVN gateway test case and did not see any issues with the proposed diff. I have submited a pull request. https://github.com/openvswitch/ovs/pull/126 <https://github.com/openvswitch/ovs/pull/126> Thanks， nickcooper-zhangtonghao. > On May 18, 2016,

[ovs-dev] [PATCH 2/4] ovn: ovn-northd, the implementation of icmp4 reject actions

ovn: the implementation of icmp4 reject actions. ACLs support the "icmp-reject" actions. Adds a row with the icmp4-reject contents to the Logical_Flow table. Signed-off-by: nickcooper-zhangtonghao diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 6712d21..7867

[ovs-dev] [PATCH 1/4] ovn: ovn-nbctl, the implementation of icmp4 reject actions

to support only “from-lport” direction. Signed-off-by: nickcooper-zhangtonghao diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 25916da..55cc1da 100644 --- a/ovn/utilities/ovn-nbctl.c +++ b/ovn/utilities/ovn-nbctl.c @@ -302,7 +302,7 @@ Logical switch commands

[ovs-dev] [PATCH 4/4] ovn: ovn-contrller, the implementation of icmp4 reject actions

ovn: the implementation of icmp4 reject actions. Update the ovn manpage and ovn-nb.ovsschema for icmp4 reject actions. Signed-off-by: nickcooper-zhangtonghao diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema index 460d5bd..9842664 100644 --- a/ovn/ovn-nb.ovsschema +++ b/ovn/ovn

[ovs-dev] [PATCH 3/4] ovn: ovn-contrller, the implementation of icmp4 reject actions

ovn: the implementation of icmp4 reject actions. The ovn-contoller will process the packet-in data packet and compose an ICMP4 packet， whose icmp4 data contains the IP header and first 8 bytes of original datagram's data. Signed-off-by: nickcooper-zhangtonghao diff --git a/lib/packet

[ovs-dev] [PATCH v2] ovn: the implementation of icmp4 reject actions.

-unreachable is default. The "TCP RST" function will be completed soon. Reject action support only "from-lport" direction. In general, considering performance requirements, it might make sense to support only "from-lport" direction. Signed-off-by: nickcooper-zhan

[ovs-dev] [PATCH] ovn: will not create patch port whose peer named "".

-system: failed to query port patch-lr0-p0-to-: Invalid argument ovn: will not create patch port whose peer named “”. It is not necessary to create the logical patch port whose peer named "". Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/patch.c | 4 tutorial/ovs-san

[ovs-dev] [PATCH] ovn: remove the dead code.

It is not necessary to assign 0 to ip_csum. Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/pinctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ovn/controller/pinctrl.c b/ovn/controller/pinctrl.c index 7893872..b35576a 100644 --- a/ovn/controller/pinctrl.c +++ b/ovn

[ovs-dev] [PATCH] ovn: will not create patch port whose peer named "".

ovn: will not create patch port whose peer named "". It is not necessary to create the logical patch port whose peer named "". Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/patch.c | 4 1 file changed, 4 insertions(+) diff --git a/ovn/controller/patch.c

[ovs-dev] [PATCH] ovn: ovn-northd and von-controller take a high amount of CPU time.

ovn-northd write quickly the log and take a high amount of CPU time. Signed-off-by: nickcooper-zhangtonghao --- ovn/northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 78679b1..4e83ad1 100644 --- a/ovn

Re: [ovs-dev] [PATCH 1/3] ovn-northd: Only peer router ports to other router ports.

* Logical_Router_Port's 'peer' column. */ >> +static struct vlog_rate_limit rl = >> +VLOG_RATE_LIMIT_INIT(5, 1); >> +VLOG_WARN_RL(&rl, "Bad configuration: The peer of >> router " >> + "port %s is a switch port", op->key); >> +} >> +} >> } >> } >> } >> -- >> 2.1.3 >> >> This patch that fix the bug is more better than which I provide. Thank you for your tips, Gurucharan. Acked-by: nickcooper-zhangtonghao ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovn: remove unnecessary conditional statements.

It is unnecessary to check ‘chassis_id’ again. Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/ovn-controller.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index dcab918..4d9490a

[ovs-dev] [PATCH] ovn: don't create the "" patch port.

It is not necessary to create the logical patch port whose peer named "". Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/patch.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ovn/controller/patch.c b/ovn/controller/patch.c index 707d08b..7e3ae39 10

Re: [ovs-dev] [PATCH] ovn: remove the dead code.

I apologize for this mistake. > On Jul 25, 2016, at 2:40 AM, Ryan Moats wrote: > > Ben Pfaff wrote on 07/24/2016 12:56:29 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: Numan Siddique , ovs dev > > , nickcooper-zhangtonghao > zh

[ovs-dev] [PATCH] ovn-northd: Only peer router ports to other router ports.

75524.html Signed-off-by: Ben Pfaff Acked-by: Gurucharan Shetty Signed-off-by: nickcooper-zhangtonghao --- ovn/northd/ovn-northd.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index a3d1672..efc915c 100644 --- a/ovn/n

[ovs-dev] [PATCH] ovn-northd: create patch ports when necessary.

ll not be inserted. This patch may optimize the process of 'build_ports'. Signed-off-by: nickcooper-zhangtonghao --- ovn/northd/ovn-northd.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-nor

Re: [ovs-dev] [PATCH] ovn: don't create the "" patch port.

ntain 'router-port' value, these ports will not be inserted. This patch may optimize the process of 'build_ports'. Signed-off-by: nickcooper-zhangtonghao --- ovn/northd/ovn-northd.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --g

Re: [ovs-dev] [PATCH] ovsdb: Fix memory leak in execute_update.

Hi William, I reviewed your patch codes and found other bugs. If the ‘ovsdb_condition_from_json’ return the error, cnd->clauses will be set NULL, so ‘ovsdb_condition_destroy’ should check the 'cnd->clauses’ before free it. It is applied to ‘ovsdb_row_from_json’. Signed-off-by:

Re: [ovs-dev] [PATCH] ovn-northd: Only peer router ports to other router ports.

> On Jul 28, 2016, at 5:01 AM, Ben Pfaff wrote: > > On Mon, Jul 25, 2016 at 09:19:00AM -0700, nickcooper-zhangtonghao wrote: >> Deletion of a logical router port, which may be an other >> router peer, result in a WARN, because the "ports" variable >> st

Re: [ovs-dev] [PATCH] ovsdb: Fix memory leak in execute_update.

gt; > On Tue, Jul 26, 2016 at 9:18 PM, nickcooper-zhangtonghao > wrote: >> Hi William, >> I reviewed your patch codes and found other bugs. >> >> If the ‘ovsdb_condition_from_json’ return the error, cnd->clauses will be >> set NULL, so ‘ovsdb_condition_destro

Re: [ovs-dev] [PATCH] ovn-northd: create patch ports when necessary.

> On Jul 28, 2016, at 5:03 AM, Ben Pfaff wrote: > > On Mon, Jul 25, 2016 at 09:23:19AM -0700, nickcooper-zhangtonghao wrote: >> If the logical router ports without 'peer' or the port named peer >> is not created, it is unnecessary to insert the ports into the &

Re: [ovs-dev] [PATCH] ovn-northd: create patch ports when necessary.

I only consider the OVN without CMS. Your tips may sound great. > On Jul 29, 2016, at 10:48 AM, Ryan Moats wrote: > > "dev" wrote on 07/27/2016 09:47:47 PM: > > > From: nickcooper-zhangtonghao > > To: Ben Pfaff > > Cc: dev@openvswitch.org > > D

[ovs-dev] [PATCH] ovn-controller: if 'ovn-bridge-mappings' unconfigured, return directly.

If the chassis doesn't configure the 'external-ids:ovn-bridge-mappings' in the OVSDB, the 'add_bridge_mappings' should return directly. Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/patch.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH] ovn-controller: if 'ovn-bridge-mappings' unconfigured, return directly.

> On Aug 2, 2016, at 12:09 AM, Russell Bryant wrote: > > > > On Mon, Aug 1, 2016 at 12:00 PM, Ben Pfaff <mailto:b...@ovn.org>> wrote: > On Mon, Aug 01, 2016 at 02:55:26AM -0700, nickcooper-zhangtonghao wrote: > > If the chassis doesn't configure the

[ovs-dev] [PATCH] ovn-controller:improve the ofctrl_run, pinctrl_run

Before calling the function "ofctrl_run" and "pinctrl_run", the "br-int"" has been checked. Remove the conditional statements in the function may make the code clearer. Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/ofctrl.c | 15 +--

[ovs-dev] [PATCH] ovn-controller: Combine two Logical_Flow loops into one.

Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/lflow.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c index fda10eb..0cc92a7 100644 --- a/ovn/controller/lflow.c +++ b/ovn/controller/lflow.c @@ -412,18

[ovs-dev] [PATCH] ovn-controller: Remove the repeated code.

Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/lflow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c index fda10eb..e22923b 100644 --- a/ovn/controller/lflow.c +++ b/ovn/controller/lflow.c @@ -595,7 +595,6 @@ consider_logical_flow

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Fix potential crash with timeout argument

> On Aug 8, 2016, at 3:45 PM, dev-requ...@openvswitch.org wrote: > > Date: Sun, 7 Aug 2016 22:06:05 +0100 > From: Bhanuprakash Bodireddy > > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 2/2] ovs-appctl: Fix potential c

Re: [ovs-dev] [PATCH v2 21/21] ovn-trace: New utility.

> On Aug 9, 2016, at 12:15 AM, dev-requ...@openvswitch.org wrote: > > Date: Mon, 8 Aug 2016 09:14:32 -0700 > From: Ben Pfaff mailto:b...@ovn.org>> > To: dev@openvswitch.org > Cc: Ben Pfaff mailto:b...@ovn.org>> > Subject: [ovs-dev] [PATCH v2 21/21] ovn-trace: New uti

Re: [ovs-dev] [PATCH] ovn-controller: Combine two Logical_Flow loops into one.

> On Aug 7, 2016, at 6:54 AM, Ryan Moats wrote: > > > From: nickcooper-zhangtonghao > <mailto:nickcooper-zhangtong...@opencloud.tech>> > > To: dev@openvswitch.org <mailto:dev@openvswitch.org> > > Cc: nickcooper-zhangtonghao > <mailto:nickcoop

Re: [ovs-dev] [PATCH] ovn-controller:improve the ofctrl_run, pinctrl_run

> On Aug 7, 2016, at 5:44 AM, Ryan Moats wrote: > > "dev" wrote on 08/04/2016 06:50:03 AM: > > > From: nickcooper-zhangtonghao > > To: dev@openvswitch.org > > Cc: nickcooper-zhangtonghao > > Date: 08/04/2016 06:50 AM > > Subject: [ov

Re: [ovs-dev] [PATCH] ovn-controller: Remove the repeated code.

> On Aug 7, 2016, at 7:22 AM, Ryan Moats wrote: > > > From: nickcooper-zhangtonghao > <mailto:nickcooper-zhangtong...@opencloud.tech>> > > To: dev@openvswitch.org <mailto:dev@openvswitch.org> > > Cc: nickcooper-zhangtonghao > <mailto:nickcoop

[ovs-dev] The name of logical switch and router is null

Hi all, When I create one or more logical router named ’null', using 'ovn-nbctl lr-add’, there is no error information. This is arguably an ovn-nbctl bug. # ovn-nbctl lr-add # ovn-nbctl lr-list 3aeff07a-cd16-45f3-ac5a-e4da634b81f6 () # ovn-nbctl lr-add

[ovs-dev] [ovn-dev] ovn-nbctl: Improvement to the ovn-nbctl manpage

name. Signed-off-by: nickcooper-zhangtonghao diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index c2ca420..b4b8501 100644 --- a/ovn/utilities/ovn-nbctl.8.xml +++ b/ovn/utilities/ovn-nbctl.8.xml @@ -50,7 +50,9 @@ --may-exist, adding a duplicate name succeeds

[ovs-dev] [PATCH] ovn: ARP reply security vulnerability.

when logical routers send an ARP request packet, and get a corresponding ARP reply, will the 'ovn-controller' update MAC_Binding table of SB database. Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/pinctrl.c | 152 ++-

[ovs-dev] [PATCH v2] ovn: ARP reply security vulnerability.

when logical routers send an ARP request packet, and get a corresponding ARP reply, will the 'ovn-controller' update MAC_Binding table of SB database. Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/pinctrl.c | 152 ++- o

[ovs-dev] [PATCH] ovn: ND security vulnerability.

ns, and get a corresponding neighbor advertisements, will the 'ovn-controller' update MAC_Binding table of SB database. Signed-off-by: nickcooper-zhangtonghao --- include/ovn/actions.h| 7 + ovn/controller/pinctrl.c | 81 +++

[ovs-dev] [PATCH v2 0/2] ovn: ARP reply security vulnerability.

when logical routers send an ARP request packet, and get a corresponding ARP reply, will the 'ovn-controller' update MAC_Binding table of SB database. Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/pinctrl.c | 152 ++- o

[ovs-dev] [PATCH v2 2/2] ovn: add "timeout" column in MAC_Binding

Add "timeout" column in MAC_Binding to support cache aging. The ARP/NA cache expiring will be removed and logical router send ARP/NS to get IP-MAC binding. Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/pinctrl.c | 25 ++--- ovn/ovn-sb.ovsschema |

[ovs-dev] [PATCH v2 1/2] ovn: ND security vulnerability.

ns, and get a corresponding neighbor advertisements, will the 'ovn-controller' update MAC_Binding table of SB database. Signed-off-by: nickcooper-zhangtonghao --- include/ovn/actions.h| 7 + ovn/controller/pinctrl.c | 81 +++

[ovs-dev] [PATCH 0/3] ovn: Make the ARP/ND more secure.

HABLE_TIME seconds, send a Neighbor Solicitation and change the state to PROBE. * According to Section 4.6 in RFC 5944, we should update the MAC address of existing entries in the case of gratuitous ARP. nickcooper-zhangtonghao (3): ovn: Don't learn from unrequested ARP replies. ovn: Don&

[ovs-dev] [PATCH 2/3] ovn: Don't learn from ND packets.

ashes. This patches may fix this bug. Signed-off-by: nickcooper-zhangtonghao --- include/ovn/actions.h | 7 ovn/controller/pinctrl.c | 99 +++ ovn/lib/actions.c | 29 +- ovn/northd/ovn-northd.c | 49 ---

[ovs-dev] [PATCH 1/3] ovn: Don't learn from unrequested ARP replies.

change the state to PROBE. * According to Section 4.6 in RFC 5944, we should update the MAC address of existing entries in the case of gratuitous ARP. Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/ovn-controller.c | 2 +- ovn/controller/pinctrl.c| 271 +

[ovs-dev] [PATCH 3/3] ovn: update manpage, ovn-sb.xml

Signed-off-by: nickcooper-zhangtonghao --- ovn/ovn-sb.xml | 39 +++ 1 file changed, 39 insertions(+) diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index e119249..b6f022d 100644 --- a/ovn/ovn-sb.xml +++ b/ovn/ovn-sb.xml @@ -1207,6 +1207,45

[ovs-dev] Load balancer creating method.

Hi all, Can we create the “lb" from the “ovn-nbctl” command line? manipulate directly the database? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Load balancer creating method.

Thanks for your tips. Why not provide the command line to create “lb”, such as “ovn-nbctl add-lb SWITCH other-aguments” ? > On Aug 26, 2016, at 12:24 PM, Guru Shetty wrote: > > > Examples are in tests/system-ovn.at <http://system-ovn.at/> > >> On Aug 25, 2

[ovs-dev] [PATCH 1/3] ovn-nbctl: Add LB commands.

Signed-off-by: nickcooper-zhangtonghao --- ovn/ovn-nb.ovsschema | 5 +- ovn/ovn-nb.xml| 6 ++ ovn/utilities/ovn-nbctl.c | 163 +- 3 files changed, 171 insertions(+), 3 deletions(-) diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn

[ovs-dev] [PATCH 0/3] Add LB commands.

This patches provide the command line to create load-balancer and add the unit tests. nickcooper-zhangtonghao (3): vn-nbctl: Add LB commands. tests: Add LB commands unit tests. ovn-nbctl: Update manpage. ovn/ovn-nb.ovsschema | 5 +- ovn/ovn-nb.xml| 6 ++ ovn

[ovs-dev] [PATCH 3/3] ovn-nbctl: Update manpage.

Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 35 +++ 1 file changed, 35 insertions(+) diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index d44f039..fa908b7 100644 --- a/ovn/utilities/ovn-nbctl.8.xml +++ b

Re: [ovs-dev] [PATCH 0/3] Add LB commands.

Thanks for your review, I will submit the v2 patches soon. > On Aug 30, 2016, at 1:14 AM, Guru Shetty wrote: > > > On 28 August 2016 at 02:05, nickcooper-zhangtonghao > <mailto:nickcooper-zhangtong...@opencloud.tech>> wrote: > This patches provide the command line

[ovs-dev] [PATCH v2] ovn-nbctl: Add LB commands.

tests. Signed-off-by: nickcooper-zhangtonghao --- ovn/ovn-nb.ovsschema | 5 +- ovn/ovn-nb.xml| 6 ++ ovn/utilities/ovn-nbctl.8.xml | 35 + ovn/utilities/ovn-nbctl.c | 163 +- tests/ovn-nbctl.at| 44

Re: [ovs-dev] [PATCH 3/3] ovn-nbctl: Update manpage.

Thanks for your tips. I have merged the 3 patches into one. You can review it. http://patchwork.ozlabs.org/patch/663981/ <http://patchwork.ozlabs.org/patch/663981/> > On Aug 31, 2016, at 6:06 AM, Ben Pfaff wrote: > > On Sun, Aug 28, 2016 at 02:05:18AM -0700, nickcooper-zha

Re: [ovs-dev] [PATCH v2] ovn-nbctl: Add LB commands.

Sorry for missing one of your points in the previous review. I will submit v3 patch to support that function. > On Aug 31, 2016, at 11:11 PM, Guru Shetty wrote: > > On 29 August 2016 at 20:12, nickcooper-zhangtonghao > <mailto:nickcooper-zhangtong...@opencloud.tech>>

[ovs-dev] [PATCH v3] ovn-nbctl: Add LB commands.

special meaning or purpose other than to provide convenience for human interaction with the ovn-nb database. This patch also provides the unit tests. Signed-off-by: nickcooper-zhangtonghao --- ovn/ovn-nb.ovsschema | 3 +- ovn/ovn-nb.xml| 6 + ovn/utilities/ovn-nbctl.8.xml

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Add LB commands.

> On Sep 1, 2016, at 11:04 PM, Guru Shetty wrote: > > +AT_SETUP([ovn-nbctl - LBs]) > +OVN_NBCTL_TEST_START > + > +dnl Add two LBs > +AT_CHECK([ovn-nbctl lb-add lb0 30.0.0.10:80 > 192.168.10.10:80 ,192.168.10.20:80 > ]) > +AT_CHE

[ovs-dev] [PATCH v4] ovn-nbctl: Add LB commands.

with a duplicate name. This name has no special meaning or purpose other than to provide convenience for human interaction with the ovn-nb database. This patch also provides the unit tests and the documentation. Signed-off-by: nickcooper-zhangtonghao --- ovn/ovn-nb.ovsschema | 3

[ovs-dev] [PATCH v5] ovn-nbctl: Add LB commands.

load balancer with a duplicate name. This name has no special meaning or purpose other than to provide convenience for human interaction with the ovn-nb database. This patch also provides the unit tests and the documentation. Signed-off-by: nickcooper-zhangtonghao --- ovn/ovn-nb.ovsschema

Re: [ovs-dev] [PATCH v4] ovn-nbctl: Add LB commands.

Yes, I have submitted the v5 patch which support for gateway router. Thank you so much for your reviews. > On Sep 10, 2016, at 5:54 AM, Guru Shetty wrote: > > On 1 September 2016 at 23:47, nickcooper-zhangtonghao > <mailto:nickcooper-zhangtong...@opencloud.tech>> wrote:

[ovs-dev] [PATCH v6] ovn-nbctl: Add LB commands.

load balancer with a duplicate name. This name has no special meaning or purpose other than to provide convenience for human interaction with the ovn-nb database. This patch also provides the unit tests and the documentation. Signed-off-by: nickcooper-zhangtonghao --- ovn/ovn-nb.ovsschema

Re: [ovs-dev] [PATCH v6] ovn-nbctl: Add LB commands.

> On Sep 19, 2016, at 10:40 PM, Guru Shetty wrote: > > On 19 September 2016 at 05:16, nickcooper-zhangtonghao > <mailto:nickcooper-zhangtong...@opencloud.tech>> wrote: > This patch provides the command line to create a load balancer. > You can create a load balanc

[ovs-dev] [PATCH v7] ovn-nbctl: Add LB commands.

load balancer with a duplicate name. This name has no special meaning or purpose other than to provide convenience for human interaction with the ovn-nb database. This patch also provides the unit tests and the documentation. Signed-off-by: nickcooper-zhangtonghao --- ovn/ovn-nb.ovsschema

Re: [ovs-dev] [PATCH v7] ovn-nbctl: Add LB commands.

> On Sep 20, 2016, at 4:22 AM, Guru Shetty wrote: > > > On 19 September 2016 at 09:38, nickcooper-zhangtonghao > <mailto:nickcooper-zhangtong...@opencloud.tech>> wrote: > This patch provides the command line to create a load balancer. > You can create a load bal

[ovs-dev] [PATCH v8] ovn-nbctl: Add LB commands.

load balancer with a duplicate name. This name has no special meaning or purpose other than to provide convenience for human interaction with the ovn-nb database. This patch also provides the unit tests and the documentation. Signed-off-by: nickcooper-zhangtonghao --- lib/packets.c

[ovs-dev] [PATCH v9] ovn-nbctl: Add LB commands.

load balancer with a duplicate name. This name has no special meaning or purpose other than to provide convenience for human interaction with the ovn-nb database. This patch also provides the unit tests and the documentation. Signed-off-by: nickcooper-zhangtonghao --- lib/packets.c

Re: [ovs-dev] [PATCH v9] ovn-nbctl: Add LB commands.

Thanks for your tips, I fixed the memory leak(via free(ips)). The patch follows the style of the original code. So the 'const' is not used with 'may_exist', 'add_duplicate' and 'must_exist'. You can find that in files, such as 'utilities/ovs-vsctl.c', 'ovn/utilities/ovn-sbctl.c' and 'ovn/utiliti

[ovs-dev] [PATCH v10] ovn-nbctl: Add LB commands.

load balancer with a duplicate name. This name has no special meaning or purpose other than to provide convenience for human interaction with the ovn-nb database. This patch also provides the unit tests and the documentation. Signed-off-by: nickcooper-zhangtonghao --- lib/packets.c

[ovs-dev] ovn-nbctl: Add LB commands.

I have submitted the v10 patch, which can parse the ips (e.g. ",,,192.168.10.1,,,” “,,,192.168.10.1,,,192.168.10.2,,,192.168.10.3,,,”). This patch fixes the memory leak. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/de

[ovs-dev] [PATCH 2/2] Fix memory leak in nbctl_lrp_add.

Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 563c6ec..71cffda 100644 --- a/ovn/utilities/ovn-nbctl.c +++ b/ovn/utilities/ovn-nbctl.c @@ -1810,6 +1810,8

[ovs-dev] [PATCH 1/2] ovn-nbctl: check the length of MAC address

The command "ovn-nbctl lrp-add" should not set the MAC address which length is invalid to logical router port. This patch also updates the ovn-nbctl tests. Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.c | 7 ++- tests/ovn-nbctl.at| 7 +++ 2 fil

[ovs-dev] [PATCH 2/3] Fix memory leak in nbctl_lr_route_add.

Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.c | 11 ++- tests/ovn-nbctl.at| 16 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 7de8057..179c9eb 100644 --- a/ovn

[ovs-dev] [PATCH 1/3] remove unreachable code.

Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 71cffda..7de8057 100644 --- a/ovn/utilities/ovn-nbctl.c +++ b/ovn/utilities/ovn-nbctl.c @@ -1113,7 +1113,6

[ovs-dev] [PATCH 3/3] Fix memory leak in nbctl_lr_route_del.

Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 179c9eb..3f31047 100644 --- a/ovn/utilities/ovn-nbctl.c +++ b/ovn/utilities/ovn-nbctl.c

[ovs-dev] [PATCH 4/4] ovn-nbctl: Improve ovn-nbctl manpage

Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index 7cd515f..70798dc 100644 --- a/ovn/utilities/ovn-nbctl.8.xml +++ b/ovn

[ovs-dev] [PATCH 2/4] ovn-nbctl: Check the length of MAC address

cal port, instead of eth_addr_from_string(). This patch also updates the ovn-nbctl tests. Signed-off-by: nickcooper-zhangtonghao --- lib/packets.c | 15 +-- ovn/northd/ovn-northd.c | 11 +++ ovn/utilities/ovn-nbctl.c | 2 +- tests/ovn-nbctl.at| 7 +++ 4 files changed,

[ovs-dev] [PATCH 1/4] ovn: make ipam tests more reliable

Fixes: 8639f9be("ovn-northd, tests: Adding IPAM to ovn-northd.") The IPAM tests began to fail occasionally. Adding --wait=sb to commands triggering address allocation eliminated these failures. Signed-off-by: nickcooper-zhangtonghao --- tests/ovn.at | 16 1 file

[ovs-dev] [PATCH 3/4] ovn-nbctl: Fix memory leak in nbctl_lr_route_add

Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.c | 6 ++ tests/ovn-nbctl.at| 16 2 files changed, 22 insertions(+) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 453ff72..572370f 100644 --- a/ovn/utilities/ovn-nbctl.c

Re: [ovs-dev] [PATCH v10] ovn-nbctl: Add LB commands.

Thanks very much. > On Oct 4, 2016, at 5:12 AM, Guru Shetty wrote: > > I applied the patch. For future, when you version, please have some sort of > versioning information that tells the difference between the versions below > the "---" line. ___ de

Re: [ovs-dev] [PATCH 1/4] ovn: make ipam tests more reliable

Good idea. I have submitted v2 patch. > On Oct 6, 2016, at 8:30 AM, Ben Pfaff wrote: > > Thanks for working on this. > > When there are multiple ovn-nbctl calls in a row, it's ordinarily only > necessary to add --wait to the last call. Can you make that change?

Re: [ovs-dev] [PATCH 1/4] ovn: make ipam tests more reliable

Yes, I submitted the v2 patch. I can not see also it in http://patchwork.ozlabs.org/project/openvswitch/list/ There may an error in patchwork. I will send directly the patch to you. > On Oct 6, 2016, at 11:34 PM, Ben Pfaff wrote: > > Are

Re: [ovs-dev] [PATCH v10] ovn-nbctl: Add LB commands.

Good idea. I am interested in that. The patch will be submitted. Thanks. > On Oct 8, 2016, at 2:09 AM, Guru Shetty wrote: > > On 5 October 2016 at 04:25, nickcooper-zhangtonghao > <mailto:nickcooper-zhangtong...@opencloud.tech>> wrote: > Thanks very much. > > If

[ovs-dev] [PATCH 2/2] ovn-nbctl: Fix manpage formatting typo.

Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index be802da..993e1c4 100644 --- a/ovn/utilities/ovn-nbctl.8.xml +++ b/ovn/utilities/ovn

[ovs-dev] [PATCH 1/2] ovn-nbctl: Add NAT commands.

This patch provides the command line to create NAT rules on logical router. Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 66 +++ ovn/utilities/ovn-nbctl.c | 185 ++ tests/ovn-nbctl.at| 114

[ovs-dev] [PATCH 3/4] ovn-nbctl: Fix manpage formatting typo.

Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index be802da..993e1c4 100644 --- a/ovn/utilities/ovn-nbctl.8.xml +++ b/ovn/utilities/ovn

[ovs-dev] [PATCH 2/4] ovn-nbctl: Add NAT commands.

This patch provides the command line to create NAT rules on logical router. Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 66 ++ ovn/utilities/ovn-nbctl.c | 203 ++ tests/ovn-nbctl.at| 130

[ovs-dev] [PATCH 4/4] ovs: optimize 'ip_parse_port' function.

Signed-off-by: nickcooper-zhangtonghao --- lib/packets.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/lib/packets.c b/lib/packets.c index 990c407..1d2d452 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -436,15 +436,12 @@ char * OVS_WARN_UNUSED_RESULT

[ovs-dev] [CudaMailTagged] [PATCH 1/4] ovn: Support DNAT with port.

\ logical_ip="192.168.1.2\:8080" external_ip="30.0.0.2\:80" \ -- add logical_router R1 nat @nat This patch improves the "tests/test-l7.py" which can support the "--port" argument. This patch also provides the unit tests and the documentation. Signed

[ovs-dev] [PATCH] ovn: Fix url in OVN-Tutorial.md.

Signed-off-by: nickcooper-zhangtonghao --- tutorial/OVN-Tutorial.md | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tutorial/OVN-Tutorial.md b/tutorial/OVN-Tutorial.md index 129e918..3779558 100644 --- a/tutorial/OVN-Tutorial.md +++ b/tutorial/OVN-Tutorial.md