GitHub user jcamachor opened a pull request:
https://github.com/apache/orc/pull/249
[ORC-341] Support time zone as a parameter for Java reader and writer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcamachor/orc ORC-341
Github user jcamachor commented on the issue:
https://github.com/apache/orc/pull/249
@wgtmac , see discussion in
https://issues.apache.org/jira/browse/HIVE-12192 for more context.
---
Github user jcamachor commented on the issue:
https://github.com/apache/orc/pull/249
@omalley , it seems like a good idea, let me explore it and refresh the PR.
I will adapt HIVE-19226 to these new changes too.
@wgtmac , I understand you are suggesting that this can be fixed
Github user jcamachor commented on the issue:
https://github.com/apache/orc/pull/249
@omalley , I have been trying to add the Boolean ```useUTCTimestamp``` as
suggested. Making it work with the reader/writer does not seem to be a problem,
since I can pass the information through the
Github user jcamachor commented on the issue:
https://github.com/apache/orc/pull/249
@wgtmac , thanks for the feedback. Please bear with me for a bit, as it is
first time I am touching ORC code base.
OK, I think ```TypeDescription``` is not a problem then since we set the
value
Github user jcamachor commented on the issue:
https://github.com/apache/orc/pull/249
Pushed a new commit with the changes.
We would still need a storage-api release for the
```TimestampColumnVector``` changes.
---
Github user jcamachor commented on a diff in the pull request:
https://github.com/apache/orc/pull/249#discussion_r184811998
--- Diff: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java ---
@@ -975,6 +992,8 @@ public void nextVector(ColumnVector previousVector
GitHub user jcamachor opened a pull request:
https://github.com/apache/orc/pull/260
ORC-355. Upgrade storage-api to 2.6.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcamachor/orc ORC-355
Alternatively you can review and
Github user jcamachor commented on the issue:
https://github.com/apache/orc/pull/249
I have just updated the patch now that we have moved to the new storage-api
version. I will run some tests with Hive locally asap and will get back
confirming that everything is working as expected.
---
Github user jcamachor commented on the issue:
https://github.com/apache/orc/pull/249
I have been testing the patch from Hive and everything seems to be working
as expected.
I have rebased the patch and merge both commits. Also, I had to extend my
changes to the newly created
Github user jcamachor commented on the issue:
https://github.com/apache/orc/pull/249
@wgtmac , @omalley , thanks for the feedback. I think I have addressed all
your points with last two commits, could you take another look? Thanks
---
GitHub user jcamachor opened a pull request:
https://github.com/apache/orc/pull/270
ORC-365: Only print min and max for timestamp stats once
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcamachor/orc ORC-365
Alternatively
12 matches
Mail list logo
