GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/196
ORC-270: fix target_link_libraries for tool-test
gmock depends on pthread library, but use ${GTEST_LIBRARIES} similar to
c++\test\CMakeLists.txt
You can merge this pull request into a Git repository
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/197
ORCORC-271: Improve HAS_PRE_1970/HAS_POST_2038 code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-271
Alternatively you can
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/197
Change in HAS_POST_2038 shows the bug in osx/clang build:
/Users/travis/build/apache/orc/tools/test/TestMatch.cc:149: Failure
Expected: expectedLine
Which is: "{\"time
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/197
'Simplify HAS_POST_2038 check' commit is reverted.
---
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/198
Orc-272: Minor porting changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-272
Alternatively you can review and apply these
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/198
I don't think it is related to the proposed changes since io/InputStream.cc
(and any headers) are not touched.
---
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/200
Orc-277: [C++] centos6 build (pre 4.7 gcc) is broken
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-277
Alternatively you can
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/202
Orc-280: [C++] use Z_PREFIX if zlib requires it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-280
Alternatively you can review
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/202
linux clang build broken due to new version of compiler (5.0.0)
This is not related to proposed changes.
---
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/202
Any platform, if corresponding zlib used (by ZLIB_HOME) to build ORC.
---
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/202
It is custom installation. In my environment I have to use prebuilt static
"zprefixed" zlib.
But it is general case since custom zlib can be used via ZLIB_HOME.
---
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/209
ORC-289: [C++] replace Adaptor.hh by orc-config.hh
BTW: probably Adaptor.hh and orc-config.hh should be merged/cleaned up
since they share some code.
You can merge this pull request into a Git
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/212
ORC-293: [C++] Fix RleEncoderV1 for case when sizeof(long) < sizeof(int64_t)
and minor related changes.
You can merge this pull request into a Git repository by running:
$ git pull ht
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/212#discussion_r162753893
--- Diff: c++/src/RLEv1.cc ---
@@ -148,7 +148,7 @@ void RleEncoderV1::write(int64_t value) {
numLiterals += 1;
} else
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/212#discussion_r162755501
--- Diff: c++/src/RLEv1.cc ---
@@ -169,11 +169,11 @@ void RleEncoderV1::writeVslong(int64_t val) {
void RleEncoderV1::writeVulong(int64_t val
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/212#discussion_r163337745
--- Diff: c++/include/orc/Common.hh ---
@@ -69,7 +69,7 @@ namespace orc {
UNKNOWN_WRITER = INT32_MAX
};
- enum CompressionKind
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/212#discussion_r163724343
--- Diff: c++/include/orc/Common.hh ---
@@ -69,7 +69,7 @@ namespace orc {
UNKNOWN_WRITER = INT32_MAX
};
- enum CompressionKind
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/214
ORC-273: [C++] add range check to prevent bad memory access.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-273
Alternatively
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/241
ORC-332: Add syntax version to orc_proto.proto
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-332
Alternatively you can review
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/242
ORC-333: [C++] Minor changes to avoid warnings from MSVC
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-333
Alternatively you
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/240
This is the beginning of the changes required for MSVC.
Build at this stage will not be successful.
---
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/253
ORC-346: [C++] Add one second when writing negative Timestamp's with non
zero nanos â¦
â¦to match the reader code.
You can merge this pull request into a Git repository by running:
$ git
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/254
ORC-351: [C++] Increase buffer in Decimal*ColumnWriter to required size
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-351
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/254#discussion_r183225681
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1453,7 +1453,7 @@ namespace orc {
uint64_t numValues) override;
private
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/253
I'm not sure that it is correct fix, IMO, TimestampColumnReader should not
do this:
if (secsBuffer[i] < 0 && nanoBuffer[i] != 0) {
secsBuffer[i] -= 1;
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/256
ORC-352: [C++] Update, cleanup and add support of MSVC to
ThirdpartyToolchain
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-352
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/261
ORC-356: [C++] fix and extend Adaptor (.cc/.hh)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-356
Alternatively you can review
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/263
ORC-357: [C++] Use orc::InputStream in getTimezoneByFilename
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc _ORC-357
Alternatively
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/263#discussion_r185577344
--- Diff: c++/src/Timezone.cc ---
@@ -698,40 +694,15 @@ namespace orc {
if (itr != timezoneCache.end()) {
return *(itr->second).
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/264
ORC-358: [C++] windows/msvc version of OrcFile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-358
Alternatively you can review
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/265
ORC-334: [C++] Add AppVeyor support for integration on windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-334
Alternatively
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/265
AppVeyor after this PR:
[https://ci.appveyor.com/project/rip-nsk/orc/build/1.0.32]
---
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r186487106
--- Diff: c++/src/Timezone.cc ---
@@ -710,7 +710,11 @@ namespace orc {
* Get the local timezone.
*/
const Timezone& getLocalTime
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r186493219
--- Diff: c++/src/Timezone.cc ---
@@ -710,7 +710,11 @@ namespace orc {
* Get the local timezone.
*/
const Timezone& getLocalTime
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r186828362
--- Diff: c++/src/Timezone.cc ---
@@ -710,7 +710,11 @@ namespace orc {
* Get the local timezone.
*/
const Timezone& getLocalTime
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r186869413
--- Diff: c++/src/Timezone.cc ---
@@ -710,7 +710,11 @@ namespace orc {
* Get the local timezone.
*/
const Timezone& getLocalTime
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r187164583
--- Diff: c++/src/Timezone.cc ---
@@ -710,7 +710,11 @@ namespace orc {
* Get the local timezone.
*/
const Timezone& getLocalTime
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/265
It seems AppVeyor should be enabled by apache/orc project owner here -
https://ci.appveyor.com/projects.
---
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/271
ORC-366: [C++] Improve TZDIR setup for WIN32
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-366
Alternatively you can review and
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/271
reason for this is change [failed
buid](https://ci.appveyor.com/project/rip-nsk/orc-ft3jj)
---
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/273
C:\projects\orc\c++\src\RleEncoderV2.cc(187): warning C4334: '<<': result
of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
[C:\projects\orc\build\c++
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/273#discussion_r190919609
--- Diff: c++/src/RleEncoderV2.cc ---
@@ -0,0 +1,768 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/273#discussion_r190921029
--- Diff: c++/src/RleEncoderV2.cc ---
@@ -0,0 +1,768 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/273#discussion_r190921533
--- Diff: c++/src/RLEV2Util.hh ---
@@ -0,0 +1,145 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one
+* or more contributor
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/273#discussion_r190920599
--- Diff: c++/src/RleEncoderV2.cc ---
@@ -0,0 +1,768 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
45 matches
Mail list logo
