[GitHub] jmarantz commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch

2018-05-06 Thread GitBox
jmarantz commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1319#issuecomment-386899654 @oschaaf we lost track of this one a couple of years ago, as

[GitHub] oschaaf commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch

2018-05-07 Thread GitBox
oschaaf commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1319#issuecomment-387016076 @jmarantz Looking at the code I think ngx_pagespeed `Disallow`

[GitHub] jmarantz commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch

2018-05-07 Thread GitBox
jmarantz commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1319#issuecomment-387064987 Cool. My theory is that it's still being ipro-rewritten because it's a

[GitHub] AdriwanKenoby opened a new issue #1554: ngx_pagespeed.so not created

2018-05-07 Thread GitBox
AdriwanKenoby opened a new issue #1554: ngx_pagespeed.so not created URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1554 Get nginx from ppa and rebuild it with `dpkg-buildpackage -b`, all seems towork correctly except that i have no ngw_pagespeed.so, all the other module

[GitHub] oschaaf commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch

2018-05-07 Thread GitBox
oschaaf commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1319#issuecomment-387092354 It looks like `.pagespeed.`resources will be fetched regardless of any

[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387566711 I would suggest a default -1 expiry to match current pagespeed config behaviour, and yes we'd probably use a long TTL like 1 year in our config.

[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387566711 I would suggest a default -1 expiry to match current pagespeed config behaviour, and yes we'd probably use a long TTL like 1 year in our config.

[GitHub] free6k commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
free6k commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388714272 I have similar problem ``` nginx version: nginx/1.14.0 built by gcc 4.9.2 (Debian 4.9.2-10)

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388730282 @jstangroome awesome, I have it reproduced now! So one prerequisite that I think exists for the

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388756405 >the first request happens without Accept-Encoding: gzip @oschaaf all my testing, in

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388759087 Well actually .. in the script that demonstrates the issue there is: ``` good_css_url=$(curl

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388761430 True, I had forgotten about that. I guess a non-gzip request for the HTML may have lead to

[GitHub] oschaaf closed pull request #1559: Properly iterate modules looking for gzip commands

2018-05-14 Thread GitBox
oschaaf closed pull request #1559: Properly iterate modules looking for gzip commands URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-15 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-389066123 So I caught the http cache in gdb writing the bad entry. The C-L is 7411 with C-E gzip, but the body

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-15 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-389077301 The change above doesn't help. It probably wouldn't have been the right fix, but naively I would have

[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-07 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387212216 Essentially, all that should be required is swapping the SET command with SETEX, and defining a default for the TTL to -1 (no expiry). Then defining

[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-07 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387212216 Essentially, all that should be required is swapping the SET command with SETEX, and defining a default for the TTL to -1 (no expiry). The defining a

[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-07 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387212216 Essentially, all that should be required is swapping the SET command with SETEX, and defining a default for the TTL to -1 (no expiry), which will

[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-07 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387212216 Essentially, all that should be required is swapping the SET command with SETEX, and defining a default for the TTL to -1 (no expiry), which will

[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-07 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387209819 +1 for this feature enhancement. This is an automated message from the Apache Git

[GitHub] jmarantz commented on issue #1704: Redis cache TTL

2018-05-07 Thread GitBox
jmarantz commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387219385 Agreed this shouldn't be difficult, but adding a new config and plumbing it through to this function does touch probably ~10 files; various

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387686294 That is some really good information. Intuitively I'd think that there is an issue specific to

[GitHub] jstangroome opened a new issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
jstangroome opened a new issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556 PageSpeed 1.13.35.2 on nginx 1.13.8 on Ubuntu 14.04 (and on Minikube). Original HTML contains: ```

[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387566711 I would suggest a default -1 expiry to match current pagespeed config behaviour, and yes we'd probably use a long TTL like 1 year in our config.

[GitHub] oschaaf commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
oschaaf commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387341073 https://github.com/pagespeed/mod_pagespeed/pull/1627/files shows plumbing that is similar to what would be needed to implement this.

[GitHub] ebaystaticfile opened a new issue #1555: centos 6.9 Installing nginx with 1.13.35.1-beta fails

2018-05-08 Thread GitBox
ebaystaticfile opened a new issue #1555: centos 6.9 Installing nginx with 1.13.35.1-beta fails URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1555 # **history command** > cd /www/server/nginx/ > NPS_VERSION=1.13.35.1-beta > wget

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387757910 Is pagespeed expecting nginx to do the gzipping of the response? My nginx.conf does not contain

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387774687 In this scenario, nginx is not expected to play a role in the gzipping. As a workaround, adding

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387753373 I've just realised that the failed response is not being truncated by pagespeed. My tests with

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387745691 @oschaaf I have posted the error.log with debug-level logging on nginx built `--with-debug` as a

[GitHub] RajaHassan commented on issue #1758: ModPagespeedHonorCsp ignores that unsafe-eval is not an allowed script source

2018-04-27 Thread GitBox
RajaHassan commented on issue #1758: ModPagespeedHonorCsp ignores that unsafe-eval is not an allowed script source URL: https://github.com/apache/incubator-pagespeed-mod/issues/1758#issuecomment-384929638 can anybody tell that is this issue being fixed ?

[GitHub] oschaaf commented on issue #1552: Honor assume yes when installing dependencies

2018-04-27 Thread GitBox
oschaaf commented on issue #1552: Honor assume yes when installing dependencies URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1552#issuecomment-384973046 Code change looks good, and in terms of function it looks like this makes a lot of sense. I have to dive in some more

[GitHub] oschaaf commented on issue #1758: ModPagespeedHonorCsp ignores that unsafe-eval is not an allowed script source

2018-04-27 Thread GitBox
oschaaf commented on issue #1758: ModPagespeedHonorCsp ignores that unsafe-eval is not an allowed script source URL: https://github.com/apache/incubator-pagespeed-mod/issues/1758#issuecomment-384974178 @RajaHassan As far as I know, no-one is working to fix this right now. Not sure if

[GitHub] dsanders11 opened a new pull request #1552: Honor assume yes when installing dependencies

2018-04-27 Thread GitBox
dsanders11 opened a new pull request #1552: Honor assume yes when installing dependencies URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1552 Currently running `build_ngx_pagespeed.sh` with `--assume-yes` won't automatically send yes when installing dependencies, defeating

[GitHub] eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

2018-04-27 Thread GitBox
eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385013034 Hello, I have modified /mod_pagespeed_example/proxy_external_resource.html -

[GitHub] jmarantz commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

2018-04-27 Thread GitBox
jmarantz commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385018037 This is expected behavior. Pagespeed does not aren't to rewrite URLs embedded in

[GitHub] jmarantz closed issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

2018-04-27 Thread GitBox
jmarantz closed issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761 This is an automated message from the Apache Git

[GitHub] eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

2018-04-27 Thread GitBox
eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385013034 Hello, I have modified /mod_pagespeed_example/proxy_external_resource.html -

[GitHub] eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

2018-04-27 Thread GitBox
eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385013034 Hello, I have modified /mod_pagespeed_example/proxy_external_resource.html -

[GitHub] jmarantz commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

2018-04-27 Thread GitBox
jmarantz commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385018037 This is expected behavior. Pagespeed does not attempt to rewrite URLs embedded in

[GitHub] jmarantz commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

2018-04-27 Thread GitBox
jmarantz commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385018037 This is expected behavior. Pagespeed does not attemptto rewrite URLs embedded in

[GitHub] dsanders11 opened a new pull request #1553: Add wget as dependency for Debian-based distros in build script

2018-04-27 Thread GitBox
dsanders11 opened a new pull request #1553: Add wget as dependency for Debian-based distros in build script URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1553 `wget` is a required dependency for the build script but wasn't in the dependency list for Debian-based distros,

[GitHub] oschaaf closed pull request #1552: Honor assume yes when installing dependencies

2018-04-27 Thread GitBox
oschaaf closed pull request #1552: Honor assume yes when installing dependencies URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1552 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] dsanders11 commented on issue #1552: Honor assume yes when installing dependencies

2018-04-27 Thread GitBox
dsanders11 commented on issue #1552: Honor assume yes when installing dependencies URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1552#issuecomment-385091110 Perhaps all the dependencies are installed in the case of `--devel` (or already on the server). I believe if it found

[GitHub] injust commented on issue #1321: ShardDomain results in unoptimized CSS

2018-04-27 Thread GitBox
injust commented on issue #1321: ShardDomain results in unoptimized CSS URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1321#issuecomment-385115708 Closing due to age. Reportedly fixed in version `1.12`, according to apache/incubator-pagespeed-mod#1659.

[GitHub] injust closed issue #1321: ShardDomain results in unoptimized CSS

2018-04-27 Thread GitBox
injust closed issue #1321: ShardDomain results in unoptimized CSS URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1321 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] oschaaf closed pull request #1553: Add wget as dependency for Debian-based distros in build script

2018-04-28 Thread GitBox
oschaaf closed pull request #1553: Add wget as dependency for Debian-based distros in build script URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1553 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387890251 @oschaaf Adding `pagespeed HttpCacheCompressionLevel 0;` does resolve the issue. The

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387895462 I suspect that impact on required cache space of the workaround may not be that big: images probably

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387899755 I've confirmed that the seemingly unrelated `Content-Length: 105759` response header in the

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387894703 For reference, I've added another gist showing the hex dump of the cached file header and

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387894703 For reference, I've added another gist showing the hex dump of the cached file header and

[GitHub] jmarantz commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
jmarantz commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387924401 See also: https://github.com/apache/incubator-pagespeed-mod/issues/1362

[GitHub] berengerzyla commented on issue #1545: server push not working while pagespeed is set to on

2018-05-09 Thread GitBox
berengerzyla commented on issue #1545: server push not working while pagespeed is set to on URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1545#issuecomment-387941159 I have been scratching my head over this one too, and it's not a duplicate of #1539 . Activating

[GitHub] berengerzyla commented on issue #1545: server push not working while pagespeed is set to on

2018-05-09 Thread GitBox
berengerzyla commented on issue #1545: server push not working while pagespeed is set to on URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1545#issuecomment-387941792 Strange thing is even with all the filters deactivated, PageSpeed will try: `Trying to serve rewritten

[GitHub] Thedemon007 opened a new issue #1557: Optimized javascript is not compressed

2018-05-12 Thread GitBox
Thedemon007 opened a new issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557 When downloading to .js.pagespeed. file in specific, the server response with header Content-Encoding: gzip however it is not compressed.

[GitHub] jmarantz commented on issue #1557: Optimized javascript is not compressed

2018-05-12 Thread GitBox
jmarantz commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388586509 @Thedemon007 -- can you verify whether your Varnish is set up to incorporate Accept-Encoding into its cache key? That might

[GitHub] dsanders11 commented on issue #1559: Properly iterate modules looking for gzip commands

2018-05-13 Thread GitBox
dsanders11 commented on issue #1559: Properly iterate modules looking for gzip commands URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559#issuecomment-388623231 The CI failure seems to be a transient failure relating to the job taking too long. Might have had to do with

[GitHub] jmarantz commented on issue #1557: Optimized javascript is not compressed

2018-05-13 Thread GitBox
jmarantz commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388624209 What you are seeing when you disable memcached is effectively a pagespeed server-side cache-flush. It won't make any

[GitHub] jmarantz commented on issue #1557: Optimized javascript is not compressed

2018-05-13 Thread GitBox
jmarantz commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388624209 What you are seeing when you disable memcached is effectively a pagespeed server-side cache-flush. It won't make any

[GitHub] dsanders11 opened a new pull request #1558: Fix setting 'gzip_proxied' when applying gzip settings

2018-05-13 Thread GitBox
dsanders11 opened a new pull request #1558: Fix setting 'gzip_proxied' when applying gzip settings URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1558 This fix should be fairly self-explanatory when viewing the code, but the code was setting the wrong command (and may have

[GitHub] Thedemon007 commented on issue #1557: Optimized javascript is not compressed

2018-05-13 Thread GitBox
Thedemon007 commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388621097 I tried stop varnish temporarily but not have changes, i can confirm the problem no is varnish the problem is related

[GitHub] oschaaf commented on issue #1559: Properly iterate modules looking for gzip commands

2018-05-13 Thread GitBox
oschaaf commented on issue #1559: Properly iterate modules looking for gzip commands URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559#issuecomment-388625763 Thanks! I suspect that this is effectively a no-op, but regardless I feel it is a solid improvement as it makes

[GitHub] oschaaf commented on issue #1559: Properly iterate modules looking for gzip commands

2018-05-13 Thread GitBox
oschaaf commented on issue #1559: Properly iterate modules looking for gzip commands URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559#issuecomment-388625787 (Also -- CI is passing, I restarted it. The previous try timed out indeed).

[GitHub] dsanders11 opened a new pull request #1559: Properly iterate modules looking for gzip commands

2018-05-13 Thread GitBox
dsanders11 opened a new pull request #1559: Properly iterate modules looking for gzip commands URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1559 This change may or may not be needed. I spent a frustratingly long time trying to get gzip working with `ngx_pagespeed` in

[GitHub] oschaaf closed pull request #1558: Fix setting 'gzip_proxied' when applying gzip settings

2018-05-13 Thread GitBox
oschaaf closed pull request #1558: Fix setting 'gzip_proxied' when applying gzip settings URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1558 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] oschaaf commented on issue #1558: Fix setting 'gzip_proxied' when applying gzip settings

2018-05-13 Thread GitBox
oschaaf commented on issue #1558: Fix setting 'gzip_proxied' when applying gzip settings URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1558#issuecomment-388625511 LGTM, nice catch! /cc @keesspoelstra This

[GitHub] Thedemon007 commented on issue #1557: Optimized javascript is not compressed

2018-05-12 Thread GitBox
Thedemon007 commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388593338 I'm sure something happens with the compression, firefox show this message

[GitHub] jmarantz commented on issue #1557: Optimized javascript is not compressed

2018-05-12 Thread GitBox
jmarantz commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388597447 I don't think Varnish has a bug. I'm just trying to understand how the systems interact. Can you try taking Varnish out of

[GitHub] Thedemon007 commented on issue #1485: s-maxage stuck on

2018-05-11 Thread GitBox
Thedemon007 commented on issue #1485: s-maxage stuck on URL: https://github.com/apache/incubator-pagespeed-mod/issues/1485#issuecomment-388517818 I have s-maxage=10 header in nginx server This is an automated message from

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-13 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388665742 @oschaaf This seems to be enough to reproduce the issue 90% of the time:

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-13 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388665742 @oschaaf This seems to be enough to reproduce the issue 90% of the time:

[GitHub] Thedemon007 commented on issue #1557: Optimized javascript is not compressed

2018-05-13 Thread GitBox
Thedemon007 commented on issue #1557: Optimized javascript is not compressed URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1557#issuecomment-388658952 The server has been previously configured varnish with nginix via proxy_pass, I have tried in various ways to disable

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-10 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388261484 I've done some further investigation. The URL that is failing doesn't exactly match the URL

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-10 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388261484 I've done some further investigation. The URL that is failing doesn't exactly match the URL

[GitHub] jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-10 Thread GitBox
jstangroome commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388261484 I've done some further investigation. The URL that is failing doesn't exactly match the URL

[GitHub] jmarantz commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
jmarantz commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387400092 @oschaaf thanks for pulling up the example. I missed in the PR review that the DB-index is not in the map key. I think it needs to be incorporated

[GitHub] oschaaf commented on issue #1771: Redis DB index aliasing

2018-05-08 Thread GitBox
oschaaf commented on issue #1771: Redis DB index aliasing URL: https://github.com/apache/incubator-pagespeed-mod/issues/1771#issuecomment-387449218 Ugh, looks like you are right, nice catch. This is an automated message from

[GitHub] jmarantz opened a new issue #1771: Redis DB index aliasing

2018-05-08 Thread GitBox
jmarantz opened a new issue #1771: Redis DB index aliasing URL: https://github.com/apache/incubator-pagespeed-mod/issues/1771 Looking at the code, I believe that if two different VirtualHosts in the same config construct redis caches that differ only DB-index then the first one will win,

[GitHub] philrice commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch

2018-05-05 Thread GitBox
philrice commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1319#issuecomment-386833970 thanks for the quick answer - yeah seems to be working , at least no

[GitHub] jmarantz commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
jmarantz commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387400092 @oschaaf thanks for pulling up the example. I missed in the PR review that the DB-index is not in the map key. I think it needs to be incorporated

[GitHub] jmarantz commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
jmarantz commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387413295 RE the original premise of this feature-request; I have a couple of questions: 1. Won't Redis evict uninteresting keys based on some

[GitHub] philrice commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch

2018-05-05 Thread GitBox
philrice commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1319#issuecomment-386811108 I know this has been a while but im getting this behaviour in 1.14.0

[GitHub] jmarantz commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch

2018-05-05 Thread GitBox
jmarantz commented on issue #1319: image 404s, probably due to ipro-recorded resources falling out of cache with failing fetch URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1319#issuecomment-386820626 This issue was never resolved. LoadFromFile is a good workaround and in

[GitHub] oschaaf commented on issue #1560: SSI include fails with pagespeed in more complex scenarios

2018-05-15 Thread GitBox
oschaaf commented on issue #1560: SSI include fails with pagespeed in more complex scenarios URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1560#issuecomment-389103282 Detailed error logs at the debug level for these scenarios would be helpful in analysing this more -- if

[GitHub] chaihongjun commented on issue #1562: PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful

2018-05-17 Thread GitBox
chaihongjun commented on issue #1562: PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1562#issuecomment-389783191 @rickygm your setting is correct pagespeed

[GitHub] Lofesa commented on issue #1562: PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful

2018-05-16 Thread GitBox
Lofesa commented on issue #1562: PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1562#issuecomment-389434823 Hi pagespeed LoadFromFileRuleMatch disallow .*; is the rigth

[GitHub] oschaaf commented on issue #1563: again the error: [ngx_pagespeed 1.13.35.2-0] PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful; is fetching work

2018-05-18 Thread GitBox
oschaaf commented on issue #1563: again the error: [ngx_pagespeed 1.13.35.2-0] PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful; is fetching working? URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1563#issuecomment-390170591 In

[GitHub] Lofesa commented on issue #1563: again the error: [ngx_pagespeed 1.13.35.2-0] PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful; is fetching worki

2018-05-19 Thread GitBox
Lofesa commented on issue #1563: again the error: [ngx_pagespeed 1.13.35.2-0] PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful; is fetching working? URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1563#issuecomment-390395668 Hi

[GitHub] Lofesa commented on issue #1563: again the error: [ngx_pagespeed 1.13.35.2-0] PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful; is fetching worki

2018-05-20 Thread GitBox
Lofesa commented on issue #1563: again the error: [ngx_pagespeed 1.13.35.2-0] PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful; is fetching working? URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1563#issuecomment-390471808

[GitHub] rickygm commented on issue #1563: again the error: [ngx_pagespeed 1.13.35.2-0] PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful; is fetching work

2018-05-19 Thread GitBox
rickygm commented on issue #1563: again the error: [ngx_pagespeed 1.13.35.2-0] PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful; is fetching working? URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1563#issuecomment-390440799 Hi

[GitHub] Mag8891 commented on issue #1512: Installing NGINX with 1.13.35.1-beta fails

2018-05-20 Thread GitBox
Mag8891 commented on issue #1512: Installing NGINX with 1.13.35.1-beta fails URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1512#issuecomment-390505506 prior to install nginx pagespeed module as specified in source instructions need to install more dependencies, here is

[GitHub] Mag8891 commented on issue #1512: Installing NGINX with 1.13.35.1-beta fails

2018-05-20 Thread GitBox
Mag8891 commented on issue #1512: Installing NGINX with 1.13.35.1-beta fails URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1512#issuecomment-390505506 prior install need to install more dependancies, here is full list that worked for me apt-get -y install

[GitHub] Mag8891 commented on issue #1512: Installing NGINX with 1.13.35.1-beta fails

2018-05-20 Thread GitBox
Mag8891 commented on issue #1512: Installing NGINX with 1.13.35.1-beta fails URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1512#issuecomment-390505506 prior install need to install more dependancies, here is full list that worked for me nginx 1.14.0 on Ubuntu 18.04

[GitHub] rickygm commented on issue #1563: again the error: [ngx_pagespeed 1.13.35.2-0] PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful; is fetching work

2018-05-20 Thread GitBox
rickygm commented on issue #1563: again the error: [ngx_pagespeed 1.13.35.2-0] PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful; is fetching working? URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1563#issuecomment-390524116 Hi

[GitHub] oschaaf closed issue #1562: PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful

2018-05-17 Thread GitBox
oschaaf closed issue #1562: PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1562 This is an automated message from

[GitHub] oschaaf commented on issue #1562: PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful

2018-05-17 Thread GitBox
oschaaf commented on issue #1562: PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1562#issuecomment-389854760 @rickygm for setting up https fetching, reading

[GitHub] rickygm commented on issue #1562: PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful

2018-05-16 Thread GitBox
rickygm commented on issue #1562: PageSpeed Serf fetch failure rate extremely high; only 0 of 44 recent fetches fully successful URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1562#issuecomment-389541737 Hi Lofesa , I'm using letsencrypt , and I'm not sure if it's the right

[GitHub] morlovich commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-16 Thread GitBox
morlovich commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-389527574 On Tue, May 15, 2018 at 3:53 AM Otto van der Schaaf < notificati...@github.com> wrote: >

[GitHub] oschaaf commented on issue #1560: SSI include fails with pagespeed in more complex scenarios

2018-05-15 Thread GitBox
oschaaf commented on issue #1560: SSI include fails with pagespeed in more complex scenarios URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1560#issuecomment-389100057 The segfault probably happens when dereferencing the recorder here:

  1   2   3   4   5   6   7   8   9   10   >