[jira] [Issue Comment Deleted] (PARQUET-1862) A mistake of Parquet Format Thrift definition file's comment

2020-05-14 Thread Liam Su (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liam Su updated PARQUET-1862: - Comment: was deleted (was: PR [https://github.com/apache/parquet-format/pull/159]) > A mistake of

[jira] [Commented] (PARQUET-1862) A mistake of Parquet Format Thrift definition file's comment

2020-05-14 Thread Liam Su (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107042#comment-17107042 ] Liam Su commented on PARQUET-1862: -- PR [https://github.com/apache/parquet-format/pull/159] > A

[jira] [Created] (PARQUET-1862) A mistake of Parquet Format Thrift definition file's comment

2020-05-14 Thread Liam Su (Jira)
Liam Su created PARQUET-1862: Summary: A mistake of Parquet Format Thrift definition file's comment Key: PARQUET-1862 URL: https://issues.apache.org/jira/browse/PARQUET-1862 Project: Parquet

[jira] [Commented] (PARQUET-1862) A mistake of Parquet Format Thrift definition file's comment

2020-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107036#comment-17107036 ] ASF GitHub Bot commented on PARQUET-1862: - Liam8 opened a new pull request #159: URL:

[GitHub] [parquet-format] Liam8 opened a new pull request #159: PARQUET-1862: fix comment mistake of DataPageHeaderV2

2020-05-14 Thread GitBox
Liam8 opened a new pull request #159: URL: https://github.com/apache/parquet-format/pull/159 Statistics in DataPageHeaderV2 should be about the page, not column chunk. Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Parquet

[GitHub] [parquet-format] gszadovszky merged pull request #159: PARQUET-1862: fix comment mistake of DataPageHeaderV2

2020-05-14 Thread GitBox
gszadovszky merged pull request #159: URL: https://github.com/apache/parquet-format/pull/159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (PARQUET-1862) A mistake of Parquet Format Thrift definition file's comment

2020-05-14 Thread Gabor Szadovszky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky resolved PARQUET-1862. --- Resolution: Fixed > A mistake of Parquet Format Thrift definition file's comment >

[jira] [Created] (PARQUET-1863) Remove use of add-test-source mojo in parquet-protobuf

2020-05-14 Thread Laurent Goujon (Jira)
Laurent Goujon created PARQUET-1863: --- Summary: Remove use of add-test-source mojo in parquet-protobuf Key: PARQUET-1863 URL: https://issues.apache.org/jira/browse/PARQUET-1863 Project: Parquet

[jira] [Commented] (PARQUET-1863) Remove use of add-test-source mojo in parquet-protobuf

2020-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107922#comment-17107922 ] ASF GitHub Bot commented on PARQUET-1863: - laurentgo opened a new pull request #792: URL:

[GitHub] [parquet-mr] laurentgo opened a new pull request #792: PARQUET-1863: Configure protoc-jar-maven-plugin to add generated sources to test sources path

2020-05-14 Thread GitBox
laurentgo opened a new pull request #792: URL: https://github.com/apache/parquet-mr/pull/792 By default, protoc-jar-maven-plugin adds generated source files into the main sources path but it can be configured to add them to the test sources path instead. Change the plugin

[jira] [Commented] (PARQUET-1862) A mistake of Parquet Format Thrift definition file's comment

2020-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107115#comment-17107115 ] ASF GitHub Bot commented on PARQUET-1862: - gszadovszky merged pull request #159: URL:

[jira] [Assigned] (PARQUET-1862) A mistake of Parquet Format Thrift definition file's comment

2020-05-14 Thread Gabor Szadovszky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky reassigned PARQUET-1862: - Assignee: Liam Su > A mistake of Parquet Format Thrift definition file's

Re: Parquet - 41

2020-05-14 Thread Lekshmi Narayanan, Arun Balajiee
To add one more point to that, I am investigating with respect to my changes in PARQUET-1404, if introducing the Bloom filter at column level and at page level has any differences. For this reason, I am starting work on PARQUET-41 to first be able understand how to read/write bloom filters and

[jira] [Commented] (PARQUET-1630) Resolve Bloom filter spec concerns

2020-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107267#comment-17107267 ] ASF GitHub Bot commented on PARQUET-1630: - a2un commented on a change in pull request #146:

[GitHub] [parquet-format] a2un commented on a change in pull request #146: PARQUET-1630: Update Bloom filter format

2020-05-14 Thread GitBox
a2un commented on a change in pull request #146: URL: https://github.com/apache/parquet-format/pull/146#discussion_r424791329 ## File path: BloomFilter.md ## @@ -181,6 +182,9 @@ struct ColumnMetaData { ``` +The Bloom filter data is stored right after pages indexes, the

Re: Parquet - 41

2020-05-14 Thread Lekshmi Narayanan, Arun Balajiee
Hi I understand the concern. Please don't mistake my approach to the problem. I have made progress on the past issues as well, it's not just in the presentable form that could be appreciated by the community without those changes. Please be assured that I will make sure to push these changes