[jira] [Commented] (PHOENIX-4671) Fix minor size accounting bug for MutationSize

2018-04-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423667#comment-16423667 ] Hudson commented on PHOENIX-4671: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1822

[jira] [Commented] (PHOENIX-4677) Commons-cli needs to be listed as dependency.

2018-04-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423666#comment-16423666 ] Hudson commented on PHOENIX-4677: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1822

[jira] [Commented] (PHOENIX-4658) IllegalStateException: requestSeek cannot be called on ReversedKeyValueHeap

2018-04-03 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423578#comment-16423578 ] Toshihiro Suzuki commented on PHOENIX-4658: --- I just attached the v2 patch. Could you please

[jira] [Updated] (PHOENIX-4658) IllegalStateException: requestSeek cannot be called on ReversedKeyValueHeap

2018-04-03 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated PHOENIX-4658: -- Attachment: PHOENIX-4658-v2.patch > IllegalStateException: requestSeek cannot be

[jira] [Commented] (PHOENIX-2715) Query Log

2018-04-03 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424366#comment-16424366 ] Ankit Singhal commented on PHOENIX-2715: Thanks [~apurtell] for the review, will change the log

[GitHub] phoenix issue #295: PHOENIX-4579: Add a config to conditionally create Phoen...

2018-04-03 Thread ankitsinghal
Github user ankitsinghal commented on the issue: https://github.com/apache/phoenix/pull/295 bq. As of now, when the server gets connected to for the first time i.e. no SYSTEM tables exist, we call ensureSystemTablesMigratedToSystemNamespace, but this just creates the HBase SYSTEM

[jira] [Comment Edited] (PHOENIX-2715) Query Log

2018-04-03 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424366#comment-16424366 ] Ankit Singhal edited comment on PHOENIX-2715 at 4/3/18 6:06 PM: Thanks

[jira] [Commented] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection

2018-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424338#comment-16424338 ] ASF GitHub Bot commented on PHOENIX-4579: - Github user ankitsinghal commented on the issue:

[jira] [Commented] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection

2018-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424490#comment-16424490 ] ASF GitHub Bot commented on PHOENIX-4579: - Github user JamesRTaylor commented on a diff in the

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

2018-04-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178935257 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2643,6 +2661,26 @@ public void

[jira] [Commented] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection

2018-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424491#comment-16424491 ] ASF GitHub Bot commented on PHOENIX-4579: - Github user JamesRTaylor commented on a diff in the

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

2018-04-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178936752 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java --- @@ -0,0 +1,533 @@ +/* + * Licensed

[jira] [Commented] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection

2018-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424493#comment-16424493 ] ASF GitHub Bot commented on PHOENIX-4579: - Github user JamesRTaylor commented on a diff in the

[jira] [Commented] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection

2018-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424492#comment-16424492 ] ASF GitHub Bot commented on PHOENIX-4579: - Github user JamesRTaylor commented on a diff in the

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

2018-04-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178933517 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -1039,10 +1065,20 @@ private HTableDescriptor

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

2018-04-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178936507 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java --- @@ -0,0 +1,533 @@ +/* + * Licensed

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

2018-04-03 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424413#comment-16424413 ] James Taylor commented on PHOENIX-4683: --- Did your latest patch prevent the long timeout,

[jira] [Commented] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection

2018-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424590#comment-16424590 ] ASF GitHub Bot commented on PHOENIX-4579: - Github user ChinmaySKulkarni commented on a diff in

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

2018-04-03 Thread ChinmaySKulkarni
Github user ChinmaySKulkarni commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178962419 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java --- @@ -0,0 +1,533 @@ +/* + *

[jira] [Commented] (PHOENIX-4669) NoSuchColumnFamilyException when creating index on views that are built on tables which have named column family

2018-04-03 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424598#comment-16424598 ] Sergey Soldatov commented on PHOENIX-4669: -- [~brfrn169] LGTM. Just could you please name the

[jira] [Commented] (PHOENIX-4684) Creation of SYSTEM tables should not depend on client-side properties

2018-04-03 Thread Chinmay Kulkarni (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424619#comment-16424619 ] Chinmay Kulkarni commented on PHOENIX-4684: --- Adding a dependency on this JIRA to avoid

[jira] [Commented] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection

2018-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424584#comment-16424584 ] ASF GitHub Bot commented on PHOENIX-4579: - Github user ChinmaySKulkarni commented on a diff in

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

2018-04-03 Thread ChinmaySKulkarni
Github user ChinmaySKulkarni commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178959364 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -1039,10 +1065,20 @@ private

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

2018-04-03 Thread ChinmaySKulkarni
Github user ChinmaySKulkarni commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r178961071 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2643,6 +2661,26 @@ public void

[jira] [Commented] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection

2018-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424603#comment-16424603 ] ASF GitHub Bot commented on PHOENIX-4579: - Github user ChinmaySKulkarni commented on a diff in

[jira] [Commented] (PHOENIX-4684) Creation of SYSTEM tables should not depend on client-side properties

2018-04-03 Thread Chinmay Kulkarni (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424639#comment-16424639 ] Chinmay Kulkarni commented on PHOENIX-4684: --- [~jamestaylor] One way to handle this as we

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

2018-04-03 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424816#comment-16424816 ] James Taylor commented on PHOENIX-4683: --- +1. Great job figuring this all out. > Cap timeouts for

[jira] [Commented] (PHOENIX-4616) Move join query optimization out from QueryCompiler into QueryOptimizer

2018-04-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424821#comment-16424821 ] Hudson commented on PHOENIX-4616: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1823

[jira] [Commented] (PHOENIX-4669) NoSuchColumnFamilyException when creating index on views that are built on tables which have named column family

2018-04-03 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424733#comment-16424733 ] Toshihiro Suzuki commented on PHOENIX-4669: --- Thank you [~sergey.soldatov]. I just attach a new

[jira] [Updated] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

2018-04-03 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated PHOENIX-4683: -- Attachment: PHOENIX-4683.v5.0.98.patch > Cap timeouts for stats precompact hook logic >

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

2018-04-03 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424800#comment-16424800 ] Vincent Poon commented on PHOENIX-4683: --- Thanks [~jamestaylor], put your suggestions into v5 >

[jira] [Commented] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection

2018-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424813#comment-16424813 ] ASF GitHub Bot commented on PHOENIX-4579: - Github user JamesRTaylor commented on a diff in the

[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

2018-04-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/295#discussion_r179000414 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2643,6 +2661,26 @@ public void

[jira] [Updated] (PHOENIX-4669) NoSuchColumnFamilyException when creating index on views that are built on tables which have named column family

2018-04-03 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated PHOENIX-4669: -- Attachment: PHOENIX-4669-v3.patch > NoSuchColumnFamilyException when creating index

[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column

2018-04-03 Thread Chinmay Kulkarni (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424778#comment-16424778 ] Chinmay Kulkarni commented on PHOENIX-4668: --- [~jamestaylor] please review. Thanks. > Remove

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

2018-04-03 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424780#comment-16424780 ] James Taylor commented on PHOENIX-4683: --- bq. I don't see the long timeout anymore. That's good

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

2018-04-03 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424661#comment-16424661 ] Vincent Poon commented on PHOENIX-4683: --- [~jamestaylor] I don't see the long timeout anymore. 

[jira] [Comment Edited] (PHOENIX-4669) NoSuchColumnFamilyException when creating index on views that are built on tables which have named column family

2018-04-03 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424733#comment-16424733 ] Toshihiro Suzuki edited comment on PHOENIX-4669 at 4/3/18 11:20 PM:

[jira] [Commented] (PHOENIX-4616) Move join query optimization out from QueryCompiler into QueryOptimizer

2018-04-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424927#comment-16424927 ] Hudson commented on PHOENIX-4616: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1846

[jira] [Commented] (PHOENIX-4616) Move join query optimization out from QueryCompiler into QueryOptimizer

2018-04-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424876#comment-16424876 ] Hudson commented on PHOENIX-4616: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #79 (See