[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59269276 --- Diff: phoenix-hive/pom.xml --- @@ -0,0 +1,224 @@ + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59269299 --- Diff: phoenix-hive/pom.xml --- @@ -0,0 +1,224 @@ + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59269345 --- Diff: phoenix-hive/pom.xml --- @@ -0,0 +1,224 @@ + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59269404 --- Diff: phoenix-hive/pom.xml --- @@ -0,0 +1,224 @@ + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59269559 --- Diff: phoenix-hive/pom.xml --- @@ -0,0 +1,224 @@ + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59269604 --- Diff: phoenix-hive/pom.xml --- @@ -0,0 +1,224 @@ + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59269847 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixMetaHook.java --- @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59270355 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixRowKey.java --- @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache Software

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59271033 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/constants/PhoenixStorageHandlerConstants.java --- @@ -0,0 +1,101

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59272080 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/objectinspector/PhoenixObjectInspectorFactory.java --- @@ -0,0 +1,150

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59273613 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/mapreduce/PhoenixResultWritable.java --- @@ -0,0 +1,215 @@ +/** + * Licensed to the

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59273812 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/ql/index/IndexPredicateAnalyzer.java --- @@ -0,0 +1,486 @@ +/** + * Licensed to the

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on the pull request: https://github.com/apache/phoenix/pull/155#issuecomment-208542873 Some general thoughts (I stopped leaving them inline everytime I saw them). I'm guessing you "inherited" some of these from JeongMin's original

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-11 Thread joshelser
Github user joshelser commented on the pull request: https://github.com/apache/phoenix/pull/155#issuecomment-208626268 > it's hard to get all those miniclusters run together. I still hope to get it resolved. That's why the pom contains dependencies on calcite, hbase-tes

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-13 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59558405 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/objectinspector/PhoenixObjectInspectorFactory.java --- @@ -0,0 +1,150

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-13 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59558697 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/mapreduce/PhoenixResultWritable.java --- @@ -0,0 +1,215 @@ +/** + * Licensed to the

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-15 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59953160 --- Diff: phoenix-hive/pom.xml --- @@ -117,66 +93,44 @@ - org.apache.hbase - hbase-common

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-15 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/155#discussion_r59953321 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixMetaHook.java --- @@ -6,9 +6,9 @@ * to you under the Apache License, Version 2.0

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-15 Thread joshelser
Github user joshelser commented on the pull request: https://github.com/apache/phoenix/pull/155#issuecomment-210678972 Recent improvements look good! The new integration test is *very* nice. The ObjectInspector stuff isn't a huge deal to replace, but it's something th

[GitHub] phoenix pull request: PHOENIX-2743 Hive Storage support

2016-04-18 Thread joshelser
Github user joshelser commented on the pull request: https://github.com/apache/phoenix/pull/155#issuecomment-211454505 @ss77892 one more nit-pick, it seems like you removed the version for some of the entries in the pom but then added `${hadoop-two.version}` for others. I would

[GitHub] phoenix pull request #159: PHOENIX-2535 Create shaded clients (thin + thick)

2016-06-07 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r66094488 --- Diff: phoenix-client/pom.xml --- @@ -0,0 +1,381 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="htt

[GitHub] phoenix pull request #159: PHOENIX-2535 Create shaded clients (thin + thick)

2016-06-07 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r66094042 --- Diff: phoenix-server/pom.xml --- @@ -7,52 +30,98 @@ 4.8.0-HBase-1.2-SNAPSHOT phoenix-server - Phoenix Query Server

[GitHub] phoenix pull request #159: PHOENIX-2535 Create shaded clients (thin + thick)

2016-06-07 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r66094212 --- Diff: bin/queryserver.py --- @@ -119,7 +119,7 @@ # The command is run through subprocess so environment variables are automatically

[GitHub] phoenix pull request #159: PHOENIX-2535 Create shaded clients (thin + thick)

2016-06-07 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r66093991 --- Diff: phoenix-client/pom.xml --- @@ -0,0 +1,381 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="htt

[GitHub] phoenix pull request #159: PHOENIX-2535 Create shaded clients (thin + thick)

2016-06-07 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r66096699 --- Diff: phoenix-client/pom.xml --- @@ -0,0 +1,381 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="htt

[GitHub] phoenix pull request #159: PHOENIX-2535 Create shaded clients (thin + thick)

2016-06-07 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r66097370 --- Diff: phoenix-assembly/src/build/components/all-common-jars.xml --- @@ -88,12 +93,12 @@ ${project.basedir}/../phoenix-server/target

[GitHub] phoenix pull request #159: PHOENIX-2535 Create shaded clients (thin + thick)

2016-06-07 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r66099573 --- Diff: phoenix-client/pom.xml --- @@ -0,0 +1,381 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="htt

[GitHub] phoenix pull request #159: PHOENIX-2535 Create shaded clients (thin + thick)

2016-06-07 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r66099747 --- Diff: bin/queryserver.py --- @@ -119,7 +119,7 @@ # The command is run through subprocess so environment variables are automatically

[GitHub] phoenix pull request #159: PHOENIX-2535 Create shaded clients (thin + thick)

2016-06-07 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r66113124 --- Diff: phoenix-client/pom.xml --- @@ -0,0 +1,381 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="htt

[GitHub] phoenix pull request #159: PHOENIX-2535 Create shaded clients (thin + thick)

2016-06-08 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r66280325 --- Diff: phoenix-queryserver/pom.xml --- @@ -24,6 +26,50 @@ org.apache.maven.plugins maven-failsafe-plugin

[GitHub] phoenix pull request #183: PHOENIX-3084 source release licensing issues.

2016-07-18 Thread joshelser
GitHub user joshelser opened a pull request: https://github.com/apache/phoenix/pull/183 PHOENIX-3084 source release licensing issues. Fixes for the Apache Phoenix source release You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] phoenix pull request #183: PHOENIX-3084 source release licensing issues.

2016-07-19 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71396256 --- Diff: examples/STOCK_SYMBOL.sql --- @@ -1,3 +1,19 @@ +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor

[GitHub] phoenix pull request #183: PHOENIX-3084 source release licensing issues.

2016-07-19 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71396909 --- Diff: LICENSE --- @@ -200,3 +200,90 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the

[GitHub] phoenix issue #183: PHOENIX-3084 source release licensing issues.

2016-07-19 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/183 7d9adab removes the license headers from `examples/**/*.sql` and re-adds the exclusions to apache-rat-plugin. Filed https://issues.apache.org/jira/browse/PHOENIX-3099 to track it. --- If your

[GitHub] phoenix pull request #183: PHOENIX-3084 source release licensing issues.

2016-07-19 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71407328 --- Diff: LICENSE --- @@ -200,3 +200,90 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the

[GitHub] phoenix issue #183: 4.8.0 licensing issues.

2016-07-20 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/183 Ok, I think this one is good to go. Any chance I could bug some folks to glance over these changes (I know they're massive). @billierinaldi, @joewitt, @apurtell, @busbey

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71724014 --- Diff: NOTICE --- @@ -1,37 +1,18 @@ +Apache Phoenix +Copyright 2013-2016 The Apache Software Foundation + This product includes

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71724215 --- Diff: NOTICE --- @@ -1,37 +1,18 @@ +Apache Phoenix +Copyright 2013-2016 The Apache Software Foundation + This product includes

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71724269 --- Diff: dev/release_files/LICENSE --- @@ -201,28 +201,1238 @@ See the License for the specific language governing permissions and

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71724651 --- Diff: dev/release_files/LICENSE --- @@ -201,28 +201,1238 @@ See the License for the specific language governing permissions and

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71727042 --- Diff: dev/release_files/LICENSE --- @@ -201,28 +201,1238 @@ See the License for the specific language governing permissions and

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71727352 --- Diff: dev/release_files/LICENSE --- @@ -201,28 +201,1238 @@ See the License for the specific language governing permissions and

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71727249 --- Diff: dev/release_files/LICENSE --- @@ -201,28 +201,1238 @@ See the License for the specific language governing permissions and

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71728385 --- Diff: dev/release_files/LICENSE --- @@ -201,28 +201,1238 @@ See the License for the specific language governing permissions and

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71729382 --- Diff: dev/release_files/LICENSE --- @@ -201,28 +201,1238 @@ See the License for the specific language governing permissions and

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71731040 --- Diff: dev/release_files/LICENSE --- @@ -201,28 +201,1238 @@ See the License for the specific language governing permissions and

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/183#discussion_r71731461 --- Diff: dev/release_files/LICENSE --- @@ -201,28 +201,1238 @@ See the License for the specific language governing permissions and

[GitHub] phoenix issue #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/183 Thanks again for taking a look at this, Sean! You found some really nice brain farts from me. Changes made: * Clarified CDDL 1.0 and 1.1 references in LICENSE * Included CDDL 1.0

[GitHub] phoenix issue #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/183 I think this is good to go. Does anyone else want to look at this before I merge it in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] phoenix issue #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/183 @apurtell I got some emails from you on the naming of the tarballs, but I'm struggling to find the thread here on GH. I'm not actually 100% positive if the artifacts being named "p

[GitHub] phoenix issue #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/183 Thanks for all of the help everyone. This was merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] phoenix pull request #183: 4.8.0 licensing issues.

2016-07-21 Thread joshelser
Github user joshelser closed the pull request at: https://github.com/apache/phoenix/pull/183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] phoenix issue #186: cleanup sqlline-thin.py using python idioms.

2016-08-01 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/186 Hi @btbytes! Thanks for the changes so far. A couple of things: 1. Have you opened a JIRA issue which captures the changes you'd like to make? We want to make sure that JIRA is the s

[GitHub] phoenix issue #186: cleanup sqlline-thin.py using python idioms.

2016-08-01 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/186 Great! I've given you karma and assigned PHOENIX-3132 to you. > I was waiting for a response do this PR before I took on more refactoring ;) Hah! Smart :)

[GitHub] phoenix pull request #186: cleanup sqlline-thin.py using python idioms.

2016-08-01 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/186#discussion_r73024052 --- Diff: bin/sqlline-thin.py --- @@ -18,64 +18,58 @@ # limitations under the License

[GitHub] phoenix pull request #186: cleanup sqlline-thin.py using python idioms.

2016-08-01 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/186#discussion_r73024268 --- Diff: bin/sqlline-thin.py --- @@ -86,73 +80,83 @@ def get_serialization(): return default_serialization return stdout

[GitHub] phoenix pull request #186: cleanup sqlline-thin.py using python idioms.

2016-08-01 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/186#discussion_r73024725 --- Diff: bin/sqlline-thin.py --- @@ -18,64 +18,58 @@ # limitations under the License

[GitHub] phoenix pull request #186: cleanup sqlline-thin.py using python idioms.

2016-08-01 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/186#discussion_r73025653 --- Diff: bin/sqlline-thin.py --- @@ -18,64 +18,58 @@ # limitations under the License

[GitHub] phoenix issue #186: cleanup sqlline-thin.py using python idioms.

2016-08-01 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/186 Left a few comments for you inline. Overall, I like the changes. Would love to see corresponding ones made for sqlline.py initially (we tend to make changes to one in the other as well). I don&#

[GitHub] phoenix issue #186: cleanup sqlline-thin.py using python idioms.

2016-08-01 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/186 > quite a bit of this script is to poke the environment .. which is I/O. Unit testing may not yield much. But, i'll take a fresh look. Yeah, I can understand where you're co

[GitHub] phoenix issue #186: cleanup sqlline*.py using python idioms.

2016-08-02 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/186 > I have added what I think is cross-platform way of handling zombie? child processes. *nux is definitely the one we care about the most :). I would expect that subprocess would alre

[GitHub] phoenix pull request #275: PHOENIX-4237: Add function to calculate Java coll...

2017-10-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/275#discussion_r144414821 --- Diff: phoenix-core/src/main/java/com/force/db/i18n/OracleUpper.java --- @@ -0,0 +1,66 @@ +/* --- End diff -- Yup! You got it right

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146901856 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2514,7 +2529,7 @@ private void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146904346 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146904748 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3195,6 +3255,18 @@ public boolean

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146902373 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2526,8 +2541,14 @@ private void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146902970 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,72 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146903705 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146902673 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3086,12 +3103,18 @@ private void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146928850 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146973563 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/307#discussion_r201076875 --- Diff: phoenix-queryserver/src/it/java/org/apache/phoenix/end2end/SecureQueryServerPhoenixDBIT.java --- @@ -0,0 +1,423 @@ +/* + * Licensed to

[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/307#discussion_r201078376 --- Diff: python/requests-kerberos/LICENSE --- @@ -0,0 +1,15 @@ +ISC License --- End diff -- Just calling out that this is allowed: ISC

[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/307#discussion_r201077800 --- Diff: python/phoenixdb-module/phoenixdb/__init__.py --- @@ -1,11 +1,10 @@ -# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/307#discussion_r201076404 --- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh --- @@ -0,0 +1,59 @@ +#/usr/bin/env bash + +set -u +set -x +set -e

[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/307#discussion_r201075953 --- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh --- @@ -0,0 +1,59 @@ +#/usr/bin/env bash + +set -u +set -x +set -e

[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/307#discussion_r201077202 --- Diff: phoenix-queryserver/src/it/java/org/apache/phoenix/end2end/SecureQueryServerPhoenixDBIT.java --- @@ -0,0 +1,423 @@ +/* + * Licensed to

[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/307#discussion_r201077355 --- Diff: phoenix-queryserver/src/it/java/org/apache/phoenix/end2end/SecureQueryServerPhoenixDBIT.java --- @@ -0,0 +1,423 @@ +/* + * Licensed to

[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/307#discussion_r201418146 --- Diff: phoenix-queryserver/pom.xml --- @@ -47,6 +47,11 @@ org.apache.maven.plugins maven-failsafe-plugin

[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-10 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 > How do we make sure requests-kerberos is built in a way that phoenixdb will grab it? (e.g. 0.13.0.dev0-phoenixdb) Ah, I see this is updated in python/requests-kerbe

[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-10 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 Tried to run the test, but it failed with: ``` 2018-07-10 13:43:55,599 ERROR [main] end2end.SecureQueryServerPhoenixDBIT(359): + . deactivate '' 2018-07-10 13:43:55,599 E

[GitHub] phoenix pull request #308: Client-side hash aggregation

2018-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r201465583 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] phoenix pull request #308: Client-side hash aggregation

2018-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/308#discussion_r201468535 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ClientHashAggregatingResultIterator.java --- @@ -0,0 +1,155 @@ +/* + * Licensed

[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/307#discussion_r202106445 --- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh --- @@ -0,0 +1,59 @@ +#/usr/bin/env bash + +set -u +set -x +set -e

[GitHub] phoenix pull request #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/307#discussion_r202108057 --- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh --- @@ -0,0 +1,59 @@ +#/usr/bin/env bash + +set -u +set -x +set -e

[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-12 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 > If you are still unable to get .deactivate to work, remove it from the shell script for now and we can revisit it. Again I am being overly pedantic here, but a the shell exits, we really do

[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-12 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 Ugh, I'm getting frustrated: I have MIT kerberos on my Mac, so I unblocked myself first by just forcing the minikdc config file to be made instead of the if-branch you added

[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-13 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 > Not sure how you got MIT on Mac OS X, is it in some ports package Yeah, homebrew has a `krb5` package which I use for running stuff locally (e.g. I put it on the `PATH` before

[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-13 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 Ah, I think my issue might have been cruft sitting in `python/requests-kerberos/`, the `build` dir and the `.egg-info` dir. Getting a straightforward HTTP/401 error now. That I know how

[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-13 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 Ok, where I'm at now: * Python 2.7.15 (installed via pyenv) * Using virtualenv to circumvent the .sh script * Modified the junit test to just leave it running * Modified the

[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-13 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 Turning back on `KRB5_TRACE`... ``` DEBUG:phoenixdb.avatica.client:POST http://localhost:60358/ '\n?org.apache.calcite.avatica.proto.Requests$OpenConnectionRequest\x12&\n$386e

[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-13 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 If there's a bright-side, it's something in my environment. Spinning up the JDBC thin client against this setup works: ``` $ PHOENIX_OPTS="$PHOENIX_OPTS -Dsun.security.

[GitHub] phoenix issue #307: PHOENIX-4688 Kerberize python phoenixdb

2018-07-13 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/phoenix/pull/307 On the note about docker, trying to think about this, I feel like a docker environment that can spin up all of the necessary stuff to run both of the python tests as well as this new one will be

[GitHub] phoenix pull request #311: PHOENIX-4817 Fixed Phoenix Tracing Web Applicatio...

2018-07-18 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/311#discussion_r203445596 --- Diff: bin/traceserver.py --- @@ -116,8 +116,10 @@ #" -Xdebug -Xrunjdwp:transport=dt_socket,address=5005,server=y,susp

[GitHub] phoenix pull request #311: PHOENIX-4817 Fixed Phoenix Tracing Web Applicatio...

2018-07-18 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/311#discussion_r203447995 --- Diff: phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/TraceServlet.java --- @@ -98,33 +108,36 @@ protected String

[GitHub] phoenix pull request #311: PHOENIX-4817 Fixed Phoenix Tracing Web Applicatio...

2018-07-18 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/311#discussion_r203446437 --- Diff: phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/Main.java --- @@ -62,15 +63,18 @@ public int run(String[] arg0

[GitHub] phoenix pull request #311: PHOENIX-4817 Fixed Phoenix Tracing Web Applicatio...

2018-07-18 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/311#discussion_r203446592 --- Diff: phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/TraceServlet.java --- @@ -42,14 +45,21 @@ private static

[GitHub] phoenix pull request #311: PHOENIX-4817 Fixed Phoenix Tracing Web Applicatio...

2018-07-24 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/311#discussion_r204795871 --- Diff: bin/traceserver.py --- @@ -116,8 +116,10 @@ #" -Xdebug -Xrunjdwp:transport=dt_socket,address=5005,server=y,susp

[GitHub] phoenix pull request #311: PHOENIX-4817 Fixed Phoenix Tracing Web Applicatio...

2018-07-24 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/311#discussion_r204818876 --- Diff: bin/traceserver.py --- @@ -116,8 +116,10 @@ #" -Xdebug -Xrunjdwp:transport=dt_socket,address=5005,server=y,susp

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205884048 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java --- @@ -204,6 +219,39 @@ private static void resetGlobalMetrics

  1   2   3   >