[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438321#comment-16438321 ] Hudson commented on PHOENIX-4668: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1832 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/1832/]) PHOENIX-4668 Remove unnecessary table descriptor modification for (jtaylor: rev a5770a5a4d41bf786d3d8dd7ca9088a00418b666) * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4668.patch > > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438186#comment-16438186 ] Hudson commented on PHOENIX-4668: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1858 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1858/]) PHOENIX-4668 Remove unnecessary table descriptor modification for (jtaylor: rev 0a28d6aa8ac3197417353e32b8395738ac664ce7) * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4668.patch > > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438113#comment-16438113 ] Hudson commented on PHOENIX-4668: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #96 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/96/]) PHOENIX-4668 Remove unnecessary table descriptor modification for (jtaylor: rev 8e61260bb2df936670be836ad02018c35b6842b7) * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4668.patch > > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434812#comment-16434812 ] ASF GitHub Bot commented on PHOENIX-4668: - Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/296 +1. Will commit soon. > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Attachments: PHOENIX-4668.patch > > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434578#comment-16434578 ] ASF GitHub Bot commented on PHOENIX-4668: - Github user ChinmaySKulkarni commented on the issue: https://github.com/apache/phoenix/pull/296 @JamesRTaylor please review. Thanks! > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Attachments: PHOENIX-4668.patch > > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426272#comment-16426272 ] Ethan Wang commented on PHOENIX-4668: - As HBASE-12570 has been resolved. +1 for this patch removing work around. > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Attachments: PHOENIX-4668.patch > > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424778#comment-16424778 ] Chinmay Kulkarni commented on PHOENIX-4668: --- [~jamestaylor] please review. Thanks. > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Attachments: PHOENIX-4668.patch > > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423194#comment-16423194 ] Chinmay Kulkarni commented on PHOENIX-4668: --- [~aertoria] Please take a look and merge if it looks good. Thanks. > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Attachments: PHOENIX-4668.patch > > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410360#comment-16410360 ] ASF GitHub Bot commented on PHOENIX-4668: - Github user twdsilva commented on the issue: https://github.com/apache/phoenix/pull/296 +1 > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410226#comment-16410226 ] ASF GitHub Bot commented on PHOENIX-4668: - GitHub user ChinmaySKulkarni opened a pull request: https://github.com/apache/phoenix/pull/296 PHOENIX-4668: Remove unnecessary table descriptor modification for SPLIT_POLICY column Removed the code which: removed the SPLIT_POLICY in the system catalog table descriptor and then added it and modified the table. This was earlier done as a workaround for HBASE-12570. We specifically add the SPLIT_POLICY when creating system tables already as part of the patch for PHOENIX-1674, hence this is no longer required. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChinmaySKulkarni/phoenix PHOENIX-4668 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/phoenix/pull/296.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #296 commit 55df92b9df24e7ae6999f78aef5274c03e052e27 Author: Chinmay Kulkarni Date: 2018-03-22T20:14:10Z PHOENIX-4668: Remove unnecessary table descriptor modification for SPLIT_POLICY column Removed the code which: removed the SPLIT_POLICY in the system catalog table descriptor and then added it and modified the table. This was earlier done as a workaround for HBASE-12570. We specifically add the SPLIT_POLICY when creating system tables already as part of the patch for PHOENIX-1674, hence this is no longer required. > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column
[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410227#comment-16410227 ] ASF GitHub Bot commented on PHOENIX-4668: - Github user ChinmaySKulkarni commented on the issue: https://github.com/apache/phoenix/pull/296 @twdsilva @JamesRTaylor please review. Thanks. > Remove unnecessary table descriptor modification for SPLIT_POLICY column > > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
