Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

On 19/09/16 13:39, Suneel Marthi wrote: > The way this PR is now is so similar to how bad IBM SystemML which is a > hackwork of hurriedly put together and something I have often pointed out > to others as a clear example of "how not to design crappy software". See > this gist of an example code

Re: Intermittent problems with PIRK-35

I have not seen/experienced similar issues, but I am fine with rolling it back... On Mon, Sep 19, 2016 at 6:05 AM, Tim Ellison wrote: > I have intermittent failures caused by > "PIRK-35 Execute Tests in Parallel" > > such as > > >

[GitHub] incubator-pirk issue #93: WIP-Pirk 63-DO NOT MERGE

Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/93 A few other comments for discussion: First, I am not opposed to having separate ResponderDrivers for each responder, but let's think it through and see if we really need to go

[GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Github user DarinJ commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/93#discussion_r79377189 --- Diff: src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java --- @@ -49,83 +41,111 @@ public class ResponderDriver {

[GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Github user DarinJ commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/93#discussion_r79377024 --- Diff: src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java --- @@ -49,83 +41,111 @@ public class ResponderDriver {

[GitHub] incubator-pirk issue #94: Update a number of Pirk's pom dependencies.

Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/94 +1 will merge now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

How about an approach like this? https://github.com/tellison/incubator-pirk/tree/pirk-63 The "on-ramp" is the driver [1], which calls upon the service to find a plug-in [2] that claims to implement the required platform responder, e.g. [3]. The list of plug-ins is given in the provider's JAR

[GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

GitHub user DarinJ opened a pull request: https://github.com/apache/incubator-pirk/pull/93 WIP-Pirk 63-DO NOT MERGE This is a WIP for [PIRK-63](https://issues.apache.org/jira/browse/PIRK-63) to open the door to other responders without having to modify the actual code of Pirk.

[GitHub] incubator-pirk issue #93: WIP-Pirk 63-DO NOT MERGE

Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/93 +1 - looks good so far. One item for consideration: I am in favor of *not* providing backwards compatibility with the 'platform' option at this point, i.e. removing it

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Hey guys, Thanks for looking at the PR, I apologize if it offended anyone's eyes:). I'm glad it generated some discussion about the configuration. I didn't really like where things were heading with the config. However, didn't want to create to much scope creep. I think any hierarchical

Re: Math deck (was: Re: [GitHub] incubator-pirk pull request #92: [Pirk 67] - Add Slide Deck to the Website D...)

Correction: ...bby the binomial theorem, (1+N)**N = 1 + N*N + other terms divisible... I multiplied by N on the left when I ought to have exponentiated Walter On Mon, Sep 19, 2016 at 1:36 PM, Walter Ray-Dulany wrote: > Hi Tim, > > Apologies! It's disorienting at first,

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Refactor is definitely a first priority. Is there a design/proposal draft that we could comment on about how to go about refactoring the code. I have been trying to keep up with the emails but definitely would have missed some. On Mon, Sep 19, 2016 at 6:57 PM, Ellison Anne Williams <

[GitHub] incubator-pirk issue #95: [WIP] [PIRK-69] Improve clarity of group theory po...

Github user wraydulany commented on the issue: https://github.com/apache/incubator-pirk/pull/95 Please don't close this until we have some feedback from the community indicating that the changes provide sufficient background to make clear my (previously quite obscure, unless you knew

[GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/93#discussion_r79351660 --- Diff: src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java --- @@ -49,83 +41,111 @@ public class ResponderDriver {

[GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Github user tellison commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/93#discussion_r79352002 --- Diff: src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java --- @@ -49,83 +41,111 @@ public class ResponderDriver {

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Darin, Unless I'm reading this wrong, the patch still has many references from the ResponderDriver to the set of currently supported responders. This code will have to change when somebody wants to add a new responder type. I thought the plan was to have the responder driver agnostic of the

Re: Math deck (was: Re: [GitHub] incubator-pirk pull request #92: [Pirk 67] - Add Slide Deck to the Website D...)

Hey Walter / Tim, I just wanted to add I had some trouble similar to Tim's when trying to understand the Wideskies paper. As a person without a background in group theory/theoretical math trying to get my head around this stuff, it was very difficult for me to even find with Google what the

Re: Math deck (was: Re: [GitHub] incubator-pirk pull request #92: [Pirk 67] - Add Slide Deck to the Website D...)

One explicit vote, one implicit vote for updating/clarifying the slides. I've created PIRK-69 to improve slide clarity. Unless this doesn't make sense (tell me) I'll mark PRs on this as WIPs until I've got some agreement from the community that the slides are clear enough. On Mon, Sep 19, 2016

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Suneel, I'll try to put a couple jiras on it tonight with my thoughts. Based off my pirk-63 I was able to pull spark and storm out with no issues. I was planning to pull them out, then tackling elastic search, then hadoop as it's a little entrenched. This should keep most PRs to manageable

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Here's an example from the Flink project for how they go about new features or system breaking API changes, we could start a similar process. The Flink guys call these FLIP (Flink Improvement Proposal) and Kafka community similarly has something called KLIP. We could start a PLIP (??? :-) )

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Yes, ES is just an inputformat (like HDFS, Kafka, etc) - we don't need a separate submodule. Aside from pirk-core, it seems that we would want to break the responder implementations out into submodules. This would leave us with something along the lines of the following (at this point):

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Alright, that was in the spirit of what I was thinking when I did this. Why don't we take Tim's suggested improvements to my PR (I'll do the necessary cleanup) and at the same time just remove the platform argument altogether since backwards compatibility isn't upsetting anyone. We'll still need

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Sounds good. On Mon, Sep 19, 2016 at 4:22 PM, Darin Johnson wrote: > Alright, that was in the spirit of what I was thinking when I did this. > > Why don't we take Tim's suggested improvements to my PR (I'll do the > necessary cleanup) and at the same time just remove

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Sure will do tonight. On Sep 19, 2016 5:07 PM, "Suneel Marthi" wrote: > A shared Google doc would be more convenient than a bunch of Jiras. Its > easier to comment and add notes that way. > > > On Mon, Sep 19, 2016 at 10:38 PM, Darin Johnson >

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

+100 On Mon, Sep 19, 2016 at 11:24 PM, Ellison Anne Williams < eawilli...@apache.org> wrote: > Yes, ES is just an inputformat (like HDFS, Kafka, etc) - we don't need a > separate submodule. > > Aside from pirk-core, it seems that we would want to break the responder > implementations out into

[GitHub] incubator-pirk pull request #94: Update a number of Pirk's pom dependencies.

GitHub user tellison opened a pull request: https://github.com/apache/incubator-pirk/pull/94 Update a number of Pirk's pom dependencies. - move Pirk to later versions of JMH, Hadoop, commons-math3, commons-net, json-simple, jacoco-maven-plugin, coveralls-maven-plugin, Surefire,

Intermittent problems with PIRK-35

I have intermittent failures caused by "PIRK-35 Execute Tests in Parallel" such as --- T E S T S --- Error occurred during initialization of VM java.lang.OutOfMemoryError: unable to

[GitHub] incubator-pirk issue #94: Update a number of Pirk's pom dependencies.

Github user smarthi commented on the issue: https://github.com/apache/incubator-pirk/pull/94 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re: [GitHub] incubator-pirk pull request #93: WIP-Pirk 63-DO NOT MERGE

Great will write up the doc link here, finish pirk63 then start this. On Sep 19, 2016 5:34 PM, "Suneel Marthi" wrote: > +100 > > On Mon, Sep 19, 2016 at 11:24 PM, Ellison Anne Williams < > eawilli...@apache.org> wrote: > > > Yes, ES is just an inputformat (like HDFS,