Hi Chris,
You are right, lets do it that way. I missed that S7 is Big Endian so I will
move it to a Util class in ADS and then we might move it to the driver base
once we know we can reuse it (same for S7).
Sebastian
> Am 19.02.2018 um 10:37 schrieb Christofer Dutz :
>
> Hi All,
>
> first
I take a look at it.
Regarding breaking build: somehow our pipeline implementation handles a test
fail a failure rather than unstable.
So from my POV it would be a +1 on fixing obvious small bugs as soon as you
find them, but when we find a bug with a test that we can’t immediately fix I
think
Hi Justin,
First of all thanks for the Tests (and finding the Bug :). You are absolutely
right about your statements but I don’t think its a issue of focus rather than
time and resources (at least in my case). My intention was to bring the ADS
branch to master a soon as possible to encourage co
Hi,
> Ok ... if the max value is outside the bounds and the code should have thrown
> an error, then I apologize.
No issue. Looking again at it I’m still not sure which bit or code or test is
wrong or perhaps neither(?) but I think it should be consistent. Perhaps
Sebastian has a better idea?
Hi,
> I don’t think its a issue of focus rather than time and resources (at least
> in my case)
Fair enough and as I said we have tests (with reasonable coverage) and that's a
good thing.
> My intention was to bring the ADS branch to master a soon as possible to
> encourage contribution (see
Hi,
I extended the test with duplicated hex variants to better visualize the
boundaries:
@Test
public void checkUnsignedBoundsLongHex() {
// Hex representation to visualize valid bounds in bytes
ByteValue.checkUnsignedBounds(0x0_00_00, 2);
ByteValue.checkUnsignedBounds(0x0_FF_FF, 2);
Hi,
> I extended the test with duplicated hex variants to better visualize the
> boundaries:
> @Test
> public void checkUnsignedBoundsLongHex() {
>// Hex representation to visualize valid bounds in bytes
>ByteValue.checkUnsignedBounds(0x0_00_00, 2);
>ByteValue.checkUnsignedBounds(0x0_
Hi,
You are right: with 0x1_00_00 we ensure that we fail at the right boundary and
not at something bigger than 0xFF_FF.
I’ll fix that.
Thanks, Sebastian
> Am 22.02.2018 um 12:06 schrieb Justin Mclean :
>
> Hi,
>
>> I extended the test with duplicated hex variants to better visualize the
>
Hi Together,
Today I found the time to move from scripted pipeline to declarative pipeline.
This opens a much better integration into Jenkins and makes the Jenkinsfile
much more readable.
Small changes to before:
- The build stage is split into two (Build, Build master) where I converted the
if
