Re: S7 read issue

2020-09-01 Thread Sebastian Voss
Hi Chris, Great stuff, it works perfectly now. Thanks for your effort and best regards, Sebastian > On 1. Sep 2020, at 09:17, Christofer Dutz wrote: > > Hi Sebastian, > > I configured my S7-1200 the same way to not allow PUT/GET and indeed I missed > that the type of packet returned is

Trying a new way for me to keep the lights on ...

2020-09-01 Thread Christofer Dutz
Hi folks, yesterday I decided to try out something new: I signed up for Github Sponsors. The problem is that I am dedicating all of my time for this project, because I strongly believe in it bringing value to the world. Unfortunately the world is having trouble bringing value to my bank

Re: S7 read issue

2020-09-01 Thread Christofer Dutz
Hi Sebastian, I configured my S7-1200 the same way to not allow PUT/GET and indeed I missed that the type of packet returned is slightly different. I just updated the S7 accordingly and not I am correctly getting errors with a description on what might be wrong if it's not enabled.

Adding Using PLC4X with Grade to documentation ... WAS: Re: S7 read issue

2020-09-01 Thread Christofer Dutz
Hi Stefano, it would be super-great if you could whip up a PR for our documentation … it’s also in the same repo under src/site/asciidoc … Chris Von: Stefano Bossi Antworten an: Datum: Montag, 31. August 2020 um 15:18 An: Betreff: Re: S7 read issue Hi Sebastian, Chris wrote a very good

Re: Adding Using PLC4X with Grade to documentation ... WAS: Re: S7 read issue

2020-09-01 Thread Stefano Bossi
ok, I try, I will read how to do a PR and I will add the documentation on git. Ciao, S. On 01/09/2020 09:18, Christofer Dutz wrote: > Hi Stefano, > > it would be super-great if you could whip up a PR for our documentation … > it’s also in the same repo under src/site/asciidoc … > > Chris > >

Re: Adding Using PLC4X with Grade to documentation ... WAS: Re: S7 read issue

2020-09-01 Thread Christofer Dutz
And if you have problems creating the PR from the documentation … PRs for that welcome too ;-) Just kidding … if you need help with that, just ask :-) Chris Von: Stefano Bossi Antworten an: Datum: Dienstag, 1. September 2020 um 10:40 An: Betreff: Re: Adding Using PLC4X with Grade to

Bumped the NiFi version and added documentation on the NiFi integration

2020-09-01 Thread Christofer Dutz
Hi all, I just pushed a tiny change to the NiFi integration, bumping it to the latest NiFi version. But I also invested quite some time to write some documentation on the NiFi integration. Hope that helps. Chris

[GitHub] [plc4x] foxpluto opened a new pull request #183: Use Gradle with compiled library

2020-09-01 Thread GitBox
foxpluto opened a new pull request #183: URL: https://github.com/apache/plc4x/pull/183 HI, I have added a little description of how to use the compiled library with Gradle. Regards, S. This is an

[GitHub] [plc4x] ottlukas merged pull request #183: Use Gradle with compiled library

2020-09-01 Thread GitBox
ottlukas merged pull request #183: URL: https://github.com/apache/plc4x/pull/183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Socketcan transport

2020-09-01 Thread Łukasz Dywicki
Hey folks, I wanted to let you know that socket can stuff which I implemented in very raw form on top of JavaCAN is working. I been asked by library author to make it a part of next release of his library. I am fine with that, but before I will move code anywhere I wanted to check what's your

Re: Adding Using PLC4X with Grade to documentation ... WAS: Re: S7 read issue

2020-09-01 Thread Stefano Bossi
:-) Ok, I think i have added to the project the incredible quantity of 20 line of documentation with a Pull Request WOW, I am officially an open source community contributor !!! Regards, S. On 01/09/2020 11:10, Christofer Dutz wrote: > And if you have problems creating the PR from the

Re: Adding Using PLC4X with Grade to documentation ... WAS: Re: S7 read issue

2020-09-01 Thread Lukas Ott
Thanks Stefano +1 for your awesome work over the last weeks! and yes Chris I reviewed and merged the pull request as it was quite straightforward. Cheers Lukas Am Di., 1. Sept. 2020 um 14:11 Uhr schrieb Christofer Dutz < christofer.d...@c-ware.de>: > Hi Stefano, > > where can I see the PR … I

Re: Socketcan transport

2020-09-01 Thread Christofer Dutz
Hi Lukasz, I strongly agree that you should donate to that project what you have. After all we all benefit from it. Till that's released however I think we'll keep a copy here and use that. Thanks for your work on this ... I know CAN has been asked for quite regularly as it seems especially

Re: Adding Using PLC4X with Grade to documentation ... WAS: Re: S7 read issue

2020-09-01 Thread Christofer Dutz
Hi Stefano, where can I see the PR … I couldn’t see it in the PLC4X github repo … Ok … forget it … I see Lukas merged it … thanks for that ;-) Chris Von: Stefano Bossi Antworten an: Datum: Dienstag, 1. September 2020 um 14:05 An: Betreff: Re: Adding Using PLC4X with Grade to documentation

[BUILD-STABLE]: Job 'PLC4X/PLC4X/develop [develop] [64]'

2020-09-01 Thread Apache Jenkins Server
BUILD-STABLE: Job 'PLC4X/PLC4X/develop [develop] [64]': Is back to normal.

[GitHub] [plc4x] splatch commented on pull request #182: PLC4X-244 Support for variable length padding fields.

2020-09-01 Thread GitBox
splatch commented on pull request #182: URL: https://github.com/apache/plc4x/pull/182#issuecomment-684965544 Good spot on naming, I did a blind change trying to keep it close to initial names. Anyhow, thanks for taking care of this!

[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [60]'

2020-09-01 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [60]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/60/;>PLC4X/PLC4X/develop [develop] [60]"

[GitHub] [plc4x] chrisdutz commented on a change in pull request #170: PLC4X-207 When a Handler Timeout occurs cancel the read future to not…

2020-09-01 Thread GitBox
chrisdutz commented on a change in pull request #170: URL: https://github.com/apache/plc4x/pull/170#discussion_r481211814 ## File path: plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java ## @@ -299,6 +319,14 @@ public void

[GitHub] [plc4x] chrisdutz commented on pull request #182: PLC4X-244 Support for variable length padding fields.

2020-09-01 Thread GitBox
chrisdutz commented on pull request #182: URL: https://github.com/apache/plc4x/pull/182#issuecomment-684905262 Just saw that due to the nature of C ... you found all the places that needed adjusting ... thank you very much :-)

[GitHub] [plc4x] chrisdutz edited a comment on pull request #67: poll loop fetches data in a continous loop

2020-09-01 Thread GitBox
chrisdutz edited a comment on pull request #67: URL: https://github.com/apache/plc4x/pull/67#issuecomment-684925891 Guess it doesn't harm adding this example ... perhaps it helps someone ... however I am not sure if we would need an ICLA on file for this contribution.

[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [61]'

2020-09-01 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [61]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/61/;>PLC4X/PLC4X/develop [develop] [61]"

[GitHub] [plc4x] chrisdutz commented on pull request #178: Fix ToAnsi method : bufferoverflow

2020-09-01 Thread GitBox
chrisdutz commented on pull request #178: URL: https://github.com/apache/plc4x/pull/178#issuecomment-684920366 Hi Johanna, sorry for me picking this up so late ... I just had a look ... your code changes generally look good, and I'm not going to insist on tests as in that case I

[GitHub] [plc4x] chrisdutz commented on pull request #67: poll loop fetches data in a continous loop

2020-09-01 Thread GitBox
chrisdutz commented on pull request #67: URL: https://github.com/apache/plc4x/pull/67#issuecomment-684925891 Guess it doesn't harm adding this example ... perhaps it helps someone ... This is an automated message from the

[GitHub] [plc4x] chrisdutz commented on pull request #182: PLC4X-244 Support for variable length padding fields.

2020-09-01 Thread GitBox
chrisdutz commented on pull request #182: URL: https://github.com/apache/plc4x/pull/182#issuecomment-684899684 I will probably need to add something to the size-calculation in C too, but I'll take care of this. Perhaps also change the name of the varialbe from "needsPadding" to

[GitHub] [plc4x] chrisdutz merged pull request #182: PLC4X-244 Support for variable length padding fields.

2020-09-01 Thread GitBox
chrisdutz merged pull request #182: URL: https://github.com/apache/plc4x/pull/182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [62]'

2020-09-01 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [62]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/62/;>PLC4X/PLC4X/develop [develop] [62]"

[GitHub] [plc4x] chrisdutz commented on pull request #170: PLC4X-207 When a Handler Timeout occurs cancel the read future to not…

2020-09-01 Thread GitBox
chrisdutz commented on pull request #170: URL: https://github.com/apache/plc4x/pull/170#issuecomment-684924829 So right now I think we could probably add a test ... I do not want to force Julian to dig into my IT framework ... if you could explain the situation in which this code would