Re: [CODE GEN] Extending the mspec to support arrays terminated by conditions instead of just "length" and "count", and others ...

2019-08-08 Thread Christofer Dutz
Hi Julian, actually all the changes shouldn't have affected anything outside the sandbox drivers. So I doubt it would have a negative impact on the existing drivers and integration modules. I did double-check that the build itself works. Chris Am 08.08.19, 16:43 schrieb "Julian Feinauer" :

Re: [CODE GEN] Extending the mspec to support arrays terminated by conditions instead of just "length" and "count", and others ...

2019-08-08 Thread Julian Feinauer
Hi Chris, thanks fort he effort. I agree to merge this into develop if we ensure that we go back to "full stable" ASAP. Julian Am 08.08.19, 16:38 schrieb "Christofer Dutz" : Hi all, so I just finished refactoring the code generation in the "feature/implement-df1-driver"

Re: [CODE GEN] Extending the mspec to support arrays terminated by conditions instead of just "length" and "count", and others ...

2019-08-08 Thread Christofer Dutz
Hi all, so I just finished refactoring the code generation in the "feature/implement-df1-driver" branch. However I think I need to merge the things happening there into develop quite soon as now the maven-plugin is no longer in sync with the state of develop. First of all I cleaned up a

Re: [CODE GEN] Extending the mspec to support arrays terminated by conditions instead of just "length" and "count", and others ...

2019-08-07 Thread Christofer Dutz
Hi all, so I noticed that new field types require us to re-release the build-tools, so I would like to add a few more types: - virtual: Generates the getXYZ() method in the POJO - manual: Field for which the parse and serialization has to be provided - manualArray: like an array version of the

Re: [CODE GEN] Extending the mspec to support arrays terminated by conditions instead of just "length" and "count", and others ...

2019-08-07 Thread Christofer Dutz
Hi all, In the train (Which I didn't miss) I had an idea. I'd like to add a "virtual" field which generates a get-method without any property to back it in the pojo. This can be helpful when working with the model objects. It could look something like this: [virtual uint 8 'hurz'

Re: [CODE GEN] Extending the mspec to support arrays terminated by conditions instead of just "length" and "count", and others ...

2019-08-07 Thread Christofer Dutz
Hi Julian, As all of the elements are "fields" I thought it as a virtual field... That's why I suggested that. If you go for "external" it would be an external field, which is sort of not quite what it is. And the "whatever name it has" - field doesn't have to call external code... It could

Re: [CODE GEN] Extending the mspec to support arrays terminated by conditions instead of just "length" and "count", and others ...

2019-08-07 Thread Julian Feinauer
Hi Chris, first, thanks for the update here. I already checked your results this morning with Volker and have to say THANK both of you for your effort, we are pretty close on closing this off : ) For the rest... I agree with your suggestions. Perhaps instead of 'virtual' we could use