Re: TriggeredScraper naming convetion violated

2019-08-28 Thread Otto Fowler
And I thought Henning Wehn was the only German comedian! On August 27, 2019 at 09:43:17, Julian Feinauer ( j.feina...@pragmaticminds.de) wrote: : > Am 27.08.19, 15:39 schrieb "Christofer Dutz" : Oh wow ... you never stop learning. I have to remember this ... it fixes compile errors if you

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Julian Feinauer
: > Am 27.08.19, 15:39 schrieb "Christofer Dutz" : Oh wow ... you never stop learning. I have to remember this ... it fixes compile errors if you just put this in the beginning of the line ... Amazing ... and it improves the execution time of that line of code dramatically ... we

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Christofer Dutz
Oh wow ... you never stop learning. I have to remember this ... it fixes compile errors if you just put this in the beginning of the line ... Amazing ... and it improves the execution time of that line of code dramatically ... we should put "//" in front of every line of PLC4X __ Chris Am

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Julian Feinauer
Yep. Here is one general purpose Java switch: "//" __ J Am 27.08.19, 15:32 schrieb "Christofer Dutz" : Hi Julian, Ok ... I think with "disable" you are referring to "comment out the MBean stuff" in the TiggeredScraperImpl class? Cause other than that, I can't really see a

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Christofer Dutz
Hi Julian, Ok ... I think with "disable" you are referring to "comment out the MBean stuff" in the TiggeredScraperImpl class? Cause other than that, I can't really see a "switch" to flick. Chris Am 27.08.19, 12:41 schrieb "Julian Feinauer" : Hi, I'd rather disable MBean support

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Julian Feinauer
Hi, I'd rather disable MBean support (I'm unsure if someone uses it currently) then to rename these classes. They are part of the exernal API and e.g. used by us (and probably others) which makes the change incompatible which I would avoid for upcoming release 0.5. Julian Am 27.08.19, 12:30

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Till Voß
Hi Julian, no its not working: > > *javax.management.NotCompliantMBeanException: MBean class > org.apache.plc4x.java.scraper.triggeredscraper.TriggeredScraperImplMBean > does not implement DynamicMBean, and neither follows the Standard MBean > conventions

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Julian Feinauer
Hi Till, I know the MBean Naming convention but I don’t understand why cant just change the MBean class to have the Name as the Class + MBean added on, so TriggeredScraperImplMBean? As this should work based on the spec, not? J Am 27.08.19, 11:30 schrieb "Till Voß" : Hey, i

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Till Voß
Hey, i just checked it and it doesn't work with the class name "TriggeredScraperImplMBean". The exception only disappears, if the class is named "TriggeredScraper". After a short research i found the following convention: "By convention, an MBean interface takes the name of the Java class that

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Julian Feinauer
This would be my preferred solution as Tim just renamed the Scraper to their current Name. Julian Am 27.08.19, 10:01 schrieb "Till Voß" : Hi Julian, yes, that also works. Regards, Till Am Di., 27. Aug. 2019 um 09:34 Uhr schrieb Julian Feinauer <

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Till Voß
Hi Julian, yes, that also works. Regards, Till Am Di., 27. Aug. 2019 um 09:34 Uhr schrieb Julian Feinauer < j.feina...@pragmaticminds.de>: > Hi Till, > > good pointer. > This was in issue with two parallel branches (mine and Tims). > > I would rather Opt for Renaming the MBean to

Re: TriggeredScraper naming convetion violated

2019-08-27 Thread Julian Feinauer
Hi Till, good pointer. This was in issue with two parallel branches (mine and Tims). I would rather Opt for Renaming the MBean to TriggeredScraperImplMBean. This should also work, or? Julian Am 27.08.19, 09:24 schrieb "Till Voß" : Hi all, currently i am developing a

TriggeredScraper naming convetion violated

2019-08-27 Thread Till Voß
Hi all, currently i am developing a plc4x logstash plugin and i have an issue with the TriggeredScraper. The TriggeredScraperImpl implements the interface "TriggeredScraperMBean". The File "TriggeredScraperImpl.java" contains line 163 "mBeanServer.registerMBean(this, new ObjectName(MX_DOMAIN,