Re: Proposal: make HSSF/XSSF/SXSSF behavior consistent

2019-01-04 Thread Vladislav Galas
Sure, I understand that we should be careful. W.r.t. to throwing, the first step could be stating in javadoc that passing null to setCellFormula shold be minimized, and removeFormula() should be used instead. - To unsubscribe,

Build failed in Jenkins: POI-DSL-1.8 #627

2019-01-04 Thread Apache Jenkins Server
See Changes: [fanningpj] throw IllegalArgumnetException if null directory specified -- [...truncated 96.52 KB...] [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0,

Re: null excetion when using workbook write function

2019-01-04 Thread Kevin Yao
Can andbody help me ? I will be very grateful. Thanks, Kevin On Fri, Jan 4, 2019 at 8:12 PM Kevin Yao wrote: > hi, > I get a null exception when I use workbook write function with Apache POI. > My java code is > > try (OutputStream out = new FileOutputStream(saveUrl)) { >

Re: Proposal: make HSSF/XSSF/SXSSF behavior consistent

2019-01-04 Thread Greg Woolsey
I like this, but wonder about the change to throwing runtime exceptions (IllegalArgumentException specifically) in new cases, especially where we are deprecating a given _input_ but not an entire function, like setCellFormula(null). That seems like it will break a lot of downstream code, and

Re: Proposal: make HSSF/XSSF/SXSSF behavior consistent

2019-01-04 Thread Vladislav Galas
1. setCellType() should be deprecated. Any value/format conversions should be performed outside of the cell through its public interface. While it's still available, we'll have to stick with conversions. In the next list, for any previous type not specified explicitly, the default value for

Build failed in Jenkins: POI-DSL-1.8 #624

2019-01-04 Thread Apache Jenkins Server
pache/poi/xssf/usermodel/XSSFSheetConditionalFormatting.java>:70: error: unexpected end tag: [javadoc] * [javadoc]^ [javadoc] <https://builds.apache.org/job/POI-DSL-1.8/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFTableColumn.java>:78: error: invalid use of @retur

[Bug 63057] *Cell.setCellValue(String/RichTextString) is not exception-safe

2019-01-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63057 gallon.fi...@gmail.com changed: What|Removed |Added OS||All --- Comment #1 from

null excetion when using workbook write function

2019-01-04 Thread Kevin Yao
hi, I get a null exception when I use workbook write function with Apache POI. My java code is try (OutputStream out = new FileOutputStream(saveUrl)) { workbook.write(out); } catch (IOException e) { System.err.println(e.getMessage()); } The exception log is shown below.

[Bug 63046] Switch to SLF4J for logging

2019-01-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63046 Javen O'Neal changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this

Build failed in Jenkins: POI-DSL-OpenJDK #591

2019-01-04 Thread Apache Jenkins Server
OpenJDK/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java>:4089: warning - Tag @link: reference not found: #createTable(AreaReference)) [javadoc] <https://builds.apache.org/job/POI-DSL-OpenJDK/ws/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFRun.java>:687: warning - Tag @link

[Bug 63057] *Cell.setCellValue(String/RichTextString) is not exception-safe

2019-01-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63057 gallon.fi...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

JDK 12 Early Access build 26 & JDK 13 Early Access builds available

2019-01-04 Thread Rory O'Donnell
Hi Dominik, Happy New Year! *OpenJDK builds *- JDK 12 Early Access build 26 is available at http://jdk.java.net/12/ * These early-access, open-source builds are provided under the GNU General Public License, version 2, with the Classpath Exception

[Bug 63057] New: *Cell.setCellValue(String/RichTextString) is not exception-safe

2019-01-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63057 Bug ID: 63057 Summary: *Cell.setCellValue(String/RichTextString) is not exception-safe Product: POI Version: 4.0.x-dev Hardware: PC Status: NEW

Re: Throwing EvaluationException slows down evaluation, proposed change: not fill stack trace

2019-01-04 Thread Dominik Stadler
Hi, I would stick to system properties, it is the easiest to implement and as the feature is something that only few will be concerned with, it can be non-obvious that this is possible. Dominik. On Mon, Dec 17, 2018 at 3:48 PM pj.fanning wrote: > For me, this kind of optimisation needs to be

Build failed in Jenkins: POI-DSL-1.8 #625

2019-01-04 Thread Apache Jenkins Server
^ [javadoc] <https://builds.apache.org/job/POI-DSL-1.8/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheetConditionalFormatting.java>:70: error: unexpected end tag: [javadoc] * [javadoc]^ [javadoc] <https://builds.apache.org/job/POI-DSL-1.

Re: null excetion when using workbook write function

2019-01-04 Thread pj.fanning
The directoryEntry that is causing in the NullPointerException is set in the HSSFWorkbook constructor. Could you be passing a null into this constructor? -- Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

Jenkins build is back to normal : POI-DSL-Windows-1.8 #360

2019-01-04 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org

Jenkins build is back to normal : POI-DSL-1.8 #626

2019-01-04 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62275] vlookup function with "empty" fourth argument can not be processed.

2019-01-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62275 --- Comment #9 from Javen O'Neal --- (In reply to dolphin.in.the.sky.51 from comment #7) > In EXCEL, when the fourth argument of the vlookup function is "empty", > it operates in the same way as when FALSE is specified.

Re: Proposal: make HSSF/XSSF/SXSSF behavior consistent

2019-01-04 Thread Greg Woolsey
Good thoughts - I'm glad you are on board and thinking about the hard-to-track-down issues when implementations of interfaces differ in their behavior. I've not used the different hierarchies much, sticking mostly to XSSF, but I can see how this could lead to tricky bugs. I'm personally partial

Proposal: make HSSF/XSSF/SXSSF behavior consistent

2019-01-04 Thread Vladislav Galas
Correct me if I'm wrong: all three said implementations should behave identically in the common field (say, SXSSF doen't support array functions for understandable reasons) as long as SpreadsheetVersion constraints aren't violated. However, I was trying to improved test coverage for *Cell

Re: Proposal: make HSSF/XSSF/SXSSF behavior consistent

2019-01-04 Thread Vladislav Galas
Actually value/type conversion logic could (and should, imho) be moved to a superclass. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org

Re: Throwing EvaluationException slows down evaluation, proposed change: not fill stack trace

2019-01-04 Thread kiwiwings
Based on my experience, that setting system properties in web applications involves discussions with the web admins, I don't like system properties at all. Although [1] says the opposite, I guess (but haven't tried) that context-param aren't automatically set as system properties. Is [1] true