[GitHub] incubator-predictionio issue #363: Migrate Spray to Akka http

2017-03-15 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/issues/363 It requires to upgrade to Scala 2.11 at first to migrate Akka HTTP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-predictionio issue #362: Move storage depended tests to each stora...

2017-03-14 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/362 @dszeto `sbt test` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-predictionio pull request #372: Elasticsearch basic HTTP authentic...

2017-04-19 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/372#discussion_r112356702 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala --- @@ -18,27 +18,66

[GitHub] incubator-predictionio issue #363: Migrate Spray to Akka http

2017-04-03 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/issues/363 > It would probably be a little tricky to keep the code compatible with both Spray and Akka HTTP though. I really think so. It will bring confusion and need extra eff

[GitHub] incubator-predictionio issue #363: Migrate Spray to Akka http

2017-04-01 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/issues/363 It's impossible for now because PredictionIO must support both Scala 2.10 and 2.11. It seems to their policy to support old versions as much as possible for existing users

[GitHub] incubator-predictionio issue #405: [PIO-63]Add incubator logo and disclaimer...

2017-08-03 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/405 Merged to `livedoc` branch but the web site hasn't been updated yet. I'm wondering how is docs deployed on the web site... --- If your project is set up for it, you can reply

[GitHub] incubator-predictionio issue #403: [PIO-97] Fixes docs under the PredictionI...

2017-07-07 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/403 I checked fixed documents through test of examples in #400. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-predictionio pull request #407: [PIO-104] Make proper implementati...

2017-07-13 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/407 [PIO-104] Make proper implementation of plugins - Remove start() method of EventServerPlugin and EngineServerPlugin - Send prediction result to outputSniffers in the engine

[GitHub] incubator-predictionio-template-recommender pull request #18: Fix use of cas...

2017-07-13 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-recommender/pull/18 Fix use of case class You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio

[GitHub] incubator-predictionio pull request #408: Fix use of case class in recommend...

2017-07-13 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/408 Fix use of case class in recommendation examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio

[GitHub] incubator-predictionio pull request #409: Fix use of case class in recommend...

2017-07-13 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/409 Fix use of case class in recommendation examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio

[GitHub] incubator-predictionio pull request #405: [PIO-63]Add incubator logo and dis...

2017-07-07 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/405 [PIO-63]Add incubator logo and disclaimer to web site You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator

[GitHub] incubator-predictionio issue #405: [PIO-63]Add incubator logo and disclaimer...

2017-07-09 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/405 I put a incubator logo and disclaimer on the footer like Impala (http://impala.incubator.apache.org/) or Hivemail (http://hivemall.incubator.apache.org/), but it might be enough

[GitHub] incubator-predictionio-template-attribute-based-classifier pull request #11:...

2017-07-14 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/11 Fix use of case class You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator

[GitHub] incubator-predictionio pull request #411: Fix use of case class in classific...

2017-07-14 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/411 Fix use of case class in classification examples (docs) According to this template fix: https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/11

[GitHub] incubator-predictionio pull request #410: Fix use of case class in classific...

2017-07-14 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/410 Fix use of case class in classification examples According to this template fix: https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/11 You

[GitHub] incubator-predictionio pull request #412: [PIO-105] Batch Predictions

2017-07-17 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/412#discussion_r127852943 --- Diff: core/src/main/scala/org/apache/predictionio/workflow/BatchPredict.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed

[GitHub] incubator-predictionio-template-similar-product pull request #16: Fix use of...

2017-07-18 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-similar-product/pull/16 Fix use of case class You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio

[GitHub] incubator-predictionio pull request #415: Update license checker configurati...

2017-07-20 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/415 Update license checker configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio license

[GitHub] incubator-predictionio issue #397: [PIO-69] Update LICENSE.txt and NOTICE.tx...

2017-06-28 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/397 @dszeto I added `tests/check_libraries.sh` to check library dependencies and it's also available on the Travis build. It would be failed when there are any changes in library

[GitHub] incubator-predictionio pull request #402: [PIO-83] Replace semverfi with jav...

2017-07-03 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/402 [PIO-83] Replace semverfi with java-semver Replace [semverfi](https://github.com/softprops/semverfi) with java-semver because semverfi is no longer maintained. It stopped in Scala

[GitHub] incubator-predictionio issue #405: [PIO-63]Add incubator logo and disclaimer...

2017-08-04 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/405 @dszeto I confirmed that my fix has been applied. Thanks for your help! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419379 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala --- @@ -107,37 +107,32

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419425 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala --- @@ -107,37 +107,32

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134399019 --- Diff: core/src/main/scala/org/apache/predictionio/workflow/CleanupFunctions.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419406 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala --- @@ -107,37 +107,32

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134416803 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala --- @@ -18,27 +18,84

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134398339 --- Diff: core/src/main/scala/org/apache/predictionio/workflow/CleanupFunctions.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134399760 --- Diff: data/src/main/scala/org/apache/predictionio/data/storage/Storage.scala --- @@ -461,4 +463,11 @@ object Storage extends Logging

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134417513 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala --- @@ -18,27 +18,84

[GitHub] incubator-predictionio issue #423: Update eventmodel.html.md.erb

2017-08-20 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/423 @haginot You should merge this branch into the `livedoc` branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-predictionio-template-recommender pull request #15: Bump to PIO 0....

2017-05-03 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-recommender/pull/15 Bump to PIO 0.11.0-incubating and enhance sbt configuration You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-predictionio-template-text-classifier pull request #12: Bump to PI...

2017-05-03 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-text-classifier/pull/12 Bump to PIO 0.11.0-incubating and enhance sbt configuration You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-predictionio-template-attribute-based-classifier pull request #10:...

2017-05-03 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/10 Bump to PIO 0.11.0-incubating and enhance sbt configuration You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-predictionio pull request #378: Bump to sbt 0.13.15

2017-05-03 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/378 Bump to sbt 0.13.15 You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio sbt-0.13.15 Alternatively

[GitHub] incubator-predictionio-template-skeleton pull request #6: Bump to PIO 0.11.0...

2017-05-03 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-skeleton/pull/6 Bump to PIO 0.11.0-incubating and enhance sbt configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-predictionio-template-ecom-recommender pull request #12: Bump to P...

2017-05-03 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-ecom-recommender/pull/12 Bump to PIO 0.11.0-incubating and enhance sbt configuration You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-predictionio pull request #379: Fix docs because pio template is n...

2017-05-03 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/379 Fix docs because pio template is no longer supported. You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator

[GitHub] incubator-predictionio issue #376: Fix docs because pio template is no longe...

2017-05-03 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/376 Created new pull request against `livedoc` branch as #379. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-predictionio pull request #376: Fix docs because pio template is n...

2017-05-03 Thread takezoe
Github user takezoe closed the pull request at: https://github.com/apache/incubator-predictionio/pull/376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-predictionio pull request #383: Cache downloaded jars in Travis bu...

2017-05-11 Thread takezoe
Github user takezoe closed the pull request at: https://github.com/apache/incubator-predictionio/pull/383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-predictionio pull request #383: Cache downloaded jars in Travis bu...

2017-05-11 Thread takezoe
GitHub user takezoe reopened a pull request: https://github.com/apache/incubator-predictionio/pull/383 Cache downloaded jars in Travis build Sometimes Travis build fails in downloading jars. Maybe caching them makes Travis build stable and also decreases build time. You can merge

[GitHub] incubator-predictionio pull request #383: Cache downloaded jars in Travis bu...

2017-05-11 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/383 Cache downloaded jars in Travis build Sometimes Travis build fails in downloading jars. Maybe caching them makes Travis build stable. You can merge this pull request into a Git

[GitHub] incubator-predictionio pull request #381: Fix sbt warnings

2017-05-11 Thread takezoe
GitHub user takezoe reopened a pull request: https://github.com/apache/incubator-predictionio/pull/381 Fix sbt warnings Some operators are deprecated since sbt 0.13.13, so current sbt configuration causes following warnings. This pull request fix them. ``` [info] Compiling

[GitHub] incubator-predictionio-template-ecom-recommender pull request #13: Fix warni...

2017-05-11 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-ecom-recommender/pull/13 Fix warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio-template

[GitHub] incubator-predictionio-template-text-classifier pull request #13: Fix warnin...

2017-05-11 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-text-classifier/pull/13 Fix warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio-template

[GitHub] incubator-predictionio issue #381: Fix sbt warnings

2017-05-11 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/381 Once close and reopen to re-run Travis build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-predictionio-template-recommender pull request #17: Fix warnings

2017-05-11 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio-template-recommender/pull/17 Fix warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio-template

[GitHub] incubator-predictionio pull request #383: Cache downloaded jars in Travis bu...

2017-05-11 Thread takezoe
GitHub user takezoe reopened a pull request: https://github.com/apache/incubator-predictionio/pull/383 Cache downloaded jars in Travis build Sometimes Travis build fails in downloading jars. Maybe caching them makes Travis build stable. You can merge this pull request into a Git

[GitHub] incubator-predictionio pull request #381: Fix sbt warnings

2017-05-12 Thread takezoe
GitHub user takezoe reopened a pull request: https://github.com/apache/incubator-predictionio/pull/381 Fix sbt warnings Some operators are deprecated since sbt 0.13.13, so current sbt configuration causes following warnings. This pull request fix them. ``` [info] Compiling

[GitHub] incubator-predictionio pull request #381: Fix sbt warnings

2017-05-12 Thread takezoe
GitHub user takezoe reopened a pull request: https://github.com/apache/incubator-predictionio/pull/381 Fix sbt warnings Some operators are deprecated since sbt 0.13.13, so current sbt configuration causes following warnings. This pull request fix them. ``` [info] Compiling

[GitHub] incubator-predictionio issue #381: Fix sbt warnings

2017-05-12 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/381 Hmm... A one of cross build is failing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-predictionio pull request #381: Fix sbt warnings

2017-05-12 Thread takezoe
Github user takezoe closed the pull request at: https://github.com/apache/incubator-predictionio/pull/381 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-predictionio pull request #395: [PIO-92] Bump HBase to 1.2.6

2017-06-20 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/395 [PIO-92] Bump HBase to 1.2.6 This request upgrade only HBase dependency. Some methods have been deprecated, but they are not fixed in this request for backward compatibility. You

[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6

2017-06-20 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/391 https://github.com/apache/incubator-predictionio/pull/395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-predictionio issue #396: [PIO-69] Add sbt-dependency-graph plugin

2017-06-20 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/396 [sbt-license-report plugin](https://github.com/sbt/sbt-license-report) might be more suitable for this purpose than sbt-dependency-graph plugin. I'm testing it... --- If your

[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6

2017-06-20 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/391 @pferrel Following methods have been deprecated since HBase 1.0.0. Since they are still alive in HBase 1.2.6 current code works fine with 1.2.6. I think it's not necessary

[GitHub] incubator-predictionio pull request #395: [PIO-92] Bump HBase to 1.2.6

2017-06-21 Thread takezoe
Github user takezoe closed the pull request at: https://github.com/apache/incubator-predictionio/pull/395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-predictionio issue #396: [PIO-69] Add sbt-dependency-graph plugin

2017-06-21 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/396 Close this request because sbt-license-report plugin looks more useful to extract license information of depended libraries. --- If your project is set up for it, you can reply

[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6 (and fix dep...

2017-06-21 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/391 @pferrel and I found 3 versions of HBase at least in `build.sbt` and documentation, so I'm not sure what versions are supported in the current PredictionIIO. - 0.98.5

[GitHub] incubator-predictionio pull request #396: [PIO-69] Add sbt-dependency-graph ...

2017-06-21 Thread takezoe
Github user takezoe closed the pull request at: https://github.com/apache/incubator-predictionio/pull/396 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-predictionio issue #397: [PIO-69] Add license report generation us...

2017-06-21 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/397 I checked the license of all non-ASL libraries and all them can be included as binary form in the distribution. I added their license text to `LICENSE.txt` and updated `make

[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6 (and fix dep...

2017-06-26 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/391 @dszeto @pferrel How about keeping current code but update the prerequisites section of installation guide to clarify supported versions? About HBase, PIO supports 0.98.5

[GitHub] incubator-predictionio issue #379: Fix docs: pio template is no longer suppo...

2017-05-18 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/379 Merged to `livedoc` branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-predictionio pull request #379: Fix docs: pio template is no longe...

2017-05-26 Thread takezoe
Github user takezoe closed the pull request at: https://github.com/apache/incubator-predictionio/pull/379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-predictionio pull request #386: [PIO-90] Improve /batch/events.jso...

2017-05-31 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/386 [PIO-90] Improve /batch/events.json endpoint performance You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151484 --- Diff: storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCModels.scala --- @@ -28,15 +28,18 @@ import

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151362 --- Diff: storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCEngineInstances.scala --- @@ -29,8 +29,9 @@ class

[GitHub] incubator-predictionio issue #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/387 @dszeto As our concern, is it possible to test with Oracle database on Travis-CI or ASF's Jenkins? If no, it might be difficult to guarantee this Oracle support works correctly over

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120153688 --- Diff: data/src/main/scala/org/apache/predictionio/data/storage/Storage.scala --- @@ -306,9 +306,18 @@ object Storage extends Logging

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120150849 --- Diff: storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCChannels.scala --- @@ -29,14 +29,15 @@ class

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151795 --- Diff: storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCEvaluationInstances.scala --- @@ -0,0 +1,52

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120147041 --- Diff: data/src/main/scala/org/apache/predictionio/data/storage/Storage.scala --- @@ -306,9 +306,18 @@ object Storage extends Logging

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151628 --- Diff: storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCApps.scala --- @@ -0,0 +1,59

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151731 --- Diff: storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCEngineInstances.scala --- @@ -0,0 +1,55

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151544 --- Diff: storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCAccessKeys.scala --- @@ -0,0 +1,45

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151427 --- Diff: storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCEvaluationInstances.scala --- @@ -29,8 +29,9 @@ class

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151860 --- Diff: storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCModels.scala --- @@ -0,0 +1,56

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151665 --- Diff: storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCChannels.scala --- @@ -0,0 +1,56

[GitHub] incubator-predictionio pull request #387: Oracle databas supports

2017-06-05 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/387#discussion_r120154775 --- Diff: core/src/main/scala/org/apache/predictionio/workflow/CreateServer.scala --- @@ -198,7 +198,7 @@ object CreateServer extends

[GitHub] incubator-predictionio issue #390: Fix duplicate org name

2017-06-07 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/390 I already merged this pull request into both of `livedoc` and `develop` branch, but it has not been closed automatically. It's strange... --- If your project is set up for it, you

[GitHub] incubator-predictionio issue #389: [PIO-91] Fixed hadoop-hdfs artifact missi...

2017-06-09 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/389 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-predictionio pull request #391: [PIO-92] Bump HBase to 1.2.6

2017-06-13 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/391 [PIO-92] Bump HBase to 1.2.6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio hbase_upgrade

[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6

2017-06-18 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/391 @dszeto Documentation updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-predictionio pull request #376: Fix docs because pio template is n...

2017-05-01 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/376 Fix docs because pio template is no longer supported You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator

[GitHub] incubator-predictionio issue #376: Fix docs because pio template is no longe...

2017-05-01 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/376 @tom-chan Oh, should I make a pull request to fix doc against `livedoc` branch instead of `develop`? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-predictionio issue #384: Correct typo : addiiton -> addition

2017-05-25 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/384 @puchka Thanks. I merged this request to `livedoc` branch, so it will be applied the web site soon. This pull request will be closed automatically when this fix is merged

[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6 (and fix dep...

2017-06-27 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/391 @dszeto Thanks for your support. I updated docs in e3f8307891ae0a5b287855ad83c41379c4e1e8bc so close this pull request and [PIO-92](https://issues.apache.org/jira/projects/PIO/issues

[GitHub] incubator-predictionio pull request #391: [PIO-92] Bump HBase to 1.2.6 (and ...

2017-06-27 Thread takezoe
Github user takezoe closed the pull request at: https://github.com/apache/incubator-predictionio/pull/391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-predictionio-template-attribute-based-classifier issue #12: 0.12.0...

2017-10-10 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/12 LGTM! ---

[GitHub] incubator-predictionio-template-recommender issue #19: 0.12.0-incubating rel...

2017-10-10 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio-template-recommender/pull/19 LGTM! ---

[GitHub] incubator-predictionio-template-similar-product issue #17: 0.12.0-incubating...

2017-10-10 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio-template-similar-product/pull/17 LGTM! ---

[GitHub] incubator-predictionio pull request #440: [PIO-101] Document usage of Plug-i...

2017-10-05 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/440 [PIO-101] Document usage of Plug-in of event server and engine server You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe

[GitHub] incubator-predictionio pull request #438: [PIO-129] Move CLI document

2017-10-05 Thread takezoe
GitHub user takezoe opened a pull request: https://github.com/apache/incubator-predictionio/pull/438 [PIO-129] Move CLI document There are links to CLI document in the deploy section and collecting data section of the side menu, but if these links are clicked, the side menu

[GitHub] incubator-predictionio issue #428: [PIO-117] Cannot delete event data on ESL...

2017-09-06 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/428 Nice catch! LGTM! ---

[GitHub] incubator-predictionio issue #437: Update org.template references to org.exa...

2017-09-27 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/437 LGTM! ---

[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...

2017-08-23 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/421 > I addressed all your Scala style & usage suggestions. 👍 > Still need to take care of the threadsafety issue with the singleton client.

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-24 Thread takezoe
Github user takezoe closed the pull request at: https://github.com/apache/incubator-predictionio/pull/425 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-24 Thread takezoe
GitHub user takezoe reopened a pull request: https://github.com/apache/incubator-predictionio/pull/425 [PIO-110] Refactoring You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio refactor-common-code

[GitHub] incubator-predictionio issue #425: [PIO-110] Refactoring

2017-08-24 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/425 Closed and reopened to re-run Travis test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

  1   2   >