Just added printStackTtrace() and made a trivial PR

2018-05-08 Thread jun aoki
Hi Pulsar teaml https://github.com/apache/incubator-pulsar/pull/1750 java8 test failed due to a timeout issue which probably is probably not related

[VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

2018-05-08 Thread Matteo Merli
This is the third release candidate for Apache Pulsar, version 2.0.0-rc1-incubating. It fixes the following issues: https://github.com/apache/incubator-pulsar/milestone/12?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note that

Re: Just added printStackTtrace() and made a trivial PR

2018-05-08 Thread Sijie Guo
ReplicatorTest is a known flaky test on Jenkins CI. We have an item outstanding for fixing those flaky tests. For you PR, you can comment "retest this please", it will trigger ru-running Jenkins CI. - Sijie On Wed, May 9, 2018 at 6:14 AM, jun aoki wrote: > Hi Pulsar teaml >

Re: Just added printStackTtrace() and made a trivial PR

2018-05-08 Thread jun aoki
Thank you Sijie, that's a magic spell! :) On Tue, May 8, 2018 at 5:14 PM, Sijie Guo wrote: > ReplicatorTest is a known flaky test on Jenkins CI. We have an item > outstanding for fixing those flaky tests. > > For you PR, you can comment "retest this please", it will trigger

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

2018-05-08 Thread Sijie Guo
+1 (binding) Environment: macOS 10.13.1 * asc, sha1, sha512 are good for both src and binary distributions * binary distribution - run standalone - be able to produce and consume messages - run perf - run functions * src distribution - be able to compile and run same set of tests

RE: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2

2018-05-08 Thread Masahiro Sakamoto
+1 (binding) Environment: CentOS 7.3 * checked sha1, sha512, asc * ran standalone * producer/consumer worked normally * compiling and unit tests succeeded * rat check Masahiro -- Masahiro Sakamoto Yahoo Japan Corp. E-mail: massa...@yahoo-corp.jp -- > -Original Message- > From: Nozomi

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2

2018-05-08 Thread Ivan Kelly
-1 There's quite a few issues with LICENSE and NOTICE https://gist.githubusercontent.com/ivankelly/a93f06d2a3075575c43a0dd44165bac1/raw/83551daf958432f532ee53cccaa6397f0c1af7bf/pulsar-libs.org Some stuff is missing completely. Others are incomplete. Note that this only applies to the binary

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2

2018-05-08 Thread Matteo Merli
Thanks for checking thouroughly. Created PR at https://github.com/apache/incubator-pulsar/pull/1748 In some cases, the feedback for the NOTICE file has been to avoid inclusion on what was not strictly required, in particular, regarding non ASL licensed projects. Another example was around Netty

[CANCELED] [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2

2018-05-08 Thread Matteo Merli
Canceling vote to include license and notice fixes. On Tue, May 8, 2018 at 9:56 AM Matteo Merli wrote: > Thanks for checking thouroughly. > > Created PR at https://github.com/apache/incubator-pulsar/pull/1748 > > In some cases, the feedback for the NOTICE file has been

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2

2018-05-08 Thread Ivan Kelly
> Created PR at https://github.com/apache/incubator-pulsar/pull/1748 I'll take a look, but it may be tomorrow before I get the time. > In some cases, the feedback for the NOTICE file has been to avoid inclusion > on what was not strictly required, in particular, regarding non ASL > licensed

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 2

2018-05-08 Thread Matteo Merli
Adding the Netty deps licenses, but I don't think we need to report the ASL license in our NOTICE. The license for Netty is anyway reported in our LICENSE file. On Tue, May 8, 2018 at 10:24 AM Ivan Kelly wrote: > > Created PR at