[GitHub] qpid-cpp pull request #13: QPID-7926: [c++ broker] Windows build error "cann...

2018-04-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-cpp/pull/13


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-cpp pull request #13: QPID-7926: [c++ broker] Windows build error "cann...

2018-04-09 Thread alanconway
GitHub user alanconway opened a pull request:

https://github.com/apache/qpid-cpp/pull/13

QPID-7926: [c++ broker] Windows build error "cannot convert from 'int…

…' to 'qpid::sys::PODMutex'"

Renamed PODMutex as GlobalMutex. The important point is that it can be used 
as a
global variable. In POSIX we use a POD class and static initializer to 
acomplish
this, but on windows we use boost::recursive_mutex, which is documented as 
being
safe for use as a global variable.

Modified the QPID_MUTEX_INITIALIZER macro to be empty on windows and '= { 0 
}'
on POSIX.

This closes #11

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanconway/qpid-cpp winfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-cpp/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit e078f320b656fb1b5c79b3a9e490fca23e4d03f7
Author: Justin Ross 
Date:   2018-03-28T13:40:03Z

QPID-7926: [c++ broker] Windows build error "cannot convert from 'int' to 
'qpid::sys::PODMutex'"

Renamed PODMutex as GlobalMutex. The important point is that it can be used 
as a
global variable. In POSIX we use a POD class and static initializer to 
acomplish
this, but on windows we use boost::recursive_mutex, which is documented as 
being
safe for use as a global variable.

Modified the QPID_MUTEX_INITIALIZER macro to be empty on windows and '= { 0 
}'
on POSIX.

This closes #11




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org