[GitHub] qpid-dispatch pull request #247: DISPATCH-911 - Added global delivery counts

2018-02-12 Thread ganeshmurthy 
Github user ganeshmurthy closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/247


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #247: DISPATCH-911 - Added global delivery counts

2018-02-12 Thread ted-ross 
Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/247#discussion_r167675656
  
--- Diff: src/router_core/agent_address.c ---
@@ -54,6 +56,8 @@ const char *qdr_address_columns[] =
  "deliveriesTransit",
  "deliveriesToContainer",
  "deliveriesFromContainer",
+ "deliveriesToRouteContainer",
+ "deliveriesFromRouteContainer",
--- End diff --

I find the names of these two new attributes misleading.  They appear to be 
grouped with the former two attributes "deliveriesToContainer" and 
"deliveriesFromContainer" because of the similar naming.  The new stats are 
supposed to be grouped with "deliveriesIngress" and "deliveriesEgress".  I 
think better names would be "deliveriesIngressRouteContainer" and 
"deliveriesEgressRouteContainer".


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #247: DISPATCH-911 - Added global delivery counts

2018-01-26 Thread ganeshmurthy 
GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/247

DISPATCH-911 - Added global delivery counts



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-911

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/247.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #247


commit 2e4896c9dd4db64499b2809cbf7e07df5f9c2258
Author: Ganesh Murthy 
Date:   2018-01-26T18:12:12Z

DISPATCH-911 - Added global delivery counts




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org