[jira] [Commented] (DISPATCH-1237) large frame multicast can stall receivers if one receiver closes its connection
[ https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739763#comment-16739763 ] ASF subversion and git services commented on DISPATCH-1237: --- Commit 2bd3328448e03849d94dd821dfb2f056df8a9076 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2bd3328 ] DISPATCH-1237 - Added additional small message test > large frame multicast can stall receivers if one receiver closes its > connection > --- > > Key: DISPATCH-1237 > URL: https://issues.apache.org/jira/browse/DISPATCH-1237 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Environment: The attached patch updates the edge router test to > reproduce this issue. > NOTE WELL - you must have the fix for DISPATCH-1235 applied before running > this test else the router will crash. >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > Attachments: test.patch > > > Ran the following scenario on an edge router: > 1 sender (not presettled) > 3 receivers > multicast > large message > If I have one of the receivers close its connection while in the middle of a > multi frame transfer the router marks the message as "discard" and does not > forward the remaining frames to the two remaining clients, thus stalling > their links. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1237) large frame multicast can stall receivers if one receiver closes its connection
[ https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739730#comment-16739730 ] ASF subversion and git services commented on DISPATCH-1237: --- Commit 7021a7b331caf414f1725b497ec5168f68df10b7 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7021a7b ] DISPATCH-1237 - Added condition to check if the multicasted delivery has only one peer > large frame multicast can stall receivers if one receiver closes its > connection > --- > > Key: DISPATCH-1237 > URL: https://issues.apache.org/jira/browse/DISPATCH-1237 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Environment: The attached patch updates the edge router test to > reproduce this issue. > NOTE WELL - you must have the fix for DISPATCH-1235 applied before running > this test else the router will crash. >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > Attachments: test.patch > > > Ran the following scenario on an edge router: > 1 sender (not presettled) > 3 receivers > multicast > large message > If I have one of the receivers close its connection while in the middle of a > multi frame transfer the router marks the message as "discard" and does not > forward the remaining frames to the two remaining clients, thus stalling > their links. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1237) large frame multicast can stall receivers if one receiver closes its connection
[ https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739713#comment-16739713 ] ASF subversion and git services commented on DISPATCH-1237: --- Commit a24ea080f4e6da2899258bc04d32639b5847c8f7 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=a24ea08 ] DISPATCH-1237 - Removed public function qd_message_num_closed_receivers. Also check size of peers to check if delivery can be released instead of using size of addr->rlinks > large frame multicast can stall receivers if one receiver closes its > connection > --- > > Key: DISPATCH-1237 > URL: https://issues.apache.org/jira/browse/DISPATCH-1237 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Environment: The attached patch updates the edge router test to > reproduce this issue. > NOTE WELL - you must have the fix for DISPATCH-1235 applied before running > this test else the router will crash. >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > Attachments: test.patch > > > Ran the following scenario on an edge router: > 1 sender (not presettled) > 3 receivers > multicast > large message > If I have one of the receivers close its connection while in the middle of a > multi frame transfer the router marks the message as "discard" and does not > forward the remaining frames to the two remaining clients, thus stalling > their links. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1237) large frame multicast can stall receivers if one receiver closes its connection
[ https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739644#comment-16739644 ] ASF subversion and git services commented on DISPATCH-1237: --- Commit bf9dd68a02308a076b3887efb2cc10c6e1176e9e in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=bf9dd68 ] DISPATCH-1237 - Modified link cleanup code to not release a multicasted peer if there are being delivered to one of more receivers. Also added a mechanism to keep track of consumers that close in the middle of transmission so streaming buffers can be freed at the appropriate time. This closes #436. > large frame multicast can stall receivers if one receiver closes its > connection > --- > > Key: DISPATCH-1237 > URL: https://issues.apache.org/jira/browse/DISPATCH-1237 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Environment: The attached patch updates the edge router test to > reproduce this issue. > NOTE WELL - you must have the fix for DISPATCH-1235 applied before running > this test else the router will crash. >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > Attachments: test.patch > > > Ran the following scenario on an edge router: > 1 sender (not presettled) > 3 receivers > multicast > large message > If I have one of the receivers close its connection while in the middle of a > multi frame transfer the router marks the message as "discard" and does not > forward the remaining frames to the two remaining clients, thus stalling > their links. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1237) large frame multicast can stall receivers if one receiver closes its connection
[ https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739645#comment-16739645 ] ASF GitHub Bot commented on DISPATCH-1237: -- asfgit commented on pull request #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast… URL: https://github.com/apache/qpid-dispatch/pull/436 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > large frame multicast can stall receivers if one receiver closes its > connection > --- > > Key: DISPATCH-1237 > URL: https://issues.apache.org/jira/browse/DISPATCH-1237 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Environment: The attached patch updates the edge router test to > reproduce this issue. > NOTE WELL - you must have the fix for DISPATCH-1235 applied before running > this test else the router will crash. >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > Attachments: test.patch > > > Ran the following scenario on an edge router: > 1 sender (not presettled) > 3 receivers > multicast > large message > If I have one of the receivers close its connection while in the middle of a > multi frame transfer the router marks the message as "discard" and does not > forward the remaining frames to the two remaining clients, thus stalling > their links. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1237) large frame multicast can stall receivers if one receiver closes its connection
[ https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739486#comment-16739486 ] ASF GitHub Bot commented on DISPATCH-1237: -- codecov-io commented on issue #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast… URL: https://github.com/apache/qpid-dispatch/pull/436#issuecomment-451772267 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=h1) Report > Merging [#436](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/85847d62f694c0717c5db32c60aaa80bf7940ab2?src=pr=desc) will **increase** coverage by `0.07%`. > The diff coverage is `90%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=tree) ```diff @@Coverage Diff @@ ## master #436 +/- ## == + Coverage 86.93% 87.01% +0.07% == Files 85 85 Lines 1870018716 +16 == + Hits1625716285 +28 + Misses 2443 2431 -12 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `91.06% <100%> (+0.77%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.15% <83.33%> (+0.03%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.84% <90%> (-0.02%)` | :arrow_down: | | [src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=) | `83.52% <0%> (+0.28%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `64.4% <0%> (+0.56%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.92% <0%> (+0.7%)` | :arrow_up: | | [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==) | `93.61% <0%> (+0.95%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=footer). Last update [85847d6...963c3b4](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > large frame multicast can stall receivers if one receiver closes its > connection > --- > > Key: DISPATCH-1237 > URL: https://issues.apache.org/jira/browse/DISPATCH-1237 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Environment: The attached patch updates the edge router test to > reproduce this issue. > NOTE WELL - you must have the fix for DISPATCH-1235 applied before running > this test else the router will crash. >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > Attachments: test.patch > > > Ran the following scenario on an edge router: > 1 sender (not presettled) > 3 receivers > multicast > large message > If I have one of the receivers close its connection while in the middle of a > multi frame transfer the router marks the message as "discard" and does not > forward the remaining frames to the two remaining clients, thus stalling > their
[jira] [Commented] (DISPATCH-1237) large frame multicast can stall receivers if one receiver closes its connection
[ https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735322#comment-16735322 ] ASF GitHub Bot commented on DISPATCH-1237: -- codecov-io commented on issue #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast… URL: https://github.com/apache/qpid-dispatch/pull/436#issuecomment-451772267 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=h1) Report > Merging [#436](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/ee0d77a57feae97ba21fcfda6f65ac06b29226e5?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=tree) ```diff @@Coverage Diff @@ ## master #436 +/- ## == - Coverage 86.97% 86.94% -0.04% == Files 85 85 Lines 1869918703 +4 == - Hits1626416261 -3 - Misses 2435 2442 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.89% <50%> (-0.36%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `77.4% <0%> (-0.76%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.84% <0%> (-0.57%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.29% <0%> (-0.3%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `93.45% <0%> (-0.22%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.95% <0%> (-0.13%)` | :arrow_down: | | [src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=) | `83.52% <0%> (+0.28%)` | :arrow_up: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `92.67% <0%> (+0.36%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.92% <0%> (+0.7%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=footer). Last update [ee0d77a...52e4660](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > large frame multicast can stall receivers if one receiver closes its > connection > --- > > Key: DISPATCH-1237 > URL: https://issues.apache.org/jira/browse/DISPATCH-1237 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Environment: The attached patch updates the edge router test to > reproduce this issue. > NOTE WELL - you must have the fix for DISPATCH-1235 applied before running > this test else the router will crash. >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > Attachments: test.patch > > > Ran the following scenario on an edge router: > 1 sender (not presettled) >
[jira] [Commented] (DISPATCH-1237) large frame multicast can stall receivers if one receiver closes its connection
[ https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735313#comment-16735313 ] ASF GitHub Bot commented on DISPATCH-1237: -- codecov-io commented on issue #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast… URL: https://github.com/apache/qpid-dispatch/pull/436#issuecomment-451772267 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=h1) Report > Merging [#436](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/ee0d77a57feae97ba21fcfda6f65ac06b29226e5?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=tree) ```diff @@Coverage Diff @@ ## master #436 +/- ## == - Coverage 86.97% 86.93% -0.04% == Files 85 85 Lines 1869918705 +6 == - Hits1626416262 -2 - Misses 2435 2443 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.9% <66.66%> (-0.35%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `77.4% <0%> (-0.76%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.84% <0%> (-0.57%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.14% <0%> (-0.45%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `93.45% <0%> (-0.22%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.95% <0%> (-0.13%)` | :arrow_down: | | [src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=) | `83.52% <0%> (+0.28%)` | :arrow_up: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `92.67% <0%> (+0.36%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/436/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.92% <0%> (+0.7%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=footer). Last update [ee0d77a...52e4660](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > large frame multicast can stall receivers if one receiver closes its > connection > --- > > Key: DISPATCH-1237 > URL: https://issues.apache.org/jira/browse/DISPATCH-1237 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Environment: The attached patch updates the edge router test to > reproduce this issue. > NOTE WELL - you must have the fix for DISPATCH-1235 applied before running > this test else the router will crash. >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > Attachments: test.patch > > > Ran the following scenario on an edge router: > 1 sender (not
[jira] [Commented] (DISPATCH-1237) large frame multicast can stall receivers if one receiver closes its connection
[ https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735288#comment-16735288 ] ASF GitHub Bot commented on DISPATCH-1237: -- ganeshmurthy commented on pull request #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast… URL: https://github.com/apache/qpid-dispatch/pull/436 …ed peer if there are being delivered to one of more receivers This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > large frame multicast can stall receivers if one receiver closes its > connection > --- > > Key: DISPATCH-1237 > URL: https://issues.apache.org/jira/browse/DISPATCH-1237 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Environment: The attached patch updates the edge router test to > reproduce this issue. > NOTE WELL - you must have the fix for DISPATCH-1235 applied before running > this test else the router will crash. >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > Attachments: test.patch > > > Ran the following scenario on an edge router: > 1 sender (not presettled) > 3 receivers > multicast > large message > If I have one of the receivers close its connection while in the middle of a > multi frame transfer the router marks the message as "discard" and does not > forward the remaining frames to the two remaining clients, thus stalling > their links. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1237) large frame multicast can stall receivers if one receiver closes its connection
[ https://issues.apache.org/jira/browse/DISPATCH-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734539#comment-16734539 ] Ken Giusti commented on DISPATCH-1237: -- The message is being marked 'discard' because the terminal disposition is being set to PN_RELEASED. The expected behavior for unsettled multicast is to set the terminal disposition to PN_ACCEPTED if the sent message was delivered to any client, as it is in this case. > large frame multicast can stall receivers if one receiver closes its > connection > --- > > Key: DISPATCH-1237 > URL: https://issues.apache.org/jira/browse/DISPATCH-1237 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Environment: The attached patch updates the edge router test to > reproduce this issue. > NOTE WELL - you must have the fix for DISPATCH-1235 applied before running > this test else the router will crash. >Reporter: Ken Giusti >Priority: Major > Fix For: 1.5.0 > > Attachments: test.patch > > > Ran the following scenario on an edge router: > 1 sender (not presettled) > 3 receivers > multicast > large message > If I have one of the receivers close its connection while in the middle of a > multi frame transfer the router marks the message as "discard" and does not > forward the remaining frames to the two remaining clients, thus stalling > their links. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
