[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799384#comment-16799384 ] ASF subversion and git services commented on DISPATCH-1275: --- Commit d84d75ea48954a3064e1c776fead7e061445308e in qpid-dispatch's branch refs/heads/master from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=d84d75e ] DISPATCH-1275: Fix exception test to work in python2 and python3 > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a UPDATE management > request. A connection id must be provided to update a connection > (adminStatus=deleted). When a client deletes a connection object, the > connection to the peer is terminated by the router. Client will not be > allowed to terminate inter-router connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799058#comment-16799058 ] ASF GitHub Bot commented on DISPATCH-1275: -- asfgit commented on pull request #467: DISPATCH-1275 - Enabled deletion of connections based on connection i… URL: https://github.com/apache/qpid-dispatch/pull/467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a UPDATE management > request. A connection id must be provided to update a connection > (adminStatus=deleted). When a client deletes a connection object, the > connection to the peer is terminated by the router. Client will not be > allowed to terminate inter-router connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799057#comment-16799057 ] ASF subversion and git services commented on DISPATCH-1275: --- Commit 9f621c432f7e9dd49156292d1f7e53be4fd7eaf9 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=9f621c4 ] DISPATCH-1275 - Enabled deletion of connections based on connection id. Added related policy code. By default, a user has privileges to delete a connection. A policy needs to disallow this. Inter-router connections can never be deleted This closes #467 > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a UPDATE management > request. A connection id must be provided to update a connection > (adminStatus=deleted). When a client deletes a connection object, the > connection to the peer is terminated by the router. Client will not be > allowed to terminate inter-router connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797436#comment-16797436 ] ASF GitHub Bot commented on DISPATCH-1275: -- codecov-io commented on issue #467: DISPATCH-1275 - Enabled deletion of connections based on connection i… URL: https://github.com/apache/qpid-dispatch/pull/467#issuecomment-474978648 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr&el=h1) Report > Merging [#467](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/136940b55a6c0d269726f27e3c0087deafa492e5?src=pr&el=desc) will **increase** coverage by `0.19%`. > The diff coverage is `80%`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/467/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #467 +/- ## == + Coverage 86.69% 86.88% +0.19% == Files 86 86 Lines 1908619175 +89 == + Hits1654616660 +114 + Misses 2540 2515 -25 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/amqp.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr&el=tree#diff-c3JjL2FtcXAuYw==) | `0% <ø> (ø)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.26% <100%> (+0.07%)` | :arrow_up: | | [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr&el=tree#diff-c3JjL3BvbGljeS5j) | `85.31% <100%> (+0.02%)` | :arrow_up: | | [src/router\_core/agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50LmM=) | `87.5% <100%> (+8.59%)` | :arrow_up: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `79.03% <100%> (-0.6%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.6% <100%> (+0.05%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.9% <50%> (-0.39%)` | :arrow_down: | | [src/router\_core/agent\_connection.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2Nvbm5lY3Rpb24uYw==) | `82.88% <73.77%> (+5.86%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `91.25% <0%> (-0.29%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/qpid-dispatch/pull/467/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr&el=footer). Last update [136940b...f517868](https://codecov.io/gh/apache/qpid-dispatch/pull/467?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connectio
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793812#comment-16793812 ] ASF GitHub Bot commented on DISPATCH-1275: -- ganeshmurthy commented on pull request #467: DISPATCH-1275 - Enabled deletion of connections based on connection i… URL: https://github.com/apache/qpid-dispatch/pull/467 …d. Added related policy code. By default, a user has privileges to delete a connection. A policy needs to disallow this. Inter-router connections can never be deleted This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a DELETE management > request. A connection id must be provided to delete a connection. When a > client deletes a connection object, the connection to the peer is terminated > by the router. Client will not be allowed to terminate inter-router > connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786125#comment-16786125 ] ASF GitHub Bot commented on DISPATCH-1275: -- ganeshmurthy commented on pull request #455: DISPATCH-1275 - Enabled deletion of connections based on connection i… URL: https://github.com/apache/qpid-dispatch/pull/455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a DELETE management > request. A connection id must be provided to delete a connection. When a > client deletes a connection object, the connection to the peer is terminated > by the router. Client will not be allowed to terminate inter-router > connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786081#comment-16786081 ] ASF GitHub Bot commented on DISPATCH-1275: -- ted-ross commented on pull request #455: DISPATCH-1275 - Enabled deletion of connections based on connection i… URL: https://github.com/apache/qpid-dispatch/pull/455#discussion_r263110299 ## File path: src/router_core/agent.c ## @@ -414,7 +414,7 @@ static void qdr_manage_delete_CT(qdr_core_t *core, qdr_action_t *action, bool di case QD_ROUTER_CONFIG_ADDRESS:qdra_config_address_delete_CT(core, query, name, identity); break; case QD_ROUTER_CONFIG_LINK_ROUTE: qdra_config_link_route_delete_CT(core, query, name, identity); break; case QD_ROUTER_CONFIG_AUTO_LINK: qdra_config_auto_link_delete_CT(core, query, name, identity); break; -case QD_ROUTER_CONNECTION:break; +case QD_ROUTER_CONNECTION:qdra_connection_delete_CT(core, query, identity); break; //Connection objects are created by the router and they have an id and no name Review comment: The forced closing of a connection is supposed to be signalled by setting the adminStatus to "deleted", not by using the DELETE method in AMQP management. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a DELETE management > request. A connection id must be provided to delete a connection. When a > client deletes a connection object, the connection to the peer is terminated > by the router. Client will not be allowed to terminate inter-router > connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786061#comment-16786061 ] ASF GitHub Bot commented on DISPATCH-1275: -- ted-ross commented on pull request #455: DISPATCH-1275 - Enabled deletion of connections based on connection i… URL: https://github.com/apache/qpid-dispatch/pull/455#discussion_r263100625 ## File path: python/qpid_dispatch_internal/policy/policy_local.py ## @@ -72,6 +72,7 @@ class PolicyKeys(object): KW_ALLOW_USERID_PROXY= "allowUserIdProxy" KW_ALLOW_WAYPOINT_LINKS = "allowWaypointLinks" KW_ALLOW_DYNAMIC_LINK_ROUTES = "allowDynamicLinkRoutes" +KW_ALLOW_AMIN_STATUS_UPDATE = "allowAdminStatusUpdate" Review comment: This looks like a typo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a DELETE management > request. A connection id must be provided to delete a connection. When a > client deletes a connection object, the connection to the peer is terminated > by the router. Client will not be allowed to terminate inter-router > connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785902#comment-16785902 ] ASF GitHub Bot commented on DISPATCH-1275: -- ganeshmurthy commented on pull request #455: DISPATCH-1275 - Enabled deletion of connections based on connection i… URL: https://github.com/apache/qpid-dispatch/pull/455 …d. Added related policy code. By default, a user does not have privileges to delete a connection. A policy needs to allow this. Inter-router connections can never be deleted This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a DELETE management > request. A connection id must be provided to delete a connection. When a > client deletes a connection object, the connection to the peer is terminated > by the router. Client will not be allowed to terminate inter-router > connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org